Skip to content

Commit ae8bbd6

Browse files
[ci] Address upgrade-test review comments
Broaden workload coverage, tighten correctness, and wire the release gate so a failed upgrade-test actually blocks publication. * Phase 2 / Phase 4: add MariaDB (seed+verify rows), Kafka (cluster + topic survival via UID check), VMInstance (UID + phase=Running), and tenant Kubernetes cluster (TenantControlPlane Ready + UID). Keeps PostgreSQL data integrity as the deep canary. * STRICT_BASELINE env switch: Phase 1 reconcile check fails fast in CI (always pristine), stays lenient on long-lived dev clusters. tags.yaml sets STRICT_BASELINE=1. * Release gate: generate-changelog and update-website-docs now depend on upgrade-test. A failing job leaves the draft release unpromoted. * Correctness: empty-pod guards before kubectl exec, SemVer-correct pre-release filter (grep -v -- '-'), empty-stdout coalesce for the pre-upgrade cozystack-version read, 2m -> 10m upgrade timeout to cover the cozystack-migration-hook pre-upgrade Job. * Lint: register the oracle-vm-24cpu-96gb-x86-64 self-hosted runner label in .github/actionlint.yaml so actionlint stops flagging it. Signed-off-by: Myasnikov Daniil <[email protected]>
1 parent 33322b8 commit ae8bbd6

4 files changed

Lines changed: 380 additions & 14 deletions

File tree

‎.github/actionlint.yaml‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
self-hosted-runner:
2+
labels:
3+
- oracle-vm-24cpu-96gb-x86-64

‎.github/workflows/tags.yaml‎

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -317,7 +317,9 @@ jobs:
317317
echo "Attempt $attempt failed, retrying..."
318318
done
319319
320-
# Run the upgrade test: install previous version -> upgrade -> validate
320+
# Run the upgrade test: install previous version -> upgrade -> validate.
321+
# STRICT_BASELINE=1 makes Phase 1 fail fast on reconcile errors — the CI
322+
# sandbox is always pristine, so any baseline failure is a real bug.
321323
- name: Run upgrade test
322324
env:
323325
RELEASE_TAG: ${{ steps.tag.outputs.tag }}
@@ -326,6 +328,7 @@ jobs:
326328
make -C packages/core/testing \
327329
SANDBOX_NAME=$SANDBOX_NAME \
328330
UPGRADE_TARGET_TAG="${RELEASE_TAG}" \
331+
STRICT_BASELINE=1 \
329332
upgrade-cozystack
330333
331334
# Collect debug information (always runs)
@@ -353,11 +356,11 @@ jobs:
353356
generate-changelog:
354357
name: Generate Changelog
355358
runs-on: [self-hosted]
356-
needs: [prepare-release]
359+
needs: [prepare-release, upgrade-test]
357360
permissions:
358361
contents: write
359362
pull-requests: write
360-
if: needs.prepare-release.result == 'success'
363+
if: needs.prepare-release.result == 'success' && needs.upgrade-test.result == 'success'
361364
steps:
362365
- name: Generate GitHub App token
363366
id: app-token
@@ -518,8 +521,8 @@ jobs:
518521
update-website-docs:
519522
name: Update Website Docs
520523
runs-on: [self-hosted]
521-
needs: [generate-changelog, prepare-release]
522-
if: needs.generate-changelog.result == 'success' && needs.prepare-release.outputs.skip != 'true'
524+
needs: [generate-changelog, prepare-release, upgrade-test]
525+
if: needs.generate-changelog.result == 'success' && needs.prepare-release.outputs.skip != 'true' && needs.upgrade-test.result == 'success'
523526
permissions:
524527
contents: read
525528
steps:

0 commit comments

Comments
 (0)