You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit aa885c3
Browse filesBrowse the repository at this point in the historyBrowse files
docs(security): re-sync published pipeline copies to the current hardened revision
The published copies trailed the upstream pipeline by several revisions, and
that older revision carried defects since fixed upstream: a re-review stamp
spent before its issue existed, so a failed issue creation could lose a
CRITICAL for good; a sync ordering guard that never fired on stored records;
and a re-review that the original issue's label would revert on the next sync.
Publishing the method only helps an auditor if it is the method that runs.
All ten copies are again byte-exact with the upstream head. The status model
is now byte-exact as well rather than hand-sanitized, because upstream itself
uses placeholder identifiers. The README says the copies, documents included,
track the upstream head byte for byte, and that the "no upstream fix" naming
exception is a maintainer decision in the written report, never the generator's.
Assisted-by: LLM
Signed-off-by: tym83 <[email protected]>
@@ -61,16 +64,18 @@ Triage decisions are stored in `state/triage-overrides.json`:
61
64
62
65
| Field | Required | Description |
63
66
|-------|----------|-------------|
64
-
|`status`| Yes | One of: `confirmed`, `in-progress`, `fixed`, `false-positive`, `accepted-risk`|
67
+
|`status`| Yes | One of: `new`, `confirmed`, `in-progress`, `fixed`, `false-positive`, `accepted-risk`. `new` is the lifecycle entry state — a freshly-surfaced or awaiting-triage finding, including one the pipeline re-surfaces when an `accepted-risk` review window elapses|
65
68
|`reason`| Yes | Human-readable explanation of the decision |
66
69
|`decided_by`| Yes | GitHub handle of the maintainer |
67
-
|`decided_at`| Yes | Date of the decision (YYYY-MM-DD) |
70
+
|`decided_at`| Yes | Record time — when the pipeline recorded the decision. Full ISO-8601 (`YYYY-MM-DDTHH:MM:SS+00:00`); a bare `YYYY-MM-DD` is still accepted for hand-written entries. This is what the monthly report buckets on |
71
+
|`closed_at`| Yes | Event time — when the decision was actually made (the issue's close time for a synced decision, else the same as `decided_at`). Full ISO-8601. `sync_issues.py` orders decisions by this to break ties and reject a stale issue that reverts a newer decision, so a hand-written entry must carry it |
72
+
|`issue_number` / `issue_url`| For a decision synced from an issue | The issue whose label the record reflects. A label change on this issue is applied by the next triage sync even though its close time is unchanged; a different issue applies only if it closed later. When a review window elapses the pipeline moves these to the new re-review issue (or drops them when no issue is filed), so the old issue's label cannot revert the re-review |
68
73
|`review_after`| For `accepted-risk`| Date to re-evaluate (quarterly recommended) |
69
74
|`fix_version`| For `fixed`| Version where the fix is included |
70
75
|`fix_pr`| For `in-progress` / `fixed`| Link to the fix PR |
71
76
72
77
## Periodic Review
73
78
74
79
-`accepted-risk` findings must be reviewed every 90 days
75
-
- If `review_after` date has passed, the finding is flagged in the weekly digest
76
-
-`false-positive`findings are re-checked automatically when Trivy DB updates (if the CVE reappears with different metadata, it becomes `new` again)
80
+
- If `review_after` date has passed, the finding re-surfaces: CRITICAL and HIGH get a new triage issue, MEDIUM and LOW appear in the weekly report. Its record returns to `new` only once that issue exists (a failed issue creation is retried on the next run), and from then on it is the new issue, not the original one, whose label decides it
81
+
-`false-positive`is terminal: it carries no `review_after` and suppresses the finding indefinitely. There is no automatic re-check on Trivy database updates; if a false-positive needs revisiting (e.g. the finding's context changed), a maintainer re-opens or re-labels its issue and the next triage sync picks up the new decision.
Copy file name to clipboardExpand all lines: docs/security/pipeline/SECURITY_PIPELINE_POLICY.md
+2-2Lines changed: 2 additions & 2 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -71,9 +71,9 @@ Triage questions:
71
71
### 7. Disclosure
72
72
73
73
-**CRITICAL/HIGH (confirmed):** GitHub Security Advisory (draft, then published after fix)
74
-
-**MEDIUM/LOW:**Mentioned in monthly public security summary
74
+
-**Monthly public summary:**a finding is named (CVE identifier, package, fixed version) only once its fix is released. **In-progress and accepted-risk findings are published as severity counts only — CVE identifiers and package names are withheld until a fix is released**, because a named unfixed CVE crossed with this project's public, version-pinned component list locates unpatched exposure in a running deployment. The monthly report generator enforces this.
75
75
-**Raw scanner output** is never published
76
-
-**False positives and accepted risks** are documented internally but not published
76
+
-**False positives** are documented internally but not published
0 commit comments