You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit aa017ad
Browse filesBrowse the repository at this point in the historyBrowse files
fix(dashboard): split the tenant row link out of this branch
The #3822 work moves to its own PR. It needs more than a link: the row
link never renders for a direct child of tenant-root, because
realParentNamespace matches a parent by name prefix and a root-level
tenant is named tenant-<word> rather than tenant-root-<word>, so it
resolves to undefined and the row stays plain text. That is most
tenants on a normal cluster, so the fix as written barely applies.
Carrying the tenant in the URL also turned out to be entangled with the
tenant list's caching and with an apiserver that ignores the label
selector on LIST while honouring it on WATCH. Settling that does not
belong in a batch of small fixes.
The six remaining fixes are unaffected: they never depended on the
tenant link or on the URL parameter.
Assisted-By: Claude <[email protected]>
Signed-off-by: Myasnikov Daniil <[email protected]>
Copy file name to clipboardExpand all lines: packages/system/dashboard/images/console/CLAUDE.md
+3-1Lines changed: 3 additions & 1 deletion
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -77,7 +77,9 @@ same paths to `kubernetes.default.svc` using the pod's service-account token.
77
77
to a chunked-encoding WATCH against the same `resourceVersion`. Don't
78
78
poll. Don't add `refetchInterval`. If you need a one-shot, pass
79
79
`{ watch: false }`.
80
-
4.**Tenant scoping.** Most resources live in `tenant-<name>` namespaces. Pull the active tenant from `useTenantContext()` — never read the namespace from a URL param or guess it. A link that crosses tenants is the one exception, and it still does not read the namespace: it names the tenant in `?tenant=`, which `useTenantFromUrl` feeds into the context on each navigation. Without it a real `<a href>` opened by middle click or in a new tab runs no `onClick`, and a relative CR name resolves against whichever tenant was selected last — a different tenant's resource, behind a Delete confirm that shows only that name.
80
+
4.**Tenant scoping.** Most resources live in `tenant-<name>` namespaces.
81
+
Pull the active tenant from `useTenantContext()` — never read the
82
+
namespace from a URL param or guess it.
81
83
5.**Auth.** In production the SPA sits behind oauth2-proxy. The client
82
84
relies on cookies forwarded by nginx, and `/oauth2/userinfo` returns the
83
85
logged-in user. There is no token handling in the SPA itself.
0 commit comments