Repository navigation
Commit a731fb2
committed
fix(monitoring): count a central request as the receiver admitted it
The limiter refuses for good any request it counts above burst, and
burst was the receiver's 4 MiB cap. Processors ahead of it grow a
request: the sampler adds a tracestate to every span it keeps, and the
limiter counts a request as the collector re-encodes it, a few bytes
more per span, 13% for a span carrying only its IDs, the smallest
valid one. A request the receiver admitted near its cap was therefore
refused on every retry.
The limiter now runs right after memory_limiter, so it counts the
request before sampling, and burst is a quarter above the cap. The rate
is counted before sampling, so the store keeps only the sampled share
of it. The texts also say that a request above the cap gets a 400,
which senders do not retry.
Signed-off-by: Alexey Artamonov <[email protected]>1 parent 2813a29 commit a731fb2
13 files changed
Lines changed: 99 additions & 70 deletions
File tree
- api/apps/v1alpha1/tenant
- packages
- apps/tenant
- core/platform
- extra/monitoring
- system
- monitoring-rd/cozyrds
- monitoring
- templates/vtraces
- tests
- tenant-rd/cozyrds
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
21 | | - | |
| 21 | + | |
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
14 | | - | |
| 14 | + | |
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
662 | 662 | | |
663 | 663 | | |
664 | 664 | | |
665 | | - | |
666 | | - | |
667 | | - | |
668 | | - | |
669 | | - | |
670 | | - | |
671 | | - | |
672 | | - | |
673 | | - | |
674 | | - | |
675 | | - | |
676 | | - | |
677 | | - | |
| 665 | + | |
| 666 | + | |
| 667 | + | |
| 668 | + | |
| 669 | + | |
| 670 | + | |
| 671 | + | |
| 672 | + | |
| 673 | + | |
| 674 | + | |
| 675 | + | |
| 676 | + | |
| 677 | + | |
| 678 | + | |
| 679 | + | |
678 | 680 | | |
679 | 681 | | |
680 | 682 | | |
| |||
0 commit comments