Skip to content

Commit a3f97e5

Browse files
ci: align pre-commit zizmor with CI and set persist-credentials on ui-test
Review feedback (non-blocking): - .pre-commit-config.yaml pinned zizmor at v1.22.0 while the CI gate installs 1.26.1; the zizmorcore/zizmor-pre-commit rev is the zizmor version 1:1, so the gap meant local and CI runs could differ. Align the hook to v1.26.1. - ui-test.yaml's checkout did not set persist-credentials: false, unlike the other two workflows hardened here (build-main.yaml, zizmor.yml). Set it so the token is not left in .git/config for the later pnpm install step to read. Signed-off-by: Myasnikov Daniil <[email protected]> Assisted-By: Claude <[email protected]> Co-Authored-By: Claude Opus 4.8 <[email protected]>
1 parent 1f0c194 commit a3f97e5

2 files changed

Lines changed: 5 additions & 1 deletion

File tree

‎.github/workflows/ui-test.yaml‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,10 @@ jobs:
2929
steps:
3030
- name: Checkout repository
3131
uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4
32+
with:
33+
# No git pushes from this workflow; don't leave the token in .git/config
34+
# where a later `pnpm install` step could read it.
35+
persist-credentials: false
3236

3337
- name: Set up pnpm
3438
uses: pnpm/action-setup@b906affcce14559ad1aafd4ab0e942779e9f58b1 # v4

‎.pre-commit-config.yaml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ repos:
3030
# permissions (audit scope is set in .github/zizmor.yml). Runs offline so it needs
3131
# no GitHub token locally. The same gate runs tree-wide in .github/workflows/zizmor.yml.
3232
- repo: https://github.com/zizmorcore/zizmor-pre-commit
33-
rev: v1.22.0
33+
rev: v1.26.1
3434
hooks:
3535
- id: zizmor
3636
args: [--offline]

0 commit comments

Comments
 (0)