Skip to content

Commit a1b32f2

Browse files
ci(workflows): build Talos only when its sources changed (#4021)
Stacked on #4020, not independently mergeable. Nothing on the same-repo PR path consumes either half of what `build-talos` produces. `image-talos` pushes `${REGISTRY}/talos:pr-N-sha`, which no chart in the tree references and which is not even version-tagged here (`PUBLISH_VERSIONED` and `PUBLISH_FLOATING` are both 0). `image-matchbox` stamps `packages/extra/bootbox/images/matchbox.tag`, and that one line is the whole content of `pr-patch-fragment-talos` - checked against the artifact from a real run - but bootbox is opt-in and the E2E platform Package does not enable it, so no run pulls the image. Unstamped tag leaves installer artifact pointing at released matchbox, which is a valid ref nothing on this path resolves. So the job ran a privileged siderolabs imager build on every PR for two artifacts with no reader. Now it runs when the PR touched `packages/core/talos`, and `finalize` accepts a skipped result as well as a successful one. Without that second half skipping it would block finalize, and therefore e2e, on nearly every PR. Forks keep the unconditional build, and the reason is not about talos. `e2e-fork.yaml` publish job requires at least one OCI archive to exist, an invariant that holds today only because this job always ran, so a fork PR touching nothing under `packages/` would arrive with an empty export and fail a legitimate run. Teaching that guard what `plan` expected to build is work in the fork allowlist path and belongs in its own change. Saving is about 1.5-2 min of critical path. Main point is removing a privileged image build that nobody reads from every pull request. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **CI Improvements** - Pull request validation now runs Talos builds only when relevant changes require them, while retaining full validation for fork-based contributions. - Finalization correctly handles skipped Talos builds and preserves generated boot artifacts when builds succeed. - Changed-file detection now accounts for renames, deletions, and shared build inputs. - **Documentation** - Updated testing and build guidance to reflect the current validation behavior. - **Tests** - Added comprehensive coverage for build classification, workflow outputs, skipped jobs, and artifact handling. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
2 parents 8799a4e + 975ea6a commit a1b32f2

6 files changed

Lines changed: 287 additions & 17 deletions

File tree

‎.github/workflows/pull-requests.yaml‎

Lines changed: 37 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -79,6 +79,7 @@ jobs:
7979
matrix: ${{ steps.p.outputs.matrix }}
8080
any: ${{ steps.p.outputs.any }}
8181
touched: ${{ steps.p.outputs.touched }}
82+
talos: ${{ steps.p.outputs.talos }}
8283
steps:
8384
# Claim the required context for THIS run before anything can be merged on
8485
# the strength of the last one. Commit statuses are latest-wins per (sha,
@@ -182,6 +183,9 @@ jobs:
182183
matrix="$(hack/build-matrix.sh /tmp/changed.txt)"
183184
echo "Build matrix: $matrix"
184185
echo "matrix=$matrix" >> "$GITHUB_OUTPUT"
186+
talos="$(hack/build-talos-needed.sh /tmp/changed_norenames.txt)"
187+
echo "Talos build needed: $talos"
188+
echo "talos=$talos" >> "$GITHUB_OUTPUT"
185189
# Package dirs the PR edited (packages/<area>/<name>). Their committed
186190
# refs are the PR's intent and must survive the current-main overlay —
187191
# otherwise an upstream image bump in a non-build-unit package would be
@@ -444,21 +448,33 @@ jobs:
444448
path: _out/oci/*.oci.tar
445449
if-no-files-found: error
446450

447-
# Talos is its own leg: the installer tarball is heavy and the talos image is
451+
# Talos is its own leg: the installer tarball is heavy and the Talos image is
448452
# built from it, so both live in one job. No nocloud disk is built here any
449-
# more, and e2e no longer downloads one -- the container lane boots the Talos
450-
# image directly. `images/talos/profiles/nocloud.yaml` is therefore compiled
451-
# by nightly.yaml and by the tag build's `make assets` rather than per PR;
452-
# what a PR still compiles is installer.yaml, which shares every input with it
453-
# bar the platform and the output format. Always runs on non-docs PRs, because
454-
# the patch fragment and the installer chain need it regardless of the
455-
# per-package matrix scope.
453+
# more, and e2e no longer downloads one -- the container lane boots the
454+
# upstream Talos container image. `images/talos/profiles/nocloud.yaml` is
455+
# therefore compiled by nightly.yaml and by the tag build's `make assets`.
456+
#
457+
# For same-repo PRs, the plan job classifies the rename-blind changed-path
458+
# list with build-talos-needed.sh. That list includes direct Talos sources and
459+
# the shared Makefile/Buildx/workflow inputs that determine this job's output;
460+
# line-based classification avoids depending on the formatting of `touched`.
461+
# A successful run stamps packages/extra/bootbox/images/matchbox.tag, and
462+
# finalize preserves that generated ref when it overlays base-branch images.
463+
#
464+
# Fork PRs keep the previous unconditional behavior as a conservative scope
465+
# boundary. Their build/export and privileged publication path spans a second
466+
# workflow and is not optimized here. The installer job also exports an OCI
467+
# archive, so archive availability is not a reason to require Talos itself.
456468
build-talos:
457469
name: Build Talos
458470
needs: ["plan"]
459471
if: |
460472
needs.plan.outputs.code == 'true'
461473
&& !contains(github.event.pull_request.labels.*.name, 'release')
474+
&& (
475+
github.event.pull_request.head.repo.fork
476+
|| needs.plan.outputs.talos == 'true'
477+
)
462478
runs-on: oracle-vm-4cpu-16gb-x86-64
463479
timeout-minutes: 40
464480
permissions:
@@ -545,7 +561,7 @@ jobs:
545561
&& !contains(github.event.pull_request.labels.*.name, 'release')
546562
&& needs.checks.result == 'success'
547563
&& (needs.build.result == 'success' || needs.build.result == 'skipped')
548-
&& needs.build-talos.result == 'success'
564+
&& (needs.build-talos.result == 'success' || needs.build-talos.result == 'skipped')
549565
runs-on: oracle-vm-4cpu-16gb-x86-64
550566
timeout-minutes: 30
551567
permissions:
@@ -657,14 +673,25 @@ jobs:
657673
# including the empty directory the step above leaves when a line has no
658674
# artifact yet.
659675
run: |
660-
hack/overlay-main-images.sh _out/mainpkgs "$BUILD_MATRIX" "$PR_TOUCHED" \
676+
rebuilt="$BUILD_MATRIX"
677+
if [ "$TALOS_RESULT" = "success" ]; then
678+
case "$rebuilt" in
679+
'[]') rebuilt='["packages/extra/bootbox"]' ;;
680+
*) rebuilt="${rebuilt%]},\"packages/extra/bootbox\"]" ;;
681+
esac
682+
fi
683+
hack/overlay-main-images.sh _out/mainpkgs "$rebuilt" "$PR_TOUCHED" \
661684
|| echo "::warning::overlay-main-images failed; unbuilt packages keep committed refs"
662685
env:
663686
# The set of packages THIS PR rebuilt; their pr-<N>-<sha> refs are
664687
# authoritative, so overlay-main-images.sh skips them. Computed by the
665688
# plan job from the Makefile (a JSON array of package dirs), not from
666689
# untrusted PR input — passed via env per workflow-injection hygiene.
667690
BUILD_MATRIX: ${{ needs.plan.outputs.matrix }}
691+
# build-talos writes matchbox.tag under extra/bootbox rather than its
692+
# own package. Preserve that generated ref only when the job actually
693+
# succeeded; when it was skipped, the base-branch ref should overlay.
694+
TALOS_RESULT: ${{ needs.build-talos.result }}
668695
# Packages THIS PR edited (changed-file dirs from the plan job's git
669696
# diff). Their committed refs are the PR's intent — an upstream image
670697
# bump in a non-build-unit package would otherwise be silently reverted

‎docs/agents/e2e-testing.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ When adding a new app package, confirm `select-e2e.sh` maps it correctly (it has
9898

9999
Be precise about TIA's scope — it is narrower than "skip E2E for unrelated PRs," and the wiring has consequences worth knowing before you rely on it or change it.
100100

101-
- **It trims only which suites `chainsaw test` runs, not the expensive stages.** `Prepare environment` and `Install Cozystack` (the full platform install) run regardless of the selection. TIA only decides the `CHAINSAW_SUITES` passed to the final E2E step. A perfect narrow saves the suite tail, not the bulk of wall-time. (Package image builds are scoped separately — by `hack/build-matrix.sh`, on the PR diff — while the Talos and installer/finalize legs still run for non-docs PRs; that is a distinct mechanism from TIA's suite trimming.)
101+
- **It trims only which suites `chainsaw test` runs, not the expensive stages.** `Prepare environment` and `Install Cozystack` (the full platform install) run regardless of the selection. TIA only decides the `CHAINSAW_SUITES` passed to the final E2E step. A perfect narrow saves the suite tail, not the bulk of wall-time. (Package image builds are scoped separately by `hack/build-matrix.sh`; the Talos leg runs when its direct or shared inputs changed and remains unconditional for forks, while installer/finalize runs for every non-docs PR. That is a distinct mechanism from TIA's suite trimming.)
102102
- **`Select E2E tests` runs *after* `Install Cozystack` and has no `always()`.** GitHub implicitly ANDs a step's `if:` with `success()`, so if install fails the selector (and `Run E2E tests`) are skipped entirely. On a red install you will not see TIA narrow anything — that is the ordering, not a selector bug.
103103
- **Most PRs legitimately escalate to the full suite.** Platform manifests live under `packages/core/`, Go under `api/`/`internal/`, helpers under `hack/`, plus the `Makefile` — touching any one triggers the full suite. So "all suites selected" is usually correct, not a failure to narrow.
104104
- **Two skip layers, with a gap.** The `plan` job computes a coarse docs-only gate (`code`, true for any change outside `docs/**`) that skips the whole build+E2E pipeline for docs-only PRs, plus a per-package build matrix (`hack/build-matrix.sh`) that scopes which images build. TIA's finer skip (`select-e2e.sh` ignoring `docs/`, `dashboards/`, `*.md` and the rest of `inert_config_pattern`) only trims the suite selection. A PR touching only `dashboards/*.json` therefore still runs install, then skips just the Chainsaw suites — near-zero savings. If you need such PRs to skip the pipeline, widen the `plan` docs-gate, not `select-e2e.sh`.

‎hack/build-matrix.sh‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,9 +29,10 @@ full_rebuild_pattern='^(packages/library/|api/|cmd/|internal/|pkg/|hack/common-e
2929
#
3030
# packages/core/talos and packages/core/installer are deliberately excluded from
3131
# the parallel matrix and handled by dedicated jobs instead:
32-
# - talos: the nocloud disk image and the installer tarball are heavy and
33-
# shared through _out/assets; built once in an always-on leg
34-
# (e2e needs the disk on every non-docs PR regardless of scoping).
32+
# - talos: the installer tarball and Talos image are heavy; the dedicated
33+
# leg runs when its direct or shared build inputs changed (and
34+
# remains unconditional for forks). The container e2e lane does
35+
# not consume a per-PR nocloud disk.
3536
# - installer: its `flux push artifact --path=packages` bundles the ENTIRE,
3637
# digest-patched packages tree into the OCI artifact the operator
3738
# pulls, so it must run in the finalize step AFTER every other

‎hack/build-talos-gating_test.bats‎

Lines changed: 219 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,219 @@
1+
#!/usr/bin/env bats
2+
# Behavioral coverage for the Talos build classifier and the generated
3+
# matchbox-ref handoff into finalize. Workflow expression checks below pin only
4+
# producer/consumer wiring; GitHub job-result propagation is CI-only behavior.
5+
6+
ROOT="$(pwd)"
7+
CLASSIFIER="$ROOT/hack/build-talos-needed.sh"
8+
WF="$ROOT/.github/workflows/pull-requests.yaml"
9+
10+
classify_paths() {
11+
list="$1"
12+
shift
13+
printf '%s\n' "$@" > "$list"
14+
"$CLASSIFIER" "$list"
15+
}
16+
17+
cleanup_dir() {
18+
dir="$1"
19+
rm -rf "$dir"
20+
}
21+
22+
run_workflow_overlay() {
23+
fixture="$1"
24+
matrix="$2"
25+
talos_result="$3"
26+
touched="$4"
27+
step="$(yq '.jobs.finalize.steps[] | select(.name == "Overlay base-branch refs for unbuilt packages").run' "$WF")"
28+
[ -n "$step" ]
29+
mkdir -p "$fixture/hack"
30+
ln -s "$ROOT/hack/overlay-main-images.sh" "$fixture/hack/overlay-main-images.sh"
31+
(
32+
cd "$fixture"
33+
BUILD_MATRIX="$matrix"
34+
TALOS_RESULT="$talos_result"
35+
PR_TOUCHED="$touched"
36+
export BUILD_MATRIX TALOS_RESULT PR_TOUCHED
37+
dash -c "$step"
38+
)
39+
}
40+
41+
@test "classifies direct Talos paths by line, independent of order" {
42+
dir="$(mktemp -d)"
43+
list="$dir/changed"
44+
45+
[ "$(classify_paths "$list" packages/core/talos/file docs/readme.md)" = true ]
46+
[ "$(classify_paths "$list" docs/readme.md packages/core/talos/file cmd/tool/main.go)" = true ]
47+
[ "$(classify_paths "$list" docs/readme.md packages/core/talos/file)" = true ]
48+
[ "$(classify_paths "$list" packages/core/talos/file)" = true ]
49+
50+
cleanup_dir "$dir"
51+
}
52+
53+
@test "rejects whitespace and package-name lookalikes" {
54+
dir="$(mktemp -d)"
55+
list="$dir/changed"
56+
57+
[ "$(classify_paths "$list" packages/core/talos-something/file packages/core/talos docs/talos/file)" = false ]
58+
[ "$(classify_paths "$list" ' packages/core/talos/file' 'packages/core/talos/file ')" = false ]
59+
60+
cleanup_dir "$dir"
61+
}
62+
63+
@test "classifies every shared Talos build input and no unrelated root input" {
64+
dir="$(mktemp -d)"
65+
list="$dir/changed"
66+
67+
for path in \
68+
hack/common-envs.mk \
69+
hack/buildkitd.toml \
70+
.github/workflows/pull-requests.yaml \
71+
.dockerignore
72+
do
73+
[ "$(classify_paths "$list" "$path")" = true ]
74+
done
75+
[ "$(classify_paths "$list" internal/controller/controller.go go.mod packages/apps/postgres/values.yaml)" = false ]
76+
: > "$list"
77+
[ "$("$CLASSIFIER" "$list")" = false ]
78+
79+
cleanup_dir "$dir"
80+
}
81+
82+
@test "fails closed when the changed-path input is missing or not a file" {
83+
dir="$(mktemp -d)"
84+
85+
if "$CLASSIFIER" "$dir/missing" >/dev/null 2>&1; then
86+
echo "missing input was classified as a safe false" >&2
87+
exit 1
88+
fi
89+
if "$CLASSIFIER" "$dir" >/dev/null 2>&1; then
90+
echo "directory input was accepted as a changed-path file" >&2
91+
exit 1
92+
fi
93+
94+
cleanup_dir "$dir"
95+
}
96+
97+
@test "a real rename out of or into Talos is visible in the rename-blind list" {
98+
dir="$(mktemp -d)"
99+
repo="$dir/repo"
100+
list="$dir/changed"
101+
mkdir -p "$repo/packages/core/talos/profiles" "$repo/docs"
102+
git -C "$repo" init -q
103+
git -C "$repo" config user.email [email protected]
104+
git -C "$repo" config user.name CI
105+
git -C "$repo" config commit.gpgsign false
106+
git -C "$repo" config core.hooksPath /dev/null
107+
printf 'profile\n' > "$repo/packages/core/talos/profiles/installer.yaml"
108+
git -C "$repo" add .
109+
git -C "$repo" commit -q -m seed
110+
111+
git -C "$repo" mv packages/core/talos/profiles/installer.yaml docs/installer.yaml
112+
git -C "$repo" diff --name-status HEAD | grep -q '^R.*packages/core/talos/profiles/installer.yaml.*docs/installer.yaml$'
113+
git -C "$repo" diff --name-only --no-renames HEAD > "$list"
114+
[ "$("$CLASSIFIER" "$list")" = true ]
115+
116+
git -C "$repo" commit -q -am 'rename out'
117+
git -C "$repo" mv docs/installer.yaml packages/core/talos/profiles/installer.yaml
118+
git -C "$repo" diff --name-status HEAD | grep -q '^R.*docs/installer.yaml.*packages/core/talos/profiles/installer.yaml$'
119+
git -C "$repo" diff --name-only --no-renames HEAD > "$list"
120+
[ "$("$CLASSIFIER" "$list")" = true ]
121+
122+
cleanup_dir "$dir"
123+
}
124+
125+
@test "deleting a Talos input still selects the build" {
126+
dir="$(mktemp -d)"
127+
repo="$dir/repo"
128+
list="$dir/changed"
129+
mkdir -p "$repo/packages/core/talos/profiles"
130+
git -C "$repo" init -q
131+
git -C "$repo" config user.email [email protected]
132+
git -C "$repo" config user.name CI
133+
git -C "$repo" config commit.gpgsign false
134+
git -C "$repo" config core.hooksPath /dev/null
135+
printf 'profile\n' > "$repo/packages/core/talos/profiles/installer.yaml"
136+
git -C "$repo" add .
137+
git -C "$repo" commit -q -m seed
138+
139+
rm "$repo/packages/core/talos/profiles/installer.yaml"
140+
git -C "$repo" diff --name-only --no-renames HEAD > "$list"
141+
[ "$("$CLASSIFIER" "$list")" = true ]
142+
143+
cleanup_dir "$dir"
144+
}
145+
146+
@test "workflow wires the rename-blind classifier output and preserves job guards" {
147+
[ "$(yq '.jobs.plan.outputs.talos' "$WF")" = '${{ steps.p.outputs.talos }}' ]
148+
plan="$(yq '.jobs.plan.steps[] | select(.id == "p").run' "$WF")"
149+
printf '%s\n' "$plan" | grep -qF 'hack/build-talos-needed.sh /tmp/changed_norenames.txt'
150+
151+
gate="$(yq '.jobs["build-talos"].if' "$WF")"
152+
printf '%s\n' "$gate" | grep -qF "needs.plan.outputs.code == 'true'"
153+
printf '%s\n' "$gate" | grep -qF "needs.plan.outputs.talos == 'true'"
154+
printf '%s\n' "$gate" | grep -qF 'github.event.pull_request.head.repo.fork'
155+
printf '%s\n' "$gate" | grep -qF "!contains(github.event.pull_request.labels.*.name, 'release')"
156+
if printf '%s\n' "$gate" | grep -qF 'needs.plan.outputs.touched'; then
157+
echo "build-talos still uses the whitespace-formatted touched output" >&2
158+
exit 1
159+
fi
160+
}
161+
162+
@test "finalize accepts success or skipped and rejects other Talos results" {
163+
gate="$(yq '.jobs.finalize.if' "$WF")"
164+
165+
printf '%s\n' "$gate" | grep -qF "needs.build-talos.result == 'success'"
166+
printf '%s\n' "$gate" | grep -qF "needs.build-talos.result == 'skipped'"
167+
if printf '%s\n' "$gate" | grep -qE "needs\.build-talos\.result == '(failure|cancelled)'"; then
168+
echo "finalize admits a failed or cancelled Talos build" >&2
169+
exit 1
170+
fi
171+
}
172+
173+
@test "successful Talos output keeps the fresh bootbox digest during overlay" {
174+
dir="$(mktemp -d)"
175+
mkdir -p "$dir/packages/apps/foo/images" "$dir/_out/mainpkgs/apps/foo/images"
176+
mkdir -p "$dir/packages/extra/bootbox/images" "$dir/_out/mainpkgs/extra/bootbox/images"
177+
printf 'registry.example/foo:pr@sha256:foo-fresh\n' > "$dir/packages/apps/foo/images/foo.tag"
178+
printf 'registry.example/foo:main@sha256:foo-base\n' > "$dir/_out/mainpkgs/apps/foo/images/foo.tag"
179+
printf 'registry.example/matchbox:pr@sha256:fresh\n' > "$dir/packages/extra/bootbox/images/matchbox.tag"
180+
printf 'registry.example/matchbox:main@sha256:base\n' > "$dir/_out/mainpkgs/extra/bootbox/images/matchbox.tag"
181+
182+
run_workflow_overlay "$dir" '["packages/apps/foo"]' success ''
183+
grep -q 'sha256:foo-fresh' "$dir/packages/apps/foo/images/foo.tag"
184+
grep -q 'sha256:fresh' "$dir/packages/extra/bootbox/images/matchbox.tag"
185+
186+
cleanup_dir "$dir"
187+
}
188+
189+
@test "skipped Talos output accepts the base bootbox digest" {
190+
dir="$(mktemp -d)"
191+
mkdir -p "$dir/packages/extra/bootbox/images" "$dir/_out/mainpkgs/extra/bootbox/images"
192+
printf 'registry.example/matchbox:release@sha256:old\n' > "$dir/packages/extra/bootbox/images/matchbox.tag"
193+
printf 'registry.example/matchbox:main@sha256:base\n' > "$dir/_out/mainpkgs/extra/bootbox/images/matchbox.tag"
194+
195+
run_workflow_overlay "$dir" '[]' skipped ''
196+
grep -q 'sha256:base' "$dir/packages/extra/bootbox/images/matchbox.tag"
197+
198+
cleanup_dir "$dir"
199+
}
200+
201+
@test "an explicitly edited bootbox ref wins when Talos was skipped" {
202+
dir="$(mktemp -d)"
203+
mkdir -p "$dir/packages/extra/bootbox/images" "$dir/_out/mainpkgs/extra/bootbox/images"
204+
printf 'registry.example/matchbox:custom@sha256:edited\n' > "$dir/packages/extra/bootbox/images/matchbox.tag"
205+
printf 'registry.example/matchbox:main@sha256:base\n' > "$dir/_out/mainpkgs/extra/bootbox/images/matchbox.tag"
206+
207+
run_workflow_overlay "$dir" '[]' skipped 'packages/extra/bootbox'
208+
grep -q 'sha256:edited' "$dir/packages/extra/bootbox/images/matchbox.tag"
209+
210+
cleanup_dir "$dir"
211+
}
212+
213+
@test "the PR path has no consumer of the removed nocloud artifact" {
214+
code="$(grep -v '^[[:space:]]*#' "$WF")"
215+
if printf '%s\n' "$code" | grep -E 'name: talos-image|nocloud-amd64\.raw\.xz' | grep -v 'const diskId'; then
216+
echo "a PR-path step consumes a Talos artifact that the job can skip" >&2
217+
exit 1
218+
fi
219+
}

‎hack/build-talos-needed.sh‎

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
1+
#!/bin/sh
2+
# Print whether a changed-path list contains an input to the pull-request Talos
3+
# build. The caller supplies the rename-blind list so removals and both sides of
4+
# a rename are classified.
5+
set -eu
6+
7+
if [ "$#" -ne 1 ] || [ ! -f "$1" ] || [ ! -r "$1" ]; then
8+
echo "usage: build-talos-needed.sh <readable-changed-files>" >&2
9+
exit 2
10+
fi
11+
12+
pattern='^(packages/core/talos/[^[:space:]]+|hack/common-envs\.mk|hack/buildkitd\.toml|\.github/workflows/pull-requests\.yaml|\.dockerignore)$'
13+
14+
if grep -qE "$pattern" "$1"; then
15+
printf 'true\n'
16+
else
17+
status=$?
18+
if [ "$status" -ne 1 ]; then
19+
exit "$status"
20+
fi
21+
printf 'false\n'
22+
fi

‎hack/overlay-main-images.sh‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,10 @@
2424
# - packages the PR EDITED (TOUCHED, the plan job's changed-package dirs): the
2525
# PR's committed refs are its intent (e.g. an upstream image bump in a
2626
# non-build-unit package), so they must win over the artifact — never overlay.
27-
# - packages/core/talos and packages/core/installer: rebuilt unconditionally
28-
# by their dedicated jobs (build-talos / the finalize installer build),
29-
# which own those files — never overlay them.
27+
# - packages/core/talos and packages/core/installer: owned by dedicated jobs
28+
# (the input-gated build-talos job / the finalize installer build), so their
29+
# own files are never overlaid. A successful Talos job also adds its actual
30+
# output package, packages/extra/bootbox, to BUILT_JSON at the call site.
3031
# - vendored charts/ subtrees: upstream chart values we do not build.
3132
#
3233
# Surgical + self-validating: a file is overlaid only when every line that

0 commit comments

Comments
 (0)