Skip to content

Commit 9a782f6

Browse files
myasnikovdaniilmyasnikovdaniil
committed
fix(hack): keep the backup stack in the vminstance selective install
The vminstance Chainsaw suite carries the VMInstance and VMDisk Velero round-trips. Both build the cozy-default BackupStorageLocation and the platform bucket from the backupstrategy-controller package, but the selective install retained that package only for the database and broker suites. A selection of vminstance alone therefore installed a platform with no Bucket, no BucketClaim and no BSL, and both round-trips timed out on the BSL wait before running a step of the example scripts. Every pull request whose selection is exactly vminstance hits this, and that includes each edit to examples/backups/vmi and examples/backups/vmdisk, which select that suite on purpose. Assisted-by: LLM Signed-off-by: Myasnikov Daniil <[email protected]>
1 parent 3cd2612 commit 9a782f6

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

‎hack/select-install.sh‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,7 @@ suite_to_source() {
141141
# would also change reverse test selection.
142142
suite_runtime_sources() {
143143
case "$1" in
144-
clickhouse|etcd|kafka|kafka-metadata|mariadb|mongodb|postgres|rabbitmq|redis|valkey)
144+
clickhouse|etcd|kafka|kafka-metadata|mariadb|mongodb|postgres|rabbitmq|redis|valkey|vminstance)
145145
echo cozystack.backupstrategy-controller ;;
146146
gateway) echo cozystack.kubeovn-webhook ;;
147147
esac

‎hack/select-install_test.bats‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -177,7 +177,7 @@ assert_output_graph_error() {
177177
}
178178

179179
@test "backup suites keep the APIs used by their roundtrip examples" {
180-
for suite in clickhouse etcd kafka kafka-metadata mariadb mongodb postgres rabbitmq redis valkey; do
180+
for suite in clickhouse etcd kafka kafka-metadata mariadb mongodb postgres rabbitmq redis valkey vminstance; do
181181
keep=$(hack/select-install.sh "$suite")
182182
drop=$(hack/select-install.sh --disabled "$suite")
183183
for required in cozystack.backupstrategy-controller cozystack.backup-controller \

0 commit comments

Comments
 (0)