Skip to content

Commit 95a8b76

Browse files
Matthieuclaude
andcommitted
fix(vm-import): address CodeRabbit review comments
- Move dvName field definition to values.yaml so cozyvalues-gen picks it up instead of manually editing the auto-generated schema - Add language tag to fenced code block in ADOPTION_DESIGN.md (MD040) - Document that vms: [] is a no-op in README.md - Rewrite docs/adoption.md to match actual implementation: automatic adoption creates VMInstance CRDs with full dashboard management, not read-only labeling Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]> Signed-off-by: Matthieu <[email protected]>
1 parent 8f3f95b commit 95a8b76

4 files changed

Lines changed: 68 additions & 282 deletions

File tree

‎packages/apps/vm-import/ADOPTION_DESIGN.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ This generates a values file for creating a `VMInstance` Helm release.
9090

9191
## Architecture
9292

93-
```
93+
```text
9494
Forklift imports VM
9595
↓
9696
VirtualMachine (KubeVirt) created

‎packages/apps/vm-import/README.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -185,7 +185,7 @@ kubectl delete dv -n <namespace> -l forklift.konveyor.io/plan=<import-name>
185185

186186
| Name | Description | Type | Value |
187187
| ---------------- | --------------------------------------------------------------------------------- | ---------- | ------- |
188-
| `vms` | List of virtual machines to migrate. | `[]object` | `[]` |
188+
| `vms` | List of virtual machines to migrate. If empty (`[]`), no Plan or migration is created. | `[]object` | `[]` |
189189
| `vms[i].id` | The managed object reference ID of the VM in vSphere (e.g. `vm-123`). | `string` | `""` |
190190
| `vms[i].name` | Optional target name for the VM in KubeVirt. | `string` | `""` |
191191
| `warm` | Enable warm migration (incremental replication before cutover). | `bool` | `false` |

0 commit comments

Comments
 (0)