Skip to content

Commit 948163a

Browse files
kvapslllamnyp
authored andcommitted
Don't overcommit memory (#913)
This patch recreates the resource presets with a non-burstable memory allocation (request==limit) and without CPU limits. With the new presets the difference between the larger presets became meaningless, so their values were adjusted. Resolves #912 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Chores** - Updated resource presets across all application charts to remove CPU limits, align memory limits with requests, and standardize memory units for consistency. - Adjusted CPU and memory request values for larger presets in several applications. - Updated chart versions for all affected applications. - Refreshed version mappings to reflect latest commit hashes. - Added explicit resource configuration for Redis in the dashboard configuration. <!-- end of auto-generated comment: release notes by coderabbit.ai --> (cherry picked from commit 2c6338a) Signed-off-by: Timofei Larkin <[email protected]>
1 parent 0524eca commit 948163a

26 files changed

Lines changed: 175 additions & 166 deletions

File tree

‎.pre-commit-config.yaml‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ repos:
1818
(cd "$dir" && make generate)
1919
fi
2020
done
21+
git diff --color=always | cat
2122
'
2223
language: script
2324
files: ^.*$

‎packages/apps/clickhouse/Chart.yaml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ type: application
1616
# This is the chart version. This version number should be incremented each time you make changes
1717
# to the chart and its templates, including the app version.
1818
# Versions are expected to follow Semantic Versioning (https://semver.org/)
19-
version: 0.7.0
19+
version: 0.8.0
2020

2121
# This is the version number of the application being deployed. This version number should be
2222
# incremented each time you make changes to the application. Versions are not expected to

‎packages/apps/clickhouse/templates/_resources.tpl‎

Lines changed: 11 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -11,35 +11,34 @@ These presets are for basic testing and not meant to be used in production
1111
{{ include "resources.preset" (dict "type" "nano") -}}
1212
*/}}
1313
{{- define "resources.preset" -}}
14-
{{/* The limits are the requests increased by 50% (except ephemeral-storage and xlarge/2xlarge sizes)*/}}
1514
{{- $presets := dict
1615
"nano" (dict
1716
"requests" (dict "cpu" "100m" "memory" "128Mi" "ephemeral-storage" "50Mi")
18-
"limits" (dict "cpu" "150m" "memory" "192Mi" "ephemeral-storage" "2Gi")
17+
"limits" (dict "memory" "128Mi" "ephemeral-storage" "2Gi")
1918
)
2019
"micro" (dict
2120
"requests" (dict "cpu" "250m" "memory" "256Mi" "ephemeral-storage" "50Mi")
22-
"limits" (dict "cpu" "375m" "memory" "384Mi" "ephemeral-storage" "2Gi")
21+
"limits" (dict "memory" "256Mi" "ephemeral-storage" "2Gi")
2322
)
2423
"small" (dict
2524
"requests" (dict "cpu" "500m" "memory" "512Mi" "ephemeral-storage" "50Mi")
26-
"limits" (dict "cpu" "750m" "memory" "768Mi" "ephemeral-storage" "2Gi")
25+
"limits" (dict "memory" "512Mi" "ephemeral-storage" "2Gi")
2726
)
2827
"medium" (dict
29-
"requests" (dict "cpu" "500m" "memory" "1024Mi" "ephemeral-storage" "50Mi")
30-
"limits" (dict "cpu" "750m" "memory" "1536Mi" "ephemeral-storage" "2Gi")
28+
"requests" (dict "cpu" "500m" "memory" "1Gi" "ephemeral-storage" "50Mi")
29+
"limits" (dict "memory" "1Gi" "ephemeral-storage" "2Gi")
3130
)
3231
"large" (dict
33-
"requests" (dict "cpu" "1.0" "memory" "2048Mi" "ephemeral-storage" "50Mi")
34-
"limits" (dict "cpu" "1.5" "memory" "3072Mi" "ephemeral-storage" "2Gi")
32+
"requests" (dict "cpu" "1" "memory" "2Gi" "ephemeral-storage" "50Mi")
33+
"limits" (dict "memory" "2Gi" "ephemeral-storage" "2Gi")
3534
)
3635
"xlarge" (dict
37-
"requests" (dict "cpu" "1.0" "memory" "3072Mi" "ephemeral-storage" "50Mi")
38-
"limits" (dict "cpu" "3.0" "memory" "6144Mi" "ephemeral-storage" "2Gi")
36+
"requests" (dict "cpu" "2" "memory" "4Gi" "ephemeral-storage" "50Mi")
37+
"limits" (dict "memory" "4Gi" "ephemeral-storage" "2Gi")
3938
)
4039
"2xlarge" (dict
41-
"requests" (dict "cpu" "1.0" "memory" "3072Mi" "ephemeral-storage" "50Mi")
42-
"limits" (dict "cpu" "6.0" "memory" "12288Mi" "ephemeral-storage" "2Gi")
40+
"requests" (dict "cpu" "4" "memory" "8Gi" "ephemeral-storage" "50Mi")
41+
"limits" (dict "memory" "8Gi" "ephemeral-storage" "2Gi")
4342
)
4443
}}
4544
{{- if hasKey $presets .type -}}

‎packages/apps/ferretdb/Chart.yaml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ type: application
1616
# This is the chart version. This version number should be incremented each time you make changes
1717
# to the chart and its templates, including the app version.
1818
# Versions are expected to follow Semantic Versioning (https://semver.org/)
19-
version: 0.5.0
19+
version: 0.6.0
2020

2121
# This is the version number of the application being deployed. This version number should be
2222
# incremented each time you make changes to the application. Versions are not expected to

‎packages/apps/ferretdb/templates/_resources.tpl‎

Lines changed: 11 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -11,35 +11,34 @@ These presets are for basic testing and not meant to be used in production
1111
{{ include "resources.preset" (dict "type" "nano") -}}
1212
*/}}
1313
{{- define "resources.preset" -}}
14-
{{/* The limits are the requests increased by 50% (except ephemeral-storage and xlarge/2xlarge sizes)*/}}
1514
{{- $presets := dict
1615
"nano" (dict
1716
"requests" (dict "cpu" "100m" "memory" "128Mi" "ephemeral-storage" "50Mi")
18-
"limits" (dict "cpu" "150m" "memory" "192Mi" "ephemeral-storage" "2Gi")
17+
"limits" (dict "memory" "128Mi" "ephemeral-storage" "2Gi")
1918
)
2019
"micro" (dict
2120
"requests" (dict "cpu" "250m" "memory" "256Mi" "ephemeral-storage" "50Mi")
22-
"limits" (dict "cpu" "375m" "memory" "384Mi" "ephemeral-storage" "2Gi")
21+
"limits" (dict "memory" "256Mi" "ephemeral-storage" "2Gi")
2322
)
2423
"small" (dict
2524
"requests" (dict "cpu" "500m" "memory" "512Mi" "ephemeral-storage" "50Mi")
26-
"limits" (dict "cpu" "750m" "memory" "768Mi" "ephemeral-storage" "2Gi")
25+
"limits" (dict "memory" "512Mi" "ephemeral-storage" "2Gi")
2726
)
2827
"medium" (dict
29-
"requests" (dict "cpu" "500m" "memory" "1024Mi" "ephemeral-storage" "50Mi")
30-
"limits" (dict "cpu" "750m" "memory" "1536Mi" "ephemeral-storage" "2Gi")
28+
"requests" (dict "cpu" "500m" "memory" "1Gi" "ephemeral-storage" "50Mi")
29+
"limits" (dict "memory" "1Gi" "ephemeral-storage" "2Gi")
3130
)
3231
"large" (dict
33-
"requests" (dict "cpu" "1.0" "memory" "2048Mi" "ephemeral-storage" "50Mi")
34-
"limits" (dict "cpu" "1.5" "memory" "3072Mi" "ephemeral-storage" "2Gi")
32+
"requests" (dict "cpu" "1" "memory" "2Gi" "ephemeral-storage" "50Mi")
33+
"limits" (dict "memory" "2Gi" "ephemeral-storage" "2Gi")
3534
)
3635
"xlarge" (dict
37-
"requests" (dict "cpu" "1.0" "memory" "3072Mi" "ephemeral-storage" "50Mi")
38-
"limits" (dict "cpu" "3.0" "memory" "6144Mi" "ephemeral-storage" "2Gi")
36+
"requests" (dict "cpu" "2" "memory" "4Gi" "ephemeral-storage" "50Mi")
37+
"limits" (dict "memory" "4Gi" "ephemeral-storage" "2Gi")
3938
)
4039
"2xlarge" (dict
41-
"requests" (dict "cpu" "1.0" "memory" "3072Mi" "ephemeral-storage" "50Mi")
42-
"limits" (dict "cpu" "6.0" "memory" "12288Mi" "ephemeral-storage" "2Gi")
40+
"requests" (dict "cpu" "4" "memory" "8Gi" "ephemeral-storage" "50Mi")
41+
"limits" (dict "memory" "8Gi" "ephemeral-storage" "2Gi")
4342
)
4443
}}
4544
{{- if hasKey $presets .type -}}

‎packages/apps/http-cache/Chart.yaml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ type: application
1616
# This is the chart version. This version number should be incremented each time you make changes
1717
# to the chart and its templates, including the app version.
1818
# Versions are expected to follow Semantic Versioning (https://semver.org/)
19-
version: 0.4.0
19+
version: 0.5.0
2020

2121
# This is the version number of the application being deployed. This version number should be
2222
# incremented each time you make changes to the application. Versions are not expected to

‎packages/apps/http-cache/templates/_resources.tpl‎

Lines changed: 11 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -11,35 +11,34 @@ These presets are for basic testing and not meant to be used in production
1111
{{ include "resources.preset" (dict "type" "nano") -}}
1212
*/}}
1313
{{- define "resources.preset" -}}
14-
{{/* The limits are the requests increased by 50% (except ephemeral-storage and xlarge/2xlarge sizes)*/}}
1514
{{- $presets := dict
1615
"nano" (dict
1716
"requests" (dict "cpu" "100m" "memory" "128Mi" "ephemeral-storage" "50Mi")
18-
"limits" (dict "cpu" "150m" "memory" "192Mi" "ephemeral-storage" "2Gi")
17+
"limits" (dict "memory" "128Mi" "ephemeral-storage" "2Gi")
1918
)
2019
"micro" (dict
2120
"requests" (dict "cpu" "250m" "memory" "256Mi" "ephemeral-storage" "50Mi")
22-
"limits" (dict "cpu" "375m" "memory" "384Mi" "ephemeral-storage" "2Gi")
21+
"limits" (dict "memory" "256Mi" "ephemeral-storage" "2Gi")
2322
)
2423
"small" (dict
2524
"requests" (dict "cpu" "500m" "memory" "512Mi" "ephemeral-storage" "50Mi")
26-
"limits" (dict "cpu" "750m" "memory" "768Mi" "ephemeral-storage" "2Gi")
25+
"limits" (dict "memory" "512Mi" "ephemeral-storage" "2Gi")
2726
)
2827
"medium" (dict
29-
"requests" (dict "cpu" "500m" "memory" "1024Mi" "ephemeral-storage" "50Mi")
30-
"limits" (dict "cpu" "750m" "memory" "1536Mi" "ephemeral-storage" "2Gi")
28+
"requests" (dict "cpu" "500m" "memory" "1Gi" "ephemeral-storage" "50Mi")
29+
"limits" (dict "memory" "1Gi" "ephemeral-storage" "2Gi")
3130
)
3231
"large" (dict
33-
"requests" (dict "cpu" "1.0" "memory" "2048Mi" "ephemeral-storage" "50Mi")
34-
"limits" (dict "cpu" "1.5" "memory" "3072Mi" "ephemeral-storage" "2Gi")
32+
"requests" (dict "cpu" "1" "memory" "2Gi" "ephemeral-storage" "50Mi")
33+
"limits" (dict "memory" "2Gi" "ephemeral-storage" "2Gi")
3534
)
3635
"xlarge" (dict
37-
"requests" (dict "cpu" "1.0" "memory" "3072Mi" "ephemeral-storage" "50Mi")
38-
"limits" (dict "cpu" "3.0" "memory" "6144Mi" "ephemeral-storage" "2Gi")
36+
"requests" (dict "cpu" "2" "memory" "4Gi" "ephemeral-storage" "50Mi")
37+
"limits" (dict "memory" "4Gi" "ephemeral-storage" "2Gi")
3938
)
4039
"2xlarge" (dict
41-
"requests" (dict "cpu" "1.0" "memory" "3072Mi" "ephemeral-storage" "50Mi")
42-
"limits" (dict "cpu" "6.0" "memory" "12288Mi" "ephemeral-storage" "2Gi")
40+
"requests" (dict "cpu" "4" "memory" "8Gi" "ephemeral-storage" "50Mi")
41+
"limits" (dict "memory" "8Gi" "ephemeral-storage" "2Gi")
4342
)
4443
}}
4544
{{- if hasKey $presets .type -}}

‎packages/apps/kafka/Chart.yaml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ type: application
1616
# This is the chart version. This version number should be incremented each time you make changes
1717
# to the chart and its templates, including the app version.
1818
# Versions are expected to follow Semantic Versioning (https://semver.org/)
19-
version: 0.5.0
19+
version: 0.6.0
2020

2121
# This is the version number of the application being deployed. This version number should be
2222
# incremented each time you make changes to the application. Versions are not expected to

‎packages/apps/kafka/templates/_resources.tpl‎

Lines changed: 11 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -11,35 +11,34 @@ These presets are for basic testing and not meant to be used in production
1111
{{ include "resources.preset" (dict "type" "nano") -}}
1212
*/}}
1313
{{- define "resources.preset" -}}
14-
{{/* The limits are the requests increased by 50% (except ephemeral-storage and xlarge/2xlarge sizes)*/}}
1514
{{- $presets := dict
1615
"nano" (dict
1716
"requests" (dict "cpu" "100m" "memory" "128Mi" "ephemeral-storage" "50Mi")
18-
"limits" (dict "cpu" "150m" "memory" "192Mi" "ephemeral-storage" "2Gi")
17+
"limits" (dict "memory" "128Mi" "ephemeral-storage" "2Gi")
1918
)
2019
"micro" (dict
2120
"requests" (dict "cpu" "250m" "memory" "256Mi" "ephemeral-storage" "50Mi")
22-
"limits" (dict "cpu" "375m" "memory" "384Mi" "ephemeral-storage" "2Gi")
21+
"limits" (dict "memory" "256Mi" "ephemeral-storage" "2Gi")
2322
)
2423
"small" (dict
2524
"requests" (dict "cpu" "500m" "memory" "512Mi" "ephemeral-storage" "50Mi")
26-
"limits" (dict "cpu" "750m" "memory" "768Mi" "ephemeral-storage" "2Gi")
25+
"limits" (dict "memory" "512Mi" "ephemeral-storage" "2Gi")
2726
)
2827
"medium" (dict
29-
"requests" (dict "cpu" "500m" "memory" "1024Mi" "ephemeral-storage" "50Mi")
30-
"limits" (dict "cpu" "750m" "memory" "1536Mi" "ephemeral-storage" "2Gi")
28+
"requests" (dict "cpu" "500m" "memory" "1Gi" "ephemeral-storage" "50Mi")
29+
"limits" (dict "memory" "1Gi" "ephemeral-storage" "2Gi")
3130
)
3231
"large" (dict
33-
"requests" (dict "cpu" "1.0" "memory" "2048Mi" "ephemeral-storage" "50Mi")
34-
"limits" (dict "cpu" "1.5" "memory" "3072Mi" "ephemeral-storage" "2Gi")
32+
"requests" (dict "cpu" "1" "memory" "2Gi" "ephemeral-storage" "50Mi")
33+
"limits" (dict "memory" "2Gi" "ephemeral-storage" "2Gi")
3534
)
3635
"xlarge" (dict
37-
"requests" (dict "cpu" "1.0" "memory" "3072Mi" "ephemeral-storage" "50Mi")
38-
"limits" (dict "cpu" "3.0" "memory" "6144Mi" "ephemeral-storage" "2Gi")
36+
"requests" (dict "cpu" "2" "memory" "4Gi" "ephemeral-storage" "50Mi")
37+
"limits" (dict "memory" "4Gi" "ephemeral-storage" "2Gi")
3938
)
4039
"2xlarge" (dict
41-
"requests" (dict "cpu" "1.0" "memory" "3072Mi" "ephemeral-storage" "50Mi")
42-
"limits" (dict "cpu" "6.0" "memory" "12288Mi" "ephemeral-storage" "2Gi")
40+
"requests" (dict "cpu" "4" "memory" "8Gi" "ephemeral-storage" "50Mi")
41+
"limits" (dict "memory" "8Gi" "ephemeral-storage" "2Gi")
4342
)
4443
}}
4544
{{- if hasKey $presets .type -}}

‎packages/apps/kubernetes/templates/_resources.tpl‎

Lines changed: 11 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -11,35 +11,34 @@ These presets are for basic testing and not meant to be used in production
1111
{{ include "resources.preset" (dict "type" "nano") -}}
1212
*/}}
1313
{{- define "resources.preset" -}}
14-
{{/* The limits are the requests increased by 50% (except ephemeral-storage and xlarge/2xlarge sizes)*/}}
1514
{{- $presets := dict
1615
"nano" (dict
1716
"requests" (dict "cpu" "100m" "memory" "128Mi" "ephemeral-storage" "50Mi")
18-
"limits" (dict "cpu" "150m" "memory" "192Mi" "ephemeral-storage" "2Gi")
17+
"limits" (dict "memory" "128Mi" "ephemeral-storage" "2Gi")
1918
)
2019
"micro" (dict
2120
"requests" (dict "cpu" "250m" "memory" "256Mi" "ephemeral-storage" "50Mi")
22-
"limits" (dict "cpu" "375m" "memory" "384Mi" "ephemeral-storage" "2Gi")
21+
"limits" (dict "memory" "256Mi" "ephemeral-storage" "2Gi")
2322
)
2423
"small" (dict
2524
"requests" (dict "cpu" "500m" "memory" "512Mi" "ephemeral-storage" "50Mi")
26-
"limits" (dict "cpu" "750m" "memory" "768Mi" "ephemeral-storage" "2Gi")
25+
"limits" (dict "memory" "512Mi" "ephemeral-storage" "2Gi")
2726
)
2827
"medium" (dict
29-
"requests" (dict "cpu" "500m" "memory" "1024Mi" "ephemeral-storage" "50Mi")
30-
"limits" (dict "cpu" "750m" "memory" "1536Mi" "ephemeral-storage" "2Gi")
28+
"requests" (dict "cpu" "500m" "memory" "1Gi" "ephemeral-storage" "50Mi")
29+
"limits" (dict "memory" "1Gi" "ephemeral-storage" "2Gi")
3130
)
3231
"large" (dict
33-
"requests" (dict "cpu" "1.0" "memory" "2048Mi" "ephemeral-storage" "50Mi")
34-
"limits" (dict "cpu" "1.5" "memory" "3072Mi" "ephemeral-storage" "2Gi")
32+
"requests" (dict "cpu" "1" "memory" "2Gi" "ephemeral-storage" "50Mi")
33+
"limits" (dict "memory" "2Gi" "ephemeral-storage" "2Gi")
3534
)
3635
"xlarge" (dict
37-
"requests" (dict "cpu" "1.0" "memory" "3072Mi" "ephemeral-storage" "50Mi")
38-
"limits" (dict "cpu" "3.0" "memory" "6144Mi" "ephemeral-storage" "2Gi")
36+
"requests" (dict "cpu" "2" "memory" "4Gi" "ephemeral-storage" "50Mi")
37+
"limits" (dict "memory" "4Gi" "ephemeral-storage" "2Gi")
3938
)
4039
"2xlarge" (dict
41-
"requests" (dict "cpu" "1.0" "memory" "3072Mi" "ephemeral-storage" "50Mi")
42-
"limits" (dict "cpu" "6.0" "memory" "12288Mi" "ephemeral-storage" "2Gi")
40+
"requests" (dict "cpu" "4" "memory" "8Gi" "ephemeral-storage" "50Mi")
41+
"limits" (dict "memory" "8Gi" "ephemeral-storage" "2Gi")
4342
)
4443
}}
4544
{{- if hasKey $presets .type -}}

0 commit comments

Comments
 (0)