Repository navigation
Commit 904285f
committed
fix(e2e): stop the history helpers clobbering a caller variable
Both helpers assigned "statuses" without scoping it, so sourcing the
library and calling either one overwrote any variable of that name in
the caller. Seven bats suites source this library and the e2e guard
holds release history in variables of its own, so the collision was
reachable rather than theoretical.
Demonstrable in one line each: with a caller-set "statuses", both
functions returned with it replaced by their own argument.
Assisted-By: Claude <[email protected]>
Signed-off-by: Aleksei Sviridkin <[email protected]>1 parent 6caa009 commit 904285f
1 file changed
Lines changed: 5 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
63 | 63 | | |
64 | 64 | | |
65 | 65 | | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
66 | 69 | | |
| 70 | + | |
67 | 71 | | |
68 | 72 | | |
69 | 73 | | |
| |||
75 | 79 | | |
76 | 80 | | |
77 | 81 | | |
| 82 | + | |
78 | 83 | | |
79 | 84 | | |
80 | 85 | | |
| |||
0 commit comments