You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 8dbc7bc
Browse filesBrowse the repository at this point in the historyBrowse files
feat(kubevirt)!: drop HotplugVolumes for declarative volume hotplug
KubeVirt 1.9 deprecates HotplugVolumes in favour of
DeclarativeHotplugVolumes, which is Beta and therefore on by default,
but virt-controller skips declarative reconciliation for as long as the
old gate is on. Keeping it was only needed because kubevirt-csi
detached through the VMI-level removevolume, which virt-api accepts on
a VM-owned VMI only with the old gate. kubevirt-csi can now skip that
call, so its fallback goes off together with the gate. The two live in
different HelmReleases and roll out one after the other; in between the
driver may issue a VMI-level call virt-api rejects, and the unpublish
fails and is retried until both sides agree.
The chart now renders --enable-vmi-hotplug-fallback=false, which a
kubevirt-csi image built before the flag existed rejects at startup.
The driver image is stamped at release preparation, so this needs the
rebuilt image that ships in the same release.
DeclarativeHotplugVolumes is now listed explicitly. With HotplugVolumes
gone it is the only hotplug path, and disabling it through
disabledFeatureGates would make virt-api refuse every addvolume, so
the chart refuses that render instead.
This changes volume hotplug platform-wide. A VM-level addvolume or
removevolume now edits VM.spec directly and virt-controller reconciles
the VMI hotplug volumes against it, instead of going through
VM.status.volumeRequests. On the first reconcile it also removes every
hotpluggable VMI volume missing from VM.spec; platform migration 59
copies those into VM.spec beforehand on the variants that run
migrations.
Assisted-by: LLM
Signed-off-by: Aleksei Sviridkin <[email protected]>
- it: appends disabledFeatureGates after the static opt-outs
123
140
set:
124
141
disabledFeatureGates:
@@ -147,13 +164,17 @@ tests:
147
164
# entry cannot be disabled from values at all. The three cases further down
148
165
# that reach featureGates through extraFeatureGates get the message naming
149
166
# both sides instead, which is the distinction the copy also decides.
150
-
- it: refuses to render when disabledFeatureGates repeats HotplugVolumes
167
+
#
168
+
# DeclarativeHotplugVolumes is Beta and on by default, so listing it only
169
+
# matters for this guard: with HotplugVolumes off, disabling it would leave
170
+
# virt-api refusing every volume hotplug, kubevirt-csi attach included.
171
+
- it: refuses to render when disabledFeatureGates repeats DeclarativeHotplugVolumes
151
172
set:
152
173
disabledFeatureGates:
153
-
- HotplugVolumes
174
+
- DeclarativeHotplugVolumes
154
175
asserts:
155
176
- failedTemplate:
156
-
errorMessage: 'feature gate "HotplugVolumes" is one this chart enables and cannot be switched off from values: KubeVirt refuses a CR that names the same gate in both lists. Remove it from disabledFeatureGates.'
177
+
errorMessage: 'feature gate "DeclarativeHotplugVolumes" is one this chart enables and cannot be switched off from values: KubeVirt refuses a CR that names the same gate in both lists. Remove it from disabledFeatureGates.'
157
178
158
179
- it: refuses to render when disabledFeatureGates repeats ExpandDisks
0 commit comments