Skip to content

Commit 89a1fe5

Browse files
committed
build(multus): say why the image build runs no tests of the patched package
The other patched Go images now test the packages their patches touch in the builder stage. The one package the multus patch touches, pkg/multus, creates network namespaces in its tests, which a build container is not allowed to do, so that image keeps building without a test step. The Dockerfile records the reason, so the absence reads as a decision and not as an omission. Assisted-by: LLM Signed-off-by: Aleksei Sviridkin <[email protected]>
1 parent f51be95 commit 89a1fe5

1 file changed

Lines changed: 3 additions & 0 deletions

File tree

  • packages/system/multus/images/multus-cni

‎packages/system/multus/images/multus-cni/Dockerfile‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,9 @@ RUN git init && git config user.email "build@cozystack" && git config user.name
1313
git add -A && git commit -m "init" && git tag ${VERSION} && \
1414
git apply /patches/*.diff
1515

16+
# The tests of pkg/multus, the package the patch touches, create network
17+
# namespaces (mount --make-rshared /var/run/netns), which a build container is
18+
# not allowed to do, so the image build does not run them.
1619
RUN ./hack/build-go.sh
1720
# The upstream reference CNI plugins, installed into the host /opt/cni/bin by
1821
# the install-cni-plugins init container. See packages/system/multus/values.yaml

0 commit comments

Comments
 (0)