Repository navigation
Commit 867f5ba
committed
fix(site-router): label the diagnostics disk, and make a failing probe say what it saw
The suite finally got a tunnel up and failed on the first step that pushes a
packet through it, assert-inbound-source-preserved. Neither of the two
channels that exist to explain such a failure produced anything, and both
were broken in the same way: silently.
The diagnostics disk never had a label. KubeVirt takes the iso9660 label for a
Secret volume from Secret.VolumeLabel, not from the volume name
(kubevirt pkg/config/secret.go, getLabel returns v.Secret.VolumeLabel), and
the chart set no volumeLabel. So `blkid -L cozydiag` in the appliance seed
matched nothing on every run since the disk was introduced, the guest emitter
was never installed, and the comment above the volume asserted the opposite as
if it were checked. Both A's chart and B's manifest now set it. The seed also
says when the disk is absent instead of skipping in silence, which is what let
this sit unnoticed: the one channel that could have explained a failing guest
was itself missing, and nothing reported that.
The probe's own message does not reach the job log. A chainsaw script whose
command exits non-zero is reported as "($error == null): Invalid value:
false" and nothing else, so the echo written specifically to say which source
address the backend observed went nowhere. That address is the entire content
of the failure. _probe-lib.sh gains a `record` helper that appends
observations to the cozyreport snapshot the catch already collects, so they
survive whatever the log is doing, and the source-preservation probe uses it.
No cause for the source-preservation failure here. This is the round that
makes the next one able to name it.
Assisted-By: LLM
Signed-off-by: Myasnikov Daniil <[email protected]>1 parent 06b444e commit 867f5ba
5 files changed
Lines changed: 50 additions & 5 deletions
File tree
- hack/e2e-chainsaw/site-router
- packages
- apps/site-router/templates
- system/vyos-router-image/overlay
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
134 | 134 | | |
135 | 135 | | |
136 | 136 | | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
137 | 157 | | |
138 | 158 | | |
139 | 159 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
643 | 643 | | |
644 | 644 | | |
645 | 645 | | |
| 646 | + | |
| 647 | + | |
| 648 | + | |
| 649 | + | |
646 | 650 | | |
647 | 651 | | |
648 | 652 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
215 | 215 | | |
216 | 216 | | |
217 | 217 | | |
| 218 | + | |
| 219 | + | |
| 220 | + | |
| 221 | + | |
218 | 222 | | |
| 223 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
89 | 89 | | |
90 | 90 | | |
91 | 91 | | |
92 | | - | |
93 | | - | |
94 | | - | |
95 | | - | |
96 | | - | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
97 | 104 | | |
98 | 105 | | |
99 | 106 | | |
100 | 107 | | |
| 108 | + | |
101 | 109 | | |
102 | 110 | | |
103 | 111 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
52 | 52 | | |
53 | 53 | | |
54 | 54 | | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
55 | 63 | | |
56 | 64 | | |
57 | 65 | | |
| |||
0 commit comments