Repository navigation
Commit 84345c0
committed
test(site-router): run the suite in CI instead of parking it
The suite was parked as chainsaw-test.yaml.disabled because its appliance
image was not published. That is no longer true, and two paths supply the
ref between them. On a PR touching a vyos path the build-vyos job builds
the golden image and stamps the real ref@digest into
packages/apps/site-router/images/vyos-router-disk.tag through a patch
fragment Finalize merges before E2E runs. On every other PR that job is
skipped, and the ref arrives from the base branch instead: the root
`build:` recipe builds packages/system/vyos-router-image before
packages/core/installer, so the cozystack-packages artifact pushed from
main already carries the stamped .tag and finalize's overlay copies it
in. The other two reasons the header gave are stale as well --
_probe-lib.sh is the live T13 implementation rather than a set of seams,
and the firewall syntax it drives is the one the chart ships.
Renaming the file is the whole of the mechanism: the selector enumerates
a suite by its chainsaw-test.yaml, so the suite joins TIA selection and
every full-suite escalation with nothing else to change.
This needed #3817, which is now merged and in this branch through the
merge below it. Un-parking makes site-router the first suite to sit
downstream of cozystack-basics, and before that PR's propagation-hub
exclusion the platform's namespace-and-policy package silently dropped
from the full run to this one suite. Three guards pinned that and went
red: the two escalation guards on cozystack-basics and the exact-set
guard on system/postgres-operator, which reached this suite through the
same hub. With the exclusion in the tree, cozystack-basics escalates
again and postgres-operator is back to `harbor postgres`.
Two CDI guards move from an exact set to membership, for one reason in
both directions. kubevirt-cdi provisions the gateway's boot DataVolume,
so it reaches this suite as well as vminstance, and its selection is now
`site-router vminstance`. #3817's guard pinned `vminstance` alone and
this branch's own guard pinned `site-router` alone; each would read the
other's correct widening as a regression. What both rules actually owe
is that their suite is IN the selection, so that is what they assert.
Neither loses its teeth: dropping vminstance from the mapping still
fails the first, and stripping site-router from the selector output --
the #3392 shape -- still fails the second.
The stale claims inside the test go with the header: the three
"TODO(T13): live -- implement ..." notes described _probe-lib.sh helpers
that are written, and the port_security step called the VyOS 1.5
firewall syntax provisional after security-model.md recorded it as
validated live. What the header now records instead is the one thing the
two supply paths do not cover: when neither fires, the committed value
is a bare v0.0.0 placeholder that no build path ever publishes, and the
bring-up guard only rejects an EMPTY ref, so the run fails as a
VM-never-ready timeout rather than naming the cause.
Assisted-By: LLM
Signed-off-by: Myasnikov Daniil <[email protected]>1 parent 6091753 commit 84345c0
3 files changed
Lines changed: 105 additions & 61 deletions
File tree
- .github/workflows
- hack
- e2e-chainsaw/site-router
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
547 | 547 | | |
548 | 548 | | |
549 | 549 | | |
550 | | - | |
551 | | - | |
| 550 | + | |
| 551 | + | |
| 552 | + | |
| 553 | + | |
| 554 | + | |
| 555 | + | |
| 556 | + | |
| 557 | + | |
552 | 558 | | |
553 | 559 | | |
554 | 560 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
8 | | - | |
9 | | - | |
10 | | - | |
11 | | - | |
12 | | - | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
13 | 32 | | |
14 | | - | |
15 | | - | |
| 33 | + | |
16 | 34 | | |
17 | 35 | | |
18 | 36 | | |
| |||
412 | 430 | | |
413 | 431 | | |
414 | 432 | | |
415 | | - | |
416 | | - | |
417 | | - | |
| 433 | + | |
| 434 | + | |
| 435 | + | |
| 436 | + | |
| 437 | + | |
418 | 438 | | |
419 | 439 | | |
420 | 440 | | |
| |||
506 | 526 | | |
507 | 527 | | |
508 | 528 | | |
509 | | - | |
510 | | - | |
| 529 | + | |
| 530 | + | |
511 | 531 | | |
512 | 532 | | |
513 | 533 | | |
| |||
532 | 552 | | |
533 | 553 | | |
534 | 554 | | |
535 | | - | |
536 | | - | |
| 555 | + | |
| 556 | + | |
537 | 557 | | |
538 | 558 | | |
539 | 559 | | |
| |||
558 | 578 | | |
559 | 579 | | |
560 | 580 | | |
561 | | - | |
562 | | - | |
563 | | - | |
564 | | - | |
| 581 | + | |
| 582 | + | |
| 583 | + | |
| 584 | + | |
| 585 | + | |
565 | 586 | | |
566 | 587 | | |
567 | 588 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
119 | 119 | | |
120 | 120 | | |
121 | 121 | | |
122 | | - | |
123 | | - | |
124 | | - | |
125 | | - | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
126 | 133 | | |
127 | 134 | | |
128 | 135 | | |
129 | 136 | | |
130 | | - | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
131 | 141 | | |
132 | 142 | | |
133 | 143 | | |
| |||
1012 | 1022 | | |
1013 | 1023 | | |
1014 | 1024 | | |
1015 | | - | |
1016 | | - | |
1017 | | - | |
1018 | | - | |
1019 | | - | |
1020 | | - | |
1021 | | - | |
1022 | | - | |
1023 | | - | |
1024 | | - | |
1025 | | - | |
1026 | | - | |
| 1025 | + | |
| 1026 | + | |
| 1027 | + | |
| 1028 | + | |
| 1029 | + | |
| 1030 | + | |
| 1031 | + | |
| 1032 | + | |
| 1033 | + | |
| 1034 | + | |
| 1035 | + | |
1027 | 1036 | | |
1028 | 1037 | | |
1029 | 1038 | | |
| |||
1034 | 1043 | | |
1035 | 1044 | | |
1036 | 1045 | | |
1037 | | - | |
| 1046 | + | |
1038 | 1047 | | |
1039 | 1048 | | |
1040 | 1049 | | |
1041 | | - | |
1042 | | - | |
1043 | | - | |
1044 | | - | |
1045 | | - | |
| 1050 | + | |
| 1051 | + | |
| 1052 | + | |
| 1053 | + | |
| 1054 | + | |
| 1055 | + | |
| 1056 | + | |
| 1057 | + | |
| 1058 | + | |
| 1059 | + | |
| 1060 | + | |
| 1061 | + | |
| 1062 | + | |
| 1063 | + | |
1046 | 1064 | | |
1047 | 1065 | | |
1048 | | - | |
1049 | | - | |
1050 | | - | |
1051 | | - | |
1052 | | - | |
1053 | | - | |
| 1066 | + | |
| 1067 | + | |
| 1068 | + | |
| 1069 | + | |
| 1070 | + | |
| 1071 | + | |
1054 | 1072 | | |
1055 | 1073 | | |
1056 | 1074 | | |
1057 | | - | |
1058 | | - | |
1059 | | - | |
1060 | | - | |
| 1075 | + | |
| 1076 | + | |
| 1077 | + | |
1061 | 1078 | | |
1062 | 1079 | | |
1063 | | - | |
| 1080 | + | |
1064 | 1081 | | |
1065 | | - | |
| 1082 | + | |
1066 | 1083 | | |
1067 | 1084 | | |
1068 | 1085 | | |
1069 | | - | |
1070 | | - | |
1071 | | - | |
| 1086 | + | |
| 1087 | + | |
| 1088 | + | |
1072 | 1089 | | |
1073 | 1090 | | |
1074 | 1091 | | |
1075 | 1092 | | |
1076 | | - | |
1077 | | - | |
| 1093 | + | |
| 1094 | + | |
1078 | 1095 | | |
1079 | 1096 | | |
1080 | 1097 | | |
| |||
0 commit comments