Skip to content

Commit 7da29af

Browse files
committed
docs(postgres-operator): fix backoffLimit/activeDeadlineSeconds comment math
Address review feedback from coderabbitai on packages/system/postgres-operator/values.yaml:30. The old comment's 5-minute ImagePullBackOff scenario conflicted with the 180s activeDeadlineSeconds that the default maxAttempts/sleepSeconds resolve to, so the numbers could not both be taken at face value. Rewrite the comment to state the actual deadline math and frame the two gates as an AND with activeDeadlineSeconds being the shorter one under defaults, so readers understand why backoffLimit has little headroom without an accompanying maxAttempts/sleepSeconds bump. Assisted-By: Claude <[email protected]> Signed-off-by: Aleksei Sviridkin <[email protected]>
1 parent fc057c0 commit 7da29af

1 file changed

Lines changed: 4 additions & 2 deletions

File tree

‎packages/system/postgres-operator/values.yaml‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,8 @@ webhookReady:
2525
# Pod-level retry budget for transient node/registry failures (image pull rate limit,
2626
# OOM, CNI hiccup). The shell loop inside the container only covers reachability retries.
2727
# Pod retries and activeDeadlineSeconds (wall-clock bound on the whole Job across all
28-
# pod retries) are ANDed: a 5-minute ImagePullBackOff on attempt 0 leaves only ~60s for
29-
# subsequent retries before the Job is cut.
28+
# pod retries) are ANDed, so activeDeadlineSeconds is the shorter of the two gates with
29+
# the defaults above: the 60*2+60 = 180s deadline cuts the Job before backoffLimit=2
30+
# ever matters if pod-level failures eat more than ~60s of the budget. Raise
31+
# maxAttempts/sleepSeconds alongside backoffLimit when tuning for slow image pulls.
3032
backoffLimit: 2

0 commit comments

Comments
 (0)