Skip to content

Commit 7aadb4a

Browse files
fix(seaweedfs): only depend on ingress-nginx-system when tenant owns its ingress
Address review blocker on #2406: gate the dependsOn on `eq $ingress .Release.Namespace` so sub-tenants inheriting ingress from a parent namespace don't deadlock waiting for an HR that doesn't exist locally. Also add explicit `namespace:` to match repo convention. Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]> Signed-off-by: Myasnikov Daniil <[email protected]>
1 parent e382968 commit 7aadb4a

1 file changed

Lines changed: 5 additions & 1 deletion

File tree

‎packages/extra/seaweedfs/templates/seaweedfs.yaml‎

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,10 +104,14 @@ metadata:
104104
labels:
105105
sharding.fluxcd.io/key: tenants
106106
spec:
107-
{{- if $ingress }}
107+
{{- if eq $ingress .Release.Namespace }}
108108
# Ensure the ingress-nginx admission webhook is ready before creating Ingress resources.
109+
# Only when this tenant owns its ingress; sub-tenants inherit ingress from a parent
110+
# namespace where ingress-nginx-system already runs, and the dependency would deadlock
111+
# because the HR doesn't exist locally.
109112
dependsOn:
110113
- name: ingress-nginx-system
114+
namespace: {{ .Release.Namespace }}
111115
{{- end }}
112116
chartRef:
113117
kind: ExternalArtifact

0 commit comments

Comments
 (0)