Skip to content

Commit 77d42ab

Browse files
authored
ci(tests): fix OCIR registry login in Release E2E workflow (#2973)
## What this PR does The `Release E2E` workflow's build job logged into `iad.ocir.io` using `secrets.OCI_REGISTRY_USERNAME` / `secrets.OCI_REGISTRY_PASSWORD` — secret names that don't exist in the repo. `docker/login-action` therefore received empty credentials and failed at the very first step with `Username and password required`, before any image was built or any test ran. The workflow has **never** succeeded since it was added (2026-05-02): all three tag runs to date died at this step — `v1.5.0-rc.2`, `v1.5.0-rc.3`, and `v1.5.0`. This switches the login to the configured `OCIR_USER` / `OCIR_TOKEN` secrets — the same ones `build-main.yaml` and `pull-requests.yaml` use against the same registry — and adds the per-job Docker config isolation those workflows already use (`Set up Docker config` step + `DOCKER_CONFIG` env on the login and build steps), so the login doesn't clobber the shared `~/.docker/config.json` on the self-hosted runner. ### Release note ```release-note ci(tests): fix OCIR registry login in the Release E2E workflow so it can build and run the full suite on release tags ``` <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Release Notes * **Chores** * Improved the release workflow with enhanced Docker credential isolation and configuration handling during the build process. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
2 parents 93aac35 + 1a6dd6f commit 77d42ab

1 file changed

Lines changed: 12 additions & 2 deletions

File tree

‎.github/workflows/release-e2e.yaml‎

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,15 +36,25 @@ jobs:
3636
fetch-depth: 0
3737
fetch-tags: true
3838

39+
- name: Set up Docker config
40+
run: |
41+
if [ -d ~/.docker ]; then
42+
cp -r ~/.docker "${{ runner.temp }}/.docker"
43+
fi
44+
3945
- name: Login to registry
4046
uses: docker/login-action@v3
4147
with:
4248
registry: iad.ocir.io
43-
username: ${{ secrets.OCI_REGISTRY_USERNAME }}
44-
password: ${{ secrets.OCI_REGISTRY_PASSWORD }}
49+
username: ${{ secrets.OCIR_USER }}
50+
password: ${{ secrets.OCIR_TOKEN }}
51+
env:
52+
DOCKER_CONFIG: ${{ runner.temp }}/.docker
4553

4654
- name: Build images
4755
run: make build PUSH=1
56+
env:
57+
DOCKER_CONFIG: ${{ runner.temp }}/.docker
4858

4959
- name: Build Talos image
5060
run: make -C packages/core/talos build

0 commit comments

Comments
 (0)