Repository navigation
Commit 73c73df
committed
docs(vertical-pod-autoscaler): clean up dangling references to the retired migrator/rollout hooks
Self-review after the tls-migrator removal caught a stale comment in
certificate.yaml still promising that a pre-upgrade hook would strip
Helm/Flux ownership so cert-manager could adopt the legacy Secret in
place. That hook no longer exists and — as kvaps' review pointed out
— could not have done what it claimed anyway: \`Secret.type\` is
immutable, so cert-manager cannot rewrite an Opaque Secret in place
into a \`kubernetes.io/tls\` one.
Rewrite the certificate.yaml secretName comment to describe the
actual migration path: Helm garbage-collects the legacy Opaque
Secret from the release manifest, cert-manager immediately writes a
fresh \`kubernetes.io/tls\` Secret of the same name via this
Certificate, and the same-upgrade rollout — driven by the fresh
\`checksum/tls-cert\` annotation — brings up a pod that re-registers
\`vpa-webhook-config\` with the new caBundle before the delete/
create window on the MWC matters (given failurePolicy: Ignore).
Also refresh patches/cert-manager-admission-tls.diff to reflect the
comment edit and re-verify end-to-end that
\`rm -rf charts && helm pull && patch\` produces a byte-identical
tree to what git tracks. 15/15 helm-unittest cases still pass.
Signed-off-by: Ivan Okhotnikov <[email protected]>1 parent 5e65a3e commit 73c73df
2 files changed
Lines changed: 28 additions & 16 deletions
File tree
- packages/system/vertical-pod-autoscaler
- charts/vertical-pod-autoscaler/templates/admission-controller
- patches
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
64 | 64 | | |
65 | 65 | | |
66 | 66 | | |
67 | | - | |
68 | | - | |
69 | | - | |
70 | | - | |
71 | | - | |
72 | | - | |
73 | | - | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
74 | 80 | | |
75 | 81 | | |
76 | 82 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
| 3 | + | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
| 6 | + | |
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
| |||
70 | 70 | | |
71 | 71 | | |
72 | 72 | | |
73 | | - | |
74 | | - | |
75 | | - | |
76 | | - | |
77 | | - | |
78 | | - | |
79 | | - | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
80 | 86 | | |
81 | 87 | | |
82 | 88 | | |
| |||
0 commit comments