Skip to content

Commit 6f096b7

Browse files
committed
fix(e2e): give the kafka teardown delete its own timeout
The verify-pvc-reclaim-on-delete step deletes the projected Kafka and waits for it to return 404. There is no CR finalizer and no apps controller in that path: apps.cozystack.io is served by an aggregated apiserver that deletes the backing kafka-test HelmRelease synchronously in the request handler, and the wait then blocks on finalizers.fluxcd.io, which helm-controller holds until the release uninstall completes. That uninstall is the heaviest teardown in the suite. Since #3938 it runs a pre-delete hook Job first, then Strimzi tears down the broker and ZooKeeper StatefulSets and their deleteClaim PVCs. On the normal path the hook finishes in seconds and the Strimzi teardown dominates, landing on the suite-default delete: 5m boundary (#4260). That default was sized for finalizer-draining CRs elsewhere (VMDisk, FoundationDB, Tenant), so give this one step finite headroom rather than widen the global. 8m does not stack the hook's 270s deadline on top of a full teardown: a hook that burns that deadline means a wedged topic operator, where redding is correct. So a genuinely stuck uninstall still fails loudly. This is not the widen-instead-of-fix anti-pattern e2e-testing.md warns against (that targets an unbounded hang, #3271) — the teardown is bounded and #3938 already fixed the one hang that lived in this wait. Refs #4260 Signed-off-by: Alexey Artamonov <[email protected]>
1 parent b99db14 commit 6f096b7

1 file changed

Lines changed: 12 additions & 0 deletions

File tree

‎hack/e2e-chainsaw/kafka/chainsaw-test.yaml‎

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,19 @@ spec:
108108
kind: KafkaTopic
109109
metadata:
110110
name: kafka-test-test-orders
111+
# This delete waits for the projected Kafka to return 404, which happens only
112+
# once helm-controller drops finalizers.fluxcd.io from the backing kafka-test
113+
# HelmRelease — when its whole uninstall finishes. That is the heaviest
114+
# teardown in the suite: since #3938 a pre-delete hook Job runs first
115+
# (packages/apps/kafka/templates/hooks/delete.yaml), then Strimzi tears down
116+
# the broker and ZooKeeper StatefulSets and their deleteClaim PVCs, which
117+
# lands on the suite-default delete: 5m boundary (#4260). Give this one step
118+
# finite headroom rather than widen the global. 8m does not stack the hook's
119+
# 270s deadline on top of a full teardown — a hook that burns it means a
120+
# wedged topic operator, where redding is correct — so a stuck uninstall
121+
# still fails loudly.
111122
- delete:
123+
timeout: 8m
112124
ref:
113125
apiVersion: apps.cozystack.io/v1alpha1
114126
kind: Kafka

0 commit comments

Comments
 (0)