Skip to content

Commit 6ac52a1

Browse files
committed
docs(e2e): correct OIDC bats comments to match post-fix render behaviour
Both nodeGroups-omitted comments overstated the outcome as "zero MachineDeployments render", but the chart helper (kubernetes.nodeGroups) emits a default md0 group whenever the caller's nodeGroups map is empty, so exactly one MachineDeployment renders. What is actually zero is the number of KubevirtMachines / worker DataVolumes, because the chart no longer manages spec.replicas and CAPI's defaulting webhook seeds it to 0 from the autoscaler min-size annotation. kubernetes-oidc-system.bats additionally described the bug in the present tense ("chart hardcodes spec.replicas: 2 ... see #3231"), which contradicts the sibling customconfig comment and would read as an outstanding defect post-merge — rewrite it around the post-fix rationale to match customconfig's shape. Signed-off-by: IvanHunters <[email protected]>
1 parent b3aac80 commit 6ac52a1

2 files changed

Lines changed: 19 additions & 13 deletions

File tree

‎hack/e2e-apps/kubernetes-oidc-customconfig.bats‎

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -51,11 +51,14 @@ spec:
5151
replicas: 1
5252
# nodeGroups intentionally omitted — this is a render-side test that
5353
# only asserts on the KamajiControlPlane + the tenant-supplied issuer
54-
# AuthenticationConfiguration Secret. Combined with the chart change
55-
# that makes `MachineDeployment.spec.replicas` honour `minReplicas`,
56-
# dropping the field means zero MachineDeployments render and no
57-
# worker DataVolumes are touched, keeping the render-side test from
58-
# churning DRBD storage between CI runs (see #3231).
54+
# AuthenticationConfiguration Secret. With the schema default `{}`,
55+
# the chart helper emits the default `md0` group with
56+
# `minReplicas: 0` — exactly one MachineDeployment renders
57+
# (API-surface completeness) but the chart no longer manages
58+
# `spec.replicas`, so CAPI's defaulting webhook seeds it to 0
59+
# from the autoscaler min-size annotation. Result: zero
60+
# KubevirtMachines, zero worker DataVolumes, no DRBD churn between
61+
# CI runs (see #3231).
5962
version: v1.35
6063
oidc:
6164
mode: CustomConfig

‎hack/e2e-apps/kubernetes-oidc-system.bats‎

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -59,14 +59,17 @@ spec:
5959
replicas: 1
6060
# nodeGroups intentionally omitted — this is a render-side test that
6161
# only asserts on the KamajiControlPlane + the cozy-realm Keycloak
62-
# objects. The chart's MachineDeployment hardcodes spec.replicas: 2
63-
# even when a nodeGroup declares minReplicas: 0 (see #3231), so
64-
# keeping a worker nodeGroup here provisions two 20 GiB DRBD
65-
# DataVolumes on each `kubectl apply` and their churn overlaps
66-
# kubernetes-previous, flaking that test with LINSTOR pool pressure.
67-
# Dropping the field lets the schema default `{}` apply — zero
68-
# MachineDeployments rendered, zero worker DataVolumes touched,
69-
# test still exercises everything it claimed to.
62+
# objects. With the schema default `{}`, the chart helper emits the
63+
# default `md0` group with `minReplicas: 0` — exactly one
64+
# MachineDeployment renders (API-surface completeness) but the chart
65+
# no longer manages `spec.replicas`, so CAPI's defaulting webhook
66+
# seeds it to 0 from the autoscaler min-size annotation. Result:
67+
# zero KubevirtMachines, zero worker DataVolumes, no DRBD churn
68+
# overlapping `kubernetes-previous` (see #3231). Keeping an
69+
# explicit nodeGroup here would previously provision two 20 GiB
70+
# DRBD DataVolumes per `kubectl apply` because the chart hardcoded
71+
# `spec.replicas: 2`; the paired chart edit in this PR removes
72+
# that hardcoding.
7073
version: v1.35
7174
oidc:
7275
mode: System

0 commit comments

Comments
 (0)