Skip to content

Commit 6a44089

Browse files
committed
docs(kubevirt): name the disabledFeatureGates entry among unchecked lines
The disabledFeatureGates range renders each gate a user adds through a `- {{ . }}` line with the same shape as the extraFeatureGates entry, and no check looks at it either: deleting it from a copy of the CR leaves `make update` exiting 0 and the configured gate silently stops taking effect. The comment listed the extraFeatureGates entry alone, so it read as complete while one uncovered line was missing from it. Signed-off-by: Yan Bondarenko <[email protected]>
1 parent 5e7f047 commit 6a44089

1 file changed

Lines changed: 4 additions & 3 deletions

File tree

‎packages/system/kubevirt/Makefile‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -73,9 +73,10 @@ update:
7373
@# effect — the CR simply goes back to deploying virt-template, to letting
7474
@# KubeVirt skip NAD resource injection, and to image volumes an apiserver
7575
@# below 1.35 discards. Every other payload line stays outside these checks:
76-
@# the device tables, the cpuAllocationRatio value, and the extraFeatureGates
77-
@# entry, whose deletion leaves `make update` exiting 0 with the range wrapped
78-
@# around nothing. migrations is the one block validated whole, below.
76+
@# the device tables, the cpuAllocationRatio value, and the `- {{ . }}` entry
77+
@# inside each of the extraFeatureGates and disabledFeatureGates ranges, whose
78+
@# deletion leaves `make update` exiting 0 with the range wrapped around
79+
@# nothing. migrations is the one block validated whole, below.
7980
@# `make update` cannot repair a partial block — the directive guard is what
8081
@# stops the insert — so name the missing marker and let the operator restore
8182
@# it.

0 commit comments

Comments
 (0)