Skip to content

Commit 66a756b

Browse files
kvapsclaude
andcommitted
fix(ci): ensure correct latest release after backport publishing
Replace unreliable getLatestRelease() API with semver-based max version detection. After publishing a backport release, explicitly restore the latest flag on the highest semver release to handle cases where GitHub API ignores make_latest: 'false'. Also remove dead code (unused steps) from tags.yaml workflow. Co-Authored-By: Claude <[email protected]> Signed-off-by: Andrei Kvapil <[email protected]>
1 parent 7a964eb commit 66a756b

2 files changed

Lines changed: 75 additions & 73 deletions

File tree

‎.github/workflows/pull-requests-release.yaml‎

Lines changed: 75 additions & 47 deletions
Original file line numberDiff line numberDiff line change
@@ -110,67 +110,95 @@ jobs:
110110
}
111111
}
112112
113-
# Get the latest published release
114-
- name: Get the latest published release
115-
id: latest_release
116-
uses: actions/github-script@v7
117-
with:
118-
script: |
119-
try {
120-
const rel = await github.rest.repos.getLatestRelease({
121-
owner: context.repo.owner,
122-
repo: context.repo.repo
123-
});
124-
core.setOutput('tag', rel.data.tag_name);
125-
} catch (_) {
126-
core.setOutput('tag', '');
127-
}
128-
129-
# Compare current tag vs latest using semver-utils
130-
- name: Semver compare
131-
id: semver
132-
uses: madhead/[email protected]
133-
with:
134-
version: ${{ steps.get_tag.outputs.tag }}
135-
compare-to: ${{ steps.latest_release.outputs.tag }}
136-
137-
# Derive flags: prerelease? make_latest?
138-
- name: Calculate publish flags
139-
id: flags
113+
# Publish draft release and ensure correct latest flag
114+
- name: Publish draft release
140115
uses: actions/github-script@v7
141116
with:
142117
script: |
143-
const tag = '${{ steps.get_tag.outputs.tag }}'; // v0.31.5-rc.1
118+
const tag = '${{ steps.get_tag.outputs.tag }}';
144119
const m = tag.match(/^v(\d+\.\d+\.\d+)(-(?:alpha|beta|rc)\.\d+)?$/);
145120
if (!m) {
146121
core.setFailed(`❌ tag '${tag}' must match 'vX.Y.Z' or 'vX.Y.Z-(alpha|beta|rc).N'`);
147122
return;
148123
}
149-
const version = m[1] + (m[2] ?? ''); // 0.31.5-rc.1
150-
const isRc = Boolean(m[2]);
151-
core.setOutput('is_rc', isRc);
152-
const outdated = '${{ steps.semver.outputs.comparison-result }}' === '<';
153-
core.setOutput('make_latest', isRc || outdated ? 'false' : 'legacy');
124+
const isRc = Boolean(m[2]);
125+
126+
// Parse semver string to comparable numbers
127+
function parseSemver(v) {
128+
const match = v.replace(/^v/, '').match(/^(\d+)\.(\d+)\.(\d+)/);
129+
if (!match) return null;
130+
return {
131+
major: parseInt(match[1]),
132+
minor: parseInt(match[2]),
133+
patch: parseInt(match[3])
134+
};
135+
}
154136
155-
# Publish draft release with correct flags
156-
- name: Publish draft release
157-
uses: actions/github-script@v7
158-
with:
159-
script: |
160-
const tag = '${{ steps.get_tag.outputs.tag }}';
137+
// Compare two semver objects
138+
function compareSemver(a, b) {
139+
if (a.major !== b.major) return a.major - b.major;
140+
if (a.minor !== b.minor) return a.minor - b.minor;
141+
return a.patch - b.patch;
142+
}
143+
144+
const currentSemver = parseSemver(tag);
145+
146+
// Get all releases
161147
const releases = await github.rest.repos.listReleases({
162148
owner: context.repo.owner,
163-
repo: context.repo.repo
149+
repo: context.repo.repo,
150+
per_page: 100
164151
});
152+
153+
// Find draft release to publish
165154
const draft = releases.data.find(r => r.tag_name === tag && r.draft);
166155
if (!draft) throw new Error(`Draft release for ${tag} not found`);
156+
157+
// Find max semver among published releases (excluding current draft)
158+
const publishedReleases = releases.data
159+
.filter(r => !r.draft && !r.prerelease)
160+
.filter(r => /^v\d+\.\d+\.\d+$/.test(r.tag_name))
161+
.map(r => ({ id: r.id, tag: r.tag_name, semver: parseSemver(r.tag_name) }))
162+
.filter(r => r.semver !== null);
163+
164+
let maxRelease = null;
165+
for (const rel of publishedReleases) {
166+
if (!maxRelease || compareSemver(rel.semver, maxRelease.semver) > 0) {
167+
maxRelease = rel;
168+
}
169+
}
170+
171+
// Determine if this release should be latest
172+
const isOutdated = maxRelease && compareSemver(currentSemver, maxRelease.semver) < 0;
173+
const makeLatest = (isRc || isOutdated) ? 'false' : 'true';
174+
175+
if (isRc) {
176+
console.log(`🏷️ ${tag} is a prerelease, make_latest: false`);
177+
} else if (isOutdated) {
178+
console.log(`🏷️ ${tag} < ${maxRelease.tag} (max semver), make_latest: false`);
179+
} else {
180+
console.log(`🏷️ ${tag} is the highest version, make_latest: true`);
181+
}
182+
183+
// Publish the release
167184
await github.rest.repos.updateRelease({
168-
owner: context.repo.owner,
169-
repo: context.repo.repo,
170-
release_id: draft.id,
171-
draft: false,
172-
prerelease: ${{ steps.flags.outputs.is_rc }},
173-
make_latest: '${{ steps.flags.outputs.make_latest }}'
185+
owner: context.repo.owner,
186+
repo: context.repo.repo,
187+
release_id: draft.id,
188+
draft: false,
189+
prerelease: isRc,
190+
make_latest: makeLatest
174191
});
192+
console.log(`🚀 Published release ${tag}`);
175193
176-
console.log(`🚀 Published release for ${tag}`);
194+
// If this is a backport/outdated release, ensure the correct release is marked as latest
195+
if (isOutdated && maxRelease) {
196+
console.log(`🔧 Ensuring ${maxRelease.tag} remains the latest release...`);
197+
await github.rest.repos.updateRelease({
198+
owner: context.repo.owner,
199+
repo: context.repo.repo,
200+
release_id: maxRelease.id,
201+
make_latest: 'true'
202+
});
203+
console.log(`✅ Restored ${maxRelease.tag} as latest release`);
204+
}

‎.github/workflows/tags.yaml‎

Lines changed: 0 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -123,32 +123,6 @@ jobs:
123123
git commit -m "Prepare release ${GITHUB_REF#refs/tags/}" -s || echo "No changes to commit"
124124
git push origin HEAD || true
125125
126-
# Get `latest_version` from latest published release
127-
- name: Get latest published release
128-
if: steps.check_release.outputs.skip == 'false'
129-
id: latest_release
130-
uses: actions/github-script@v7
131-
with:
132-
script: |
133-
try {
134-
const rel = await github.rest.repos.getLatestRelease({
135-
owner: context.repo.owner,
136-
repo: context.repo.repo
137-
});
138-
core.setOutput('tag', rel.data.tag_name);
139-
} catch (_) {
140-
core.setOutput('tag', '');
141-
}
142-
143-
# Compare tag (A) with latest (B)
144-
- name: Semver compare
145-
if: steps.check_release.outputs.skip == 'false'
146-
id: semver
147-
uses: madhead/[email protected]
148-
with:
149-
version: ${{ steps.tag.outputs.tag }} # A
150-
compare-to: ${{ steps.latest_release.outputs.tag }} # B
151-
152126
# Create or reuse draft release
153127
- name: Create / reuse draft release
154128
if: steps.check_release.outputs.skip == 'false'

0 commit comments

Comments
 (0)