Repository navigation
Commit 64efac9
committed
fix(db-autoscaler): survive a restart mid-stuck-scale rollback
A controller restart or leader failover starts with an empty in-memory
state map. lastWritten was already reconstructed from status to keep the
ownership back-off durable, but lastConverged and the in-flight anchor
were not. So a restart that landed mid-stuck-scale initialized
lastConverged to the stuck (larger) current count, making safeRollbackTarget
a no-op (target == current), and lost inFlightSince so the convergence
deadline never elapsed. The auto-rollback degraded to a permanent
StuckScaling freeze at the stuck count instead of rolling back.
Restore lastConverged from status.lastConvergedReplicas and, when a scale
is still in flight, reconstruct inFlightSince from status.lastScaleTime, so
the deadline and rollback are measured across the failover. Covered by a
new reconciler test that fails without either restore.
Signed-off-by: Alexey Artamonov <[email protected]>1 parent 97b5ac9 commit 64efac9
2 files changed
Lines changed: 54 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
188 | 188 | | |
189 | 189 | | |
190 | 190 | | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
191 | 198 | | |
192 | 199 | | |
193 | 200 | | |
| |||
204 | 211 | | |
205 | 212 | | |
206 | 213 | | |
| 214 | + | |
| 215 | + | |
| 216 | + | |
| 217 | + | |
| 218 | + | |
| 219 | + | |
| 220 | + | |
| 221 | + | |
207 | 222 | | |
208 | 223 | | |
209 | 224 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
478 | 478 | | |
479 | 479 | | |
480 | 480 | | |
| 481 | + | |
| 482 | + | |
| 483 | + | |
| 484 | + | |
| 485 | + | |
| 486 | + | |
| 487 | + | |
| 488 | + | |
| 489 | + | |
| 490 | + | |
| 491 | + | |
| 492 | + | |
| 493 | + | |
| 494 | + | |
| 495 | + | |
| 496 | + | |
| 497 | + | |
| 498 | + | |
| 499 | + | |
| 500 | + | |
| 501 | + | |
| 502 | + | |
| 503 | + | |
| 504 | + | |
| 505 | + | |
| 506 | + | |
| 507 | + | |
| 508 | + | |
| 509 | + | |
| 510 | + | |
| 511 | + | |
| 512 | + | |
| 513 | + | |
| 514 | + | |
| 515 | + | |
| 516 | + | |
| 517 | + | |
| 518 | + | |
| 519 | + | |
0 commit comments