Skip to content

Commit 5f5d8e9

Browse files
authored
docs(governance): nominate @themoriarti as Reviewer for the Proxmox integration (#4439)
## What this PR does Nominates @themoriarti (Marian Koreniuk) as a **Reviewer** for the Proxmox integration, following the process in [CONTRIBUTOR_LADDER.md](https://github.com/cozystack/cozystack/blob/main/CONTRIBUTOR_LADDER.md#reviewer): - `.github/CODEOWNERS`: adds @themoriarti as a code owner of `packages/system/capi-providers-infraprovider-proxmox/` and `packages/system/proxmox-*/` (Proxmox CCM and CSI). Each rule keeps the full `/packages/system/` owner set, so no existing owner loses coverage, and the catch-all invariant (`hack/codeowners-invariant.bats`) holds. - `MAINTAINERS.md`: adds him to the Reviewers table. The scope is deliberately narrow: shared code such as `packages/apps/kubernetes*`, `api/apps` and the generic in-cluster IPAM provider stays with the existing owners. ### Why Marian has maintained the Proxmox integration since the first Proxmox bundle and is now landing the Cluster API infrastructure provider, CCM and CSI (#4087, #4088, #4089). Against the Reviewer requirements: - well over 10 accepted PRs, contributing since 2024; - has reviewed more than 20 PRs; - in-depth knowledge of, and commitment to, the Proxmox area. **Sponsors:** @kvaps (Ænix) and @kingdonb (Urmanac), which satisfies the "at least one sponsor from a different employer" requirement. ### Notes for merging - The Proxmox package directories arrive with #4087 and #4089. Merging this PR after them is cleanest, though a rule for a path that does not exist yet is harmless. - GitHub silently ignores CODEOWNERS handles without write access. After merge, an org admin needs to add @themoriarti as a repository collaborator with the **Write** role (currently read). ### Downstream repositories - [x] No downstream repository is affected by this change - [ ] [cozystack/website](https://github.com/cozystack/website) - follow-up: - [ ] [cozystack/terraform-provider-cozystack](https://github.com/cozystack/terraform-provider-cozystack) - follow-up: - [ ] [cozystack/ansible-cozystack](https://github.com/cozystack/ansible-cozystack) - follow-up: - [ ] [cozystack/ccp](https://github.com/cozystack/ccp) - follow-up: - [ ] [cozystack/talm](https://github.com/cozystack/talm) - follow-up: - [ ] [cozystack/cozyhr](https://github.com/cozystack/cozyhr) - follow-up: - [ ] [cozystack/cozy-proxy](https://github.com/cozystack/cozy-proxy) - follow-up: - [ ] [cozystack/cozystack-telemetry-server](https://github.com/cozystack/cozystack-telemetry-server) - follow-up: - [ ] [cozystack/external-apps-example](https://github.com/cozystack/external-apps-example) - follow-up: - [ ] [cozystack/examples](https://github.com/cozystack/examples) - follow-up: - [ ] [cozystack/community](https://github.com/cozystack/community) - follow-up: ### Release note ```release-note docs(governance): add @themoriarti as Reviewer for the Proxmox integration. ``` <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Chores** * Expanded code ownership and review coverage for Proxmox integrations, including infrastructure provider, cloud controller manager, and storage components. No end-user functionality changed. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
2 parents 76b3652 + e24ffa3 commit 5f5d8e9

2 files changed

Lines changed: 4 additions & 0 deletions

File tree

‎.github/CODEOWNERS‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,9 @@
4848

4949
/packages/system/keycloak*/ @kvaps @lllamnyp @lexfrei @myasnikovdaniil @IvanHunters @sircthulhu
5050

51+
/packages/system/capi-providers-infraprovider-proxmox/ @kvaps @lllamnyp @lexfrei @myasnikovdaniil @IvanHunters @sircthulhu @mattia-eleuteri @themoriarti
52+
/packages/system/proxmox-*/ @kvaps @lllamnyp @lexfrei @myasnikovdaniil @IvanHunters @sircthulhu @mattia-eleuteri @themoriarti
53+
5154
/cmd/flux-*/ @kvaps @lllamnyp @lexfrei @myasnikovdaniil @IvanHunters @kingdonb
5255
/internal/flux*/ @kvaps @lllamnyp @lexfrei @myasnikovdaniil @IvanHunters @kingdonb
5356
/packages/core/flux-aio/ @kvaps @lllamnyp @lexfrei @myasnikovdaniil @IvanHunters @kingdonb

‎MAINTAINERS.md‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ this table names the people and is kept in step with it.
3131
| Kirill Ilin | [@sircthulhu](https://github.com/sircthulhu) | Ænix | Controllers, Keycloak, system operators |
3232
| Andrey Kolkov | [@androndo](https://github.com/androndo) | Ænix | Backups |
3333
| Aleksei Artamonov | [@scooby87](https://github.com/scooby87) | Ænix | Virtualization (KubeVirt, vm-instance, vm-disk) |
34+
| Marian Koreniuk | [@themoriarti](https://github.com/themoriarti) | CageForge | Proxmox integration (Cluster API infrastructure provider, CCM, CSI) |
3435

3536
## Emeritus Maintainers
3637

0 commit comments

Comments
 (0)