Repository navigation
Commit 5b28a92
committed
fix(release): stop the persisted GITHUB_TOKEN from hijacking the tag push
v1.6.0's stable tag triggered no run of tags.yaml, so generate-changelog
and update-website-docs never ran for the release, while every rc tag
pushed by cut-prerelease.yaml triggered normally.
The finalize checkout ran with the default persist-credentials, which
writes the built-in GITHUB_TOKEN into .git/config as an
`http.https://github.com/.extraheader` Authorization header. That header
is sent on every request to github.com and beats the app token the tag
steps embed in the remote URL via `git remote set-url`, so the tag push
authenticated as GITHUB_TOKEN — and GitHub suppresses workflow triggers
for refs pushed with GITHUB_TOKEN. cut-prerelease.yaml differs only in
supplying the app token to checkout itself, which is why its tags fired.
Drop the persisted credential so the app token in the remote URL is the
only one, matching the pattern promote-rc.yaml already documents.
Nothing in the job needs it: every remote operation runs after its own
`set-url`.
Latent since 0697c02; v1.6.0 was the first release in which finalize
actually created the tag.
Assisted-By: Claude <[email protected]>
Signed-off-by: Myasnikov Daniil <[email protected]>1 parent d163a71 commit 5b28a92
1 file changed
Lines changed: 16 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
70 | 70 | | |
71 | 71 | | |
72 | 72 | | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
73 | 88 | | |
74 | 89 | | |
75 | 90 | | |
76 | 91 | | |
| 92 | + | |
77 | 93 | | |
78 | 94 | | |
79 | 95 | | |
| |||
0 commit comments