Skip to content

Commit 54eb731

Browse files
committed
test(monitoring): make the single-mode VPA absence assertions able to fail
containsDocument with not: true but no any: true is scoped to a single document, so the "no cluster VPA in single mode" and "no VPA when empty" assertions passed regardless of what the render actually held. Add any: true inside the matcher so they scan every document: a mutation that leaks the cluster VPAs into single mode now turns the suite red, and it is green on HEAD. Signed-off-by: Alexey Artamonov <[email protected]>
1 parent fabf769 commit 54eb731

1 file changed

Lines changed: 2 additions & 0 deletions

File tree

‎packages/system/monitoring/tests/vpa_traces_test.yaml‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -89,6 +89,7 @@ tests:
8989
apiVersion: autoscaling.k8s.io/v1
9090
kind: VerticalPodAutoscaler
9191
name: vpa-vtstorage-generic
92+
any: true
9293
not: true
9394

9495
- it: renders no trace VPA when tracingStorages is empty (tracing off)
@@ -97,4 +98,5 @@ tests:
9798
apiVersion: autoscaling.k8s.io/v1
9899
kind: VerticalPodAutoscaler
99100
name: vpa-vtinsert-generic
101+
any: true
100102
not: true

0 commit comments

Comments
 (0)