Skip to content

Commit 52ff635

Browse files
committed
[platform] Mark some secrets as non-user-facing
Some k8s secrets created when deploying managed applications are unhelpful to the end user or are outright not meant to be shown, because they contain internal credentials not meant to be presented to the user. This patch adds an `apps.cozystack.io/tenantresource=false` label to such resources which will be later used to filter out such secrets in the web UI. ```release-note [platform] Mark non-user-facing secrets as such to avoid clutter in the dashboard and leaking internal credentials. ``` Signed-off-by: Timofei Larkin <[email protected]>
1 parent 66b53cb commit 52ff635

8 files changed

Lines changed: 19 additions & 11 deletions

File tree

‎packages/apps/clickhouse/templates/backup-script.yaml‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@ apiVersion: v1
44
kind: Secret
55
metadata:
66
name: {{ .Release.Name }}-backup-script
7+
labels:
8+
apps.cozystack.io/tenantresource: "false"
79
stringData:
810
backup.sh: |
911
#!/bin/sh

‎packages/apps/mysql/templates/backup-script.yaml‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@ apiVersion: v1
44
kind: Secret
55
metadata:
66
name: {{ .Release.Name }}-backup-script
7+
labels:
8+
apps.cozystack.io/tenantresource: "false"
79
stringData:
810
backup.sh: |
911
#!/bin/sh

‎packages/apps/postgres/templates/init-script.yaml‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,8 @@ apiVersion: v1
3030
kind: Secret
3131
metadata:
3232
name: {{ .Release.Name }}-init-script
33+
labels:
34+
apps.cozystack.io/tenantresource: "false"
3335
stringData:
3436
init.sh: |
3537
#!/bin/bash

‎packages/apps/tenant/templates/tenant.yaml‎

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -5,17 +5,7 @@ metadata:
55
name: {{ include "tenant.name" . }}
66
namespace: {{ include "tenant.name" . }}
77
---
8-
apiVersion: v1
9-
kind: Secret
10-
metadata:
11-
name: {{ include "tenant.name" . }}
12-
namespace: {{ include "tenant.name" . }}
13-
annotations:
14-
kubernetes.io/service-account.name: {{ include "tenant.name" . }}
15-
type: kubernetes.io/service-account-token
16-
---
178
# == default role ==
18-
---
199
apiVersion: rbac.authorization.k8s.io/v1
2010
kind: Role
2111
metadata:

‎packages/apps/vpn/templates/secret.yaml‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,8 @@ apiVersion: v1
2222
kind: Secret
2323
metadata:
2424
name: {{ .Release.Name }}-vpn
25+
labels:
26+
apps.cozystack.io/tenantresource: "false"
2527
type: Opaque
2628
stringData:
2729
shadowbox_server_config.json: |

‎packages/apps/vpn/templates/tls.yaml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ data:
1414
tls.key: {{ index $existingSecret.data "tls.key" }}
1515
{{- else }}
1616
{{- with genSignedCert $cn nil nil 3650 $ca }}
17-
cacert: {{ b64enc $ca.Cert }}
17+
ca.crt: {{ b64enc $ca.Cert }}
1818
tls.crt: {{ b64enc .Cert }}
1919
tls.key: {{ b64enc .Key }}
2020
{{- end }}
Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
---
2+
apiVersion: v1
3+
kind: Secret
4+
metadata:
5+
name: {{ .Release.Namespace }}
6+
annotations:
7+
kubernetes.io/service-account.name: {{ .Release.Namespace }}
8+
type: kubernetes.io/service-account-token

‎packages/extra/monitoring/templates/alerta/alerta.yaml‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -192,6 +192,8 @@ apiVersion: v1
192192
kind: Secret
193193
metadata:
194194
name: alertmanager
195+
labels:
196+
apps.cozystack.io/tenantresource: "false"
195197
type: Opaque
196198
stringData:
197199
alertmanager.yaml: |

0 commit comments

Comments
 (0)