You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 529fb38
Browse filesBrowse the repository at this point in the historyBrowse files
fix(kubernetes): assemble the node group once in kubernetes-nodes
The TalosConfigTemplate name is a hash of the machine-config spec, and two
templates have to agree on it: talos-reconcile-job.yaml creates the object,
nodegroup.yaml points MachineDeployment.bootstrap.configRef at it. Sharing the
rendering was not enough — each file also assembled its own $group dict, one
with ten keys and one with four, so the two names agreed only by coincidence of
the keys the spec helper happens to read. Dropping "gpus" from the Job's dict
diverged them (ffdbe1 vs 0bbd2a on a GPU pool) with the whole suite still
green, which is the "templates do not exist" deadlock this fix exists to make
impossible.
Move the assembly into a single kubernetes-nodes.group helper, read back with
fromYaml at both call sites, so there is one input as well as one rendering.
Cover it too, since the seam can be reintroduced: the only literal pair in this
chart rendered with instanceType "", gpus [] and kubelet {}, all falsy, so a
dict missing those keys was indistinguishable from one carrying them. Add a
GPU-shaped pair across the two suites, and the notMatchRegex guard against the
old fixed name.
Document that talos.registryMirrors now sits inside the hashed spec, so
changing it rolls the pool's existing workers instead of only affecting nodes
created later.
No rendered output changes on default values: 84 + 150 helm unittests pass and
the golden hashes are unchanged.
Signed-off-by: Mattia Eleuteri <[email protected]>
Assisted-by: LLM
|`talos`| Talos worker image configuration. Keep in sync with the parent cluster's `talos`. |`object`|`{}`|
73
-
|`talos.version`| Talos release used for worker OS image and installer. Must satisfy the chart's Talos<->Kubernetes support matrix against the chosen `version`. |`string`|`v1.13.6`|
74
-
|`talos.schematicID`| Talos image-factory schematic ID. Defaults to the cozystack-tested vanilla schematic. Operators using custom schematics (system extensions, kernel args) override here. |`string`|`ce4c980550dd2ab1b17bbf2b08801c7eb59418eafe8f279833297925d67c7515`|
75
-
|`talos.imageFactoryURL`| Base URL of the Talos Image Factory that serves the worker OS disk image (the `openstack-amd64.raw.xz` raw artifact streamed in by CDI over HTTP). Defaults to the public factory. Point at a self-hosted Image Factory, a caching mirror, or an internal HTTP file server for air-gapped, rate-limited, or flaky-egress environments. No trailing slash. |`string`|`https://factory.talos.dev`|
76
-
|`talos.installerRepository`| OCI repository prefix for the Talos installer image used by the in-guest `talos-reconcile` upgrade Job. Resolved as `<installerRepository>/<schematicID>:<version>`. Defaults to the public factory's installer path. Override for air-gapped or mirrored registries. No trailing slash. |`string`|`factory.talos.dev/installer`|
77
-
|`talos.registryMirrors`| Talos `machine.registries.mirrors` passthrough for worker nodes: a map of upstream registry host to `{ endpoints: [ ... ] }`. Empty by default, so workers pull container images (the Talos `kubelet` image included) directly from the upstream registry. Point a host such as `ghcr.io` at an in-cluster pull-through mirror for air-gapped, rate-limited, or flaky-egress environments so a worker's boot does not depend on live public egress. Talos still falls back to the upstream registry unless a host also sets `skipFallback: true`, so a mirror alone does not enforce air-gap. Keep in sync with the parent kubernetes chart. |`object`|`{}`|
|`talos`| Talos worker image configuration. Keep in sync with the parent cluster's `talos`. |`object`|`{}`|
73
+
|`talos.version`| Talos release used for worker OS image and installer. Must satisfy the chart's Talos<->Kubernetes support matrix against the chosen `version`. |`string`|`v1.13.6`|
74
+
|`talos.schematicID`| Talos image-factory schematic ID. Defaults to the cozystack-tested vanilla schematic. Operators using custom schematics (system extensions, kernel args) override here. |`string`|`ce4c980550dd2ab1b17bbf2b08801c7eb59418eafe8f279833297925d67c7515`|
75
+
|`talos.imageFactoryURL`| Base URL of the Talos Image Factory that serves the worker OS disk image (the `openstack-amd64.raw.xz` raw artifact streamed in by CDI over HTTP). Defaults to the public factory. Point at a self-hosted Image Factory, a caching mirror, or an internal HTTP file server for air-gapped, rate-limited, or flaky-egress environments. No trailing slash. |`string`|`https://factory.talos.dev`|
76
+
|`talos.installerRepository`| OCI repository prefix for the Talos installer image used by the in-guest `talos-reconcile` upgrade Job. Resolved as `<installerRepository>/<schematicID>:<version>`. Defaults to the public factory's installer path. Override for air-gapped or mirrored registries. No trailing slash. |`string`|`factory.talos.dev/installer`|
77
+
|`talos.registryMirrors`| Talos `machine.registries.mirrors` passthrough for worker nodes: a map of upstream registry host to `{ endpoints: [ ... ] }`. Empty by default, so workers pull container images (the Talos `kubelet` image included) directly from the upstream registry. Point a host such as `ghcr.io` at an in-cluster pull-through mirror for air-gapped, rate-limited, or flaky-egress environments so a worker's boot does not depend on live public egress. Talos still falls back to the upstream registry unless a host also sets `skipFallback: true`, so a mirror alone does not enforce air-gap. This value is part of the worker machine config, whose content hash names the TalosConfigTemplate, so changing it rolls every existing worker in the pool rather than only affecting nodes created later. |`object`|`{}`|
0 commit comments