You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 5297ac7
Browse filesBrowse the repository at this point in the historyBrowse files
test(e2e): stop bringing up the monitoring instance nothing looks at
The install patched the root Tenant with monitoring: true and then spent
five separate 15m waits on the result: vmalert and vmalertmanager,
vlclusters/generic, vmcluster shortterm and longterm, the grafana-db
CNPG cluster, and the Grafana Deployment. Nothing in the run inspects
any of it.
No Chainsaw suite touches a monitoring object. The one that mentions
monitoring, foundationdb, asserts a WorkloadMonitor CR whose CRD belongs
to packages/system/cozystack-controller, not to the monitoring stack,
and passes without it. The two BATS files that did assert on monitoring,
hack/e2e-apps/monitoring-oidc-{system,customconfig}.bats, had no
invocation site after #2979 and were removed in #4019, where their
assertions turned out to be covered by
packages/system/monitoring/tests/oidc_test.yaml with 37 cases against
their 11.
The waits were not merely idle. Their own comment records the cost: "a
slow VictoriaLogs bring-up can fail the install on a pull request that
never touched monitoring", and the block had been unified onto 15m
precisely because the components contend for node capacity with the rest
of the bring-up. So this was a component the run never looked at,
holding a share of the 27-minute install and a share of its flake.
The monitoring PACKAGE stays installed. tenant-application declares
dependsOn cozystack.monitoring-application, so disabling it would leave
the root Tenant with an unresolved dependency and the platform
HelmRelease never Ready. Only the tenant-root instance is turned off.
One real check went with the block, and it is named in the file rather
than quietly dropped: a curl through root-ingress-controller at Host:
grafana.example.org, the only assertion that the root ingress actually
routes to a backend. Grafana was its target by availability rather than
by design. Restoring it wants a target the run installs anyway --
seaweedfs publishes s3.<root-host> and filer.<root-host> -- and choosing
the response to match needs a live stand, so it is a follow-up rather
than a guess made here.
Savings are unmeasured on purpose: the happy path never spent the 15m
budgets, so what this returns is the real bring-up time of the stack
plus the tail risk, and only a run can say what that is.
Assisted-By: Claude <[email protected]>
Signed-off-by: Myasnikov Daniil <[email protected]>
0 commit comments