|
| 1 | +#!/usr/bin/env bats |
| 2 | +# Every package image target builds through $(BUILDX_ARGS) from |
| 3 | +# hack/common-envs.mk, so PLATFORM, BUILDER, SBOM and BUILDX_EXTRA_ARGS reach |
| 4 | +# each `docker buildx build`. A target that spells its flags out instead builds |
| 5 | +# for the host architecture when PLATFORM is set: on an arm64 workstation that |
| 6 | +# is an arm64 image, which fails on amd64 nodes with "exec format error" while |
| 7 | +# CI, running on amd64, never shows it. |
| 8 | +# |
| 9 | +# The check is a dry run of `make image` with a platform no target hardcodes |
| 10 | +# and a marker passed through BUILDX_EXTRA_ARGS. Every buildx invocation it |
| 11 | +# prints must carry the marker, which only $(BUILDX_ARGS) forwards, and that |
| 12 | +# platform and no other, since a second hardcoded --platform turns the build |
| 13 | +# into a multi-platform one. |
| 14 | +# |
| 15 | +# Requires: make. |
| 16 | + |
| 17 | +REPO_ROOT="$(cd "$(dirname "${BATS_TEST_FILENAME:-$0}")/.." && pwd)" |
| 18 | +PROBE_PLATFORM="linux/riscv64" |
| 19 | +PROBE_MARKER="--build-arg=BUILDX_ARGS_PROBE=1" |
| 20 | + |
| 21 | +@test "every package image target passes BUILDX_ARGS and PLATFORM to docker buildx" { |
| 22 | + command -v make >/dev/null || { echo "make is required" >&2; exit 1; } |
| 23 | + |
| 24 | + failed="" |
| 25 | + checked=0 |
| 26 | + errlog="$(mktemp)" |
| 27 | + for makefile in "$REPO_ROOT"/packages/*/*/Makefile; do |
| 28 | + grep -q 'docker buildx build' "$makefile" || continue |
| 29 | + dir="$(dirname "$makefile")" |
| 30 | + # COZYSTACK_VERSION is set so common-envs.mk does not shell out to git. |
| 31 | + commands="$(make --no-print-directory -s -n -C "$dir" image \ |
| 32 | + PLATFORM="$PROBE_PLATFORM" BUILDX_EXTRA_ARGS="$PROBE_MARKER" COZYSTACK_VERSION=0.0.0 2>"$errlog" \ |
| 33 | + | sed -e ':a' -e '/\\$/N; s/\\\n//; ta' | grep 'docker buildx build')" || true |
| 34 | + if [ -z "$commands" ]; then |
| 35 | + failed="$failed ${dir#"$REPO_ROOT"/} (no buildx command: $(tr '\n' ' ' <"$errlog"))" |
| 36 | + continue |
| 37 | + fi |
| 38 | + while IFS= read -r cmd; do |
| 39 | + checked=$((checked + 1)) |
| 40 | + case "$cmd" in |
| 41 | + *"$PROBE_MARKER"*) ;; |
| 42 | + *) failed="$failed ${dir#"$REPO_ROOT"/} (no \$(BUILDX_ARGS))"; continue ;; |
| 43 | + esac |
| 44 | + platforms="$(grep -oE -- '--platform[= ][^ ]+' <<<"$cmd" | tr '\n' ' ')" |
| 45 | + [ "$platforms" = "--platform=$PROBE_PLATFORM " ] || failed="$failed ${dir#"$REPO_ROOT"/} ($platforms)" |
| 46 | + done <<<"$commands" |
| 47 | + done |
| 48 | + rm -f "$errlog" |
| 49 | + |
| 50 | + [ "$checked" -gt 0 ] # the glob must find image targets at all |
| 51 | + if [ -n "$failed" ]; then |
| 52 | + echo "image targets not building through BUILDX_ARGS for exactly PLATFORM:$failed" >&2 |
| 53 | + exit 1 |
| 54 | + fi |
| 55 | +} |
0 commit comments