Skip to content

Commit 4f5ae28

Browse files
authored
[backups] Fix malformed glob and split in template (#1708)
## What this PR does A malformed glob ("*" instead of "*.yaml") captured the .gitattributes file and sent it to the templating engine. Using `split` instead of `splitList` on a string returned a map instead of a list, so templating broke on `mustLast`. This patch corrects the errors. ### Release note ```release-note [backups] Fix template-breaking errors in the backup-controller Helm chart. ```
2 parents 8513dd6 + 6b8c490 commit 4f5ae28

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
{{- range $path, $_ := .Files.Glob "definitions/*" }}
1+
{{- range $path, $_ := .Files.Glob "definitions/*.yaml" }}
22
---
33
{{ $.Files.Get $path }}
44
{{- end }}

‎packages/system/backup-controller/templates/deployment.yaml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ spec:
3737
{{- end }}
3838
ports:
3939
- name: metrics
40-
containerPort: {{ split ":" .Values.backupController.metrics.bindAddress | mustLast }}
40+
containerPort: {{ splitList ":" .Values.backupController.metrics.bindAddress | mustLast }}
4141
- name: health
4242
containerPort: 8081
4343
readinessProbe:

0 commit comments

Comments
 (0)