Repository navigation
Commit 49d483c
committed
fix(linstor): exempt the satellite from a memory limit, like the controller
The satellite sizing rested on a false premise. The comment claimed the
satellite is "a Go binary with a bounded working set" and sized a 2Gi
limit on that basis, but it is the same Java linstor-server distribution
the controller runs: images/piraeus-server/Dockerfile installs
default-jre-headless and this container starts with `startSatellite`,
against the controller's `startController`.
That matters in the direction the sizing went. A memory.max is not only
an RSS ceiling on a JVM, it is what container-aware heap sizing reads, so
a 2Gi limit yields a heap of roughly a quarter of that while the 368Mi
peak behind the request is already whole-process RSS. On a storage node
with a large DRBD resource count that trades a rare pressure-driven kill
for an OutOfMemoryError or GC thrash mid-operation, which is exactly the
failure linstor-controller is exempted to avoid.
So the satellite now carries requests and no limit, the same call
cluster_test.yaml already pins for the controller. The cost is explicit
rather than implicit: with this container limit-free the pod cgroup gets
no memory.max, so the pod stays in the Talos OOM handler's victim set and
the plunger sidecar limits bound a runaway sidecar and nothing more.
Closing that needs a peak measured on a high-resource-count cluster plus
an explicit heap share, not a guessed ceiling.
satellites_test.yaml pins the exemption with notExists on the limit, so
re-adding a ceiling fails the suite rather than passing quietly.
Assisted-By: Claude <[email protected]>
Signed-off-by: Myasnikov Daniil <[email protected]>1 parent c9ba7a3 commit 49d483c
3 files changed
Lines changed: 31 additions & 19 deletions
File tree
- packages/system/linstor
- templates
- tests
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
24 | | - | |
25 | | - | |
26 | | - | |
27 | | - | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
28 | 34 | | |
29 | 35 | | |
30 | 36 | | |
31 | 37 | | |
32 | 38 | | |
33 | | - | |
34 | | - | |
35 | 39 | | |
36 | 40 | | |
37 | 41 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
15 | | - | |
16 | | - | |
17 | | - | |
18 | | - | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
19 | 20 | | |
20 | 21 | | |
21 | 22 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
9 | | - | |
10 | | - | |
11 | | - | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
12 | 15 | | |
13 | | - | |
14 | | - | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
15 | 20 | | |
16 | 21 | | |
17 | 22 | | |
18 | 23 | | |
19 | 24 | | |
20 | 25 | | |
21 | | - | |
| 26 | + | |
22 | 27 | | |
23 | 28 | | |
24 | | - | |
25 | | - | |
26 | | - | |
27 | 29 | | |
28 | 30 | | |
29 | 31 | | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
30 | 37 | | |
31 | 38 | | |
32 | 39 | | |
| |||
0 commit comments