Skip to content

Commit 450e2e8

Browse files
kvapsclaude
andcommitted
refactor(linstor): hardcode relocate defaults, remove SC/VSC parameters
Hardcode relocateAfterClone=true and relocateAfterRestore=false as defaults in the CSI driver patch instead of exposing them via StorageClass/VolumeSnapshotClass parameters. Remove the extra linstor-snapshots-ephemeral VolumeSnapshotClass (Velero) and the relocateAfterRestore parameter from the default VolumeSnapshotClass. This is a temporary measure while upstream linstor-server is deciding on the interface for the rebalance feature (see LINBIT/linstor-server#487). Once upstream provides native rebalance support, these hardcoded defaults will be replaced by the proper upstream mechanism. Co-Authored-By: Claude <[email protected]> Signed-off-by: Andrei Kvapil <[email protected]>
1 parent 37a6816 commit 450e2e8

2 files changed

Lines changed: 1 addition & 12 deletions

File tree

‎packages/system/linstor/images/linstor-csi/patches/001-relocate-after-clone-restore.diff‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -264,7 +264,7 @@ index 39acd95..aed18ab 100644
264264
NfsServiceName: "linstor-csi-nfs",
265265
NfsSquash: "no_root_squash",
266266
NfsRecoveryVolumeBytes: 300 * 1024 * 1024,
267-
+ RelocateAfterClone: false,
267+
+ RelocateAfterClone: true,
268268
}
269269

270270
for k, v := range params {

‎packages/system/linstor/templates/volumesnapshotclass.yaml‎

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -6,14 +6,3 @@ metadata:
66
name: linstor-snapshots
77
driver: linstor.csi.linbit.com
88
deletionPolicy: Delete
9-
parameters:
10-
snap.linstor.csi.linbit.com/relocateAfterRestore: "true"
11-
---
12-
apiVersion: snapshot.storage.k8s.io/v1
13-
kind: VolumeSnapshotClass
14-
metadata:
15-
annotations:
16-
velero.io/csi-volumesnapshot-class: "true"
17-
name: linstor-snapshots-ephemeral
18-
driver: linstor.csi.linbit.com
19-
deletionPolicy: Delete

0 commit comments

Comments
 (0)