Skip to content

Commit 44848b9

Browse files
authored
fix(kubernetes): run Proxmox CCM v0.16.1 and pin the Proxmox images by digest (#4917)
## What this PR does `v1.7.0-rc.1` and `release-1.7` ship the Proxmox cloud-controller-manager as `ghcr.io/sergelogvinov/proxmox-cloud-controller-manager:v0.15.0`, a bare tag. That tag was re-pushed upstream on 2026-09-27: it used to name the 2026-08-06 build (`sha256:fbc553921145…`) and now names `sha256:d81702998ae1…`, a binary whose gitVersion is `0.15.0` without the leading `v`. component-base v0.37 parses that string in an `init()` and panics: ``` panic: version string "0.15.0" doesn't match expected regular expression: "^v(\d+\.\d+\.\d+)" ``` The CCM Deployment crash-loops, no new Node loses `node.cloudprovider.kubernetes.io/uninitialized`, and workloads on new workers stay Pending. On a live Proxmox cluster this went unnoticed for five days: the existing Nodes were already initialized, and the failure only showed when the next new worker came up. Every fresh install pulls the broken build, so as it stands v1.7.0 would be the first stable release with the Proxmox substrate, shipping a CCM that cannot start. Two commits, both cherry-pick onto `release-1.7` unchanged: 1. **`fix(kubernetes)`**: run v0.16.1, pinned as tag plus digest in `images/proxmox-cloud-controller-manager.tag`. That is the same shape the chart already uses for the KubeVirt cloud provider. v0.16 builds with goreleaser and stamps the version with its `v`. The config the init container writes still parses: the cluster entry moved to go-proxmox-pool's `ClusterConfig` with the same `url`, `insecure`, `token_id`, `token_secret` and `region` keys, and `features.provider: capmox` still writes `proxmox://<SMBIOS UUID>`, the providerID capmox puts on the Machine. 2. **`fix(kubernetes, proxmox-csi)`**: pin the CSI driver from the same registry at its current v0.20.0, with no version change. The management-side controller goes through `images/proxmox-csi-controller.tag`. The tenant-side node plugin goes through `repository` + `tag` in `packages/system/proxmox-csi/values.yaml`, which also puts it in `hack/lib/image-refs.sh` and so in front of the release multi-arch gate. Pinning takes the version out of the vendored chart's hands, so `hack/proxmox-csi-driver-pin_test.bats` now fails unless the chart's `appVersion` and both pins name the same release. All three digests are OCI indexes for `linux/amd64` and `linux/arm64`. The sig-storage sidecars stay on tags, as they do for the KubeVirt CSI driver: registry.k8s.io publishes through image promotion, which does not move a tag. ### Testing - `helm unittest`: `packages/apps/kubernetes` 31 suites / 346 tests, `packages/apps/kubernetes-nodes` 37 / 223, all passing. - bats: the new test, plus `image-pin-consistency`, `promote-rewrite-tags_test`, `overlay-main-images_test`, `nightly-mirror_test`, `promote-retag_test`, `stitch-multiarch_test`, `bats-strict-setup`, `bats-runner-coverage`: 107/107. The new test was checked to fail on a node tag at another version. - `git cherry-pick -x` of both commits onto `release-1.7` (315b335) applies cleanly, and the Proxmox unit suites and the new bats test pass there. - v0.16.1 compatibility was checked against its source, as described above. It has also run on a live Proxmox cluster, including the initialisation of a new worker; the results are in the comment below. ### Screenshots Not a UI change. ### Downstream repositories The diff touches no app `values.schema.json` or defaults, adds or renames no package, and moves nothing under `hack/`. - [x] No downstream repository is affected by this change - [ ] [cozystack/website](https://github.com/cozystack/website) - follow-up: - [ ] [cozystack/terraform-provider-cozystack](https://github.com/cozystack/terraform-provider-cozystack) - follow-up: - [ ] [cozystack/ansible-cozystack](https://github.com/cozystack/ansible-cozystack) - follow-up: - [ ] [cozystack/ccp](https://github.com/cozystack/ccp) - follow-up: - [ ] [cozystack/talm](https://github.com/cozystack/talm) - follow-up: - [ ] [cozystack/cozyhr](https://github.com/cozystack/cozyhr) - follow-up: - [ ] [cozystack/cozy-proxy](https://github.com/cozystack/cozy-proxy) - follow-up: - [ ] [cozystack/cozystack-telemetry-server](https://github.com/cozystack/cozystack-telemetry-server) - follow-up: - [ ] [cozystack/external-apps-example](https://github.com/cozystack/external-apps-example) - follow-up: - [ ] [cozystack/examples](https://github.com/cozystack/examples) - follow-up: - [ ] [cozystack/community](https://github.com/cozystack/community) - follow-up: ### Release note ```release-note fix(kubernetes): the Proxmox cloud-controller-manager now runs v0.16.1, and the Proxmox CCM and CSI driver images are pinned by digest. The v0.15.0 tag referenced before was re-pushed upstream to a build that panics on start, which left every new Proxmox worker with the uninitialized taint. ```
2 parents 040ae37 + 780b068 commit 44848b9

6 files changed

Lines changed: 59 additions & 2 deletions

File tree

Lines changed: 44 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,44 @@
1+
#!/usr/bin/env bats
2+
# Upstream releases the Proxmox CSI controller and node plugin together, and
3+
# its chart renders both from one appVersion. Here they run in two places and
4+
# are pinned in two packages: the controller in the management cluster
5+
# (packages/apps/kubernetes, an images/.tag file) and the node plugin in the
6+
# tenant (packages/system/proxmox-csi, a values override on the vendored
7+
# chart). Both are pinned by digest because tags in that registry have been
8+
# re-pushed, and the pin is what takes the version out of the chart's hands:
9+
# `make update` with a new CHART_VERSION brings new templates and a new
10+
# appVersion while both pins keep naming the old build, and nothing else
11+
# notices.
12+
#
13+
# This asserts the chart's appVersion and both pins name the same release.
14+
15+
load test_helper
16+
17+
REPO_ROOT="$(cd "$(dirname "${BATS_TEST_FILENAME:-$0}")/.." && pwd)"
18+
19+
@test "the Proxmox CSI controller and node plugin pin the vendored chart's release" {
20+
chart="$REPO_ROOT/packages/system/proxmox-csi/charts/proxmox-csi-plugin/Chart.yaml"
21+
values="$REPO_ROOT/packages/system/proxmox-csi/values.yaml"
22+
tagfile="$REPO_ROOT/packages/apps/kubernetes/images/proxmox-csi-controller.tag"
23+
24+
app_version=$(yq -r '.appVersion' "$chart")
25+
node_tag=$(yq -r '."proxmox-csi-plugin".node.plugin.image.tag' "$values")
26+
controller_ref=$(tr -d '[:space:]' < "$tagfile")
27+
28+
[ -n "$app_version" ] && [ "$app_version" != null ] || {
29+
echo "no appVersion in $chart" >&2
30+
return 1
31+
}
32+
33+
[ "${node_tag%%@*}" = "$app_version" ] || {
34+
echo "node plugin tag '$node_tag' is not the chart appVersion $app_version" >&2
35+
echo "set proxmox-csi-plugin.node.plugin.image.tag in packages/system/proxmox-csi/values.yaml" >&2
36+
return 1
37+
}
38+
39+
[ "${controller_ref%%@*}" = "ghcr.io/sergelogvinov/proxmox-csi-controller:$app_version" ] || {
40+
echo "controller ref '$controller_ref' is not proxmox-csi-controller:$app_version" >&2
41+
echo "update packages/apps/kubernetes/images/proxmox-csi-controller.tag" >&2
42+
return 1
43+
}
44+
}
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
ghcr.io/sergelogvinov/proxmox-cloud-controller-manager:v0.16.1@sha256:474dbfd3be5c2e0866e520bc6ddb60b7accef554ca7401488eee35252cdf8734
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
ghcr.io/sergelogvinov/proxmox-csi-controller:v0.20.0@sha256:95ef74cce03e89a1706d9b32888a84bf44e0db439c4fe2a4334ce123728d4c3b

‎packages/apps/kubernetes/templates/ccm-proxmox/controller.yaml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ spec:
101101
readOnlyRootFilesystem: true
102102
containers:
103103
- name: cloud-controller-manager
104-
image: ghcr.io/sergelogvinov/proxmox-cloud-controller-manager:v0.15.0
104+
image: "{{ $.Files.Get "images/proxmox-cloud-controller-manager.tag" | trim }}"
105105
args:
106106
- --v=4
107107
- --cloud-provider=proxmox

‎packages/apps/kubernetes/templates/csi-proxmox/controller.yaml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ spec:
112112
readOnlyRootFilesystem: true
113113
containers:
114114
- name: csi-driver
115-
image: ghcr.io/sergelogvinov/proxmox-csi-controller:v0.20.0
115+
image: "{{ $.Files.Get "images/proxmox-csi-controller.tag" | trim }}"
116116
args:
117117
- "-v=4"
118118
- "--csi-address=unix:///csi/csi.sock"

‎packages/system/proxmox-csi/values.yaml‎

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,3 +33,14 @@ proxmox-csi-plugin:
3333
node:
3434
tolerations:
3535
- operator: Exists
36+
plugin:
37+
# The chart's default is its appVersion as a bare tag, and tags in this
38+
# registry have been re-pushed. The digest is the pin; the version must
39+
# stay the chart's appVersion and the one in the kubernetes chart's
40+
# images/proxmox-csi-controller.tag, since node and controller are two
41+
# halves of one driver release (hack/proxmox-csi-driver-pin_test.bats).
42+
# The repository repeats the chart default so that hack/lib/image-refs.sh,
43+
# which does not read under charts/, sees a complete reference here.
44+
image:
45+
repository: ghcr.io/sergelogvinov/proxmox-csi-node
46+
tag: v0.20.0@sha256:e0151137a1c5fa4faea9b4622436b203f1dc246ea37a3a77d09d3855c70aabd1

0 commit comments

Comments
 (0)