Skip to content

Commit 4346a30

Browse files
authored
ci(e2e): run nightly and release-tag e2e on the container lane (#4828)
<!-- Thank you for making a contribution! Here are some tips for you: - Use Conventional Commits for the PR title: `type(scope): description` - Types: feat, fix, docs, style, refactor, perf, test, build, ci, chore - Scopes are not an exhaustive list — pick the most specific scope for the change and extend the list when a genuinely new area appears. Examples: - System components: dashboard, platform, operator, cilium, kube-ovn, linstor, fluxcd, cluster-api - Managed apps: postgres, mariadb, redis, kafka, clickhouse, virtual-machine, kubernetes - Development and maintenance: api, hack, tests, ci, docs, maintenance - Breaking changes: append `!` after type/scope (`feat(api)!: ...`) or add a `BREAKING CHANGE:` footer - If it's a work in progress, consider creating this PR as a draft. - Don't hesistate to ask for opinion and review in the community chats, even if it's still a draft. - Add the label `kind/backport` if it's a bugfix that needs to be backported to a previous version. --> ## What this PR does Nightly and the release-tag e2e (`e2e-tag.yaml`, the rc gate) now run on the Talos-container substrate the PR lanes moved to in #4020. This is the interim step from #4642, not the whole issue, so it does not close it. On QEMU the nightly full suite has been cancelled at its 215-minute timeout on every night since 2026-10-01 except 2026-10-07. From 2026-10-02 on, kubernetes-latest and kubernetes-previous failed their tenant node-join deadline almost every night, each failure took about 35 minutes, and the suites after them alphabetically never ran. In the 18 PR runs since 2026-10-03 that I checked and that ran them, they passed every time, at 7 to 10 minutes each. A nightly dispatched from this branch (run 37934155231) passed all 62 tests in 193 minutes. The kubernetes suites took 9 to 11 minutes there. Changes: - `nightly.yaml` and `e2e-tag.yaml` get the same host module step, `prepare-env-container`, endpoint and storage-class env and two-part teardown as `pull-requests.yaml`. Nightly's e2e no longer waits for the nocloud disk, which it does not boot. The disk is still built and published. - `e2e-tag.yaml` still requires the release to carry its disk but no longer downloads it. A dispatch against a tag cut before the container lane (v1.6.3 and older, v1.7.0-alpha.1) fails early and says to dispatch with `--ref <tag>`. When `tags.yaml` calls it, it runs the copy from the tag's own commit, so the guard does not fire there. - The comment above `timeout-minutes: 215` in all four e2e workflows claimed the budget covers two failing tenant Kubernetes suites. It does not, and the comment now says so. The value is unchanged. - `platform-packages_test.bats` now checks the container-lane env on all four workflows, and `collect-images_test.bats` covers the new guard. What loses coverage: DRBD and the `replicated` StorageClass (Immediate binding, tenant StorageClass propagation, RWX), the Cozystack Talos node image with its extensions, and the stock 600M CDI importer limit. None of them can run on containers, so no CI lane tests them until #4642 gets a lane with a kernel per node. The docs and comments that pointed at nightly and rc as that coverage now say this. Release lines keep their own `e2e-tag.yaml`, so rc tags on release-1.6 stay on QEMU until this is backported. That is why `kind/backport` is on this PR. Leftover QEMU-only text and diagnostics are collected in #4825. A dispatch of `e2e-tag.yaml` from this branch against `v1.7.0-alpha.3` is running as run 37958852914. I'll post the result here. ### Screenshots <!-- REQUIRED for UI changes: attach screenshots or screen recordings demonstrating the visual impact of your changes. PRs with UI changes without screenshots will not be merged. --> ### Downstream repositories <!-- Cozystack is upstream for repositories that are NOT kept in sync with it automatically, and nothing in CI compares the two sides, so a change here can break them silently. Which change forces what, and which file to touch, is the trigger map in docs/agents/contributing.md under "Downstream Repositories". Walk it before you tick anything. IF YOU ARE AN AI AGENT OR AN LLM, THIS IS PART OF THE TASK, NOT A FORM TO FILL IN: 1. Walk the trigger map against the actual diff of this PR, file by file. Do not decide from the PR title or from your memory of what you changed. 2. For every repository you tick, open the follow-up PR there and link it on the same line. A ticked box with no link claims work that does not exist, which is worse than an empty box. Search that repository for an open PR or issue covering it first, and link that instead of filing a duplicate. 3. When the follow-up is out of scope, or needs a decision that is not yours to make, open an issue in that repository instead, link that, and say so in the PR body. Do not push a speculative PR into another repository just to fill a line here. 4. Do not tick "No downstream repository is affected" to make the checklist go away. If you are unsure, leave every box empty and say so in the PR body, so a human decides. --> - [x] No downstream repository is affected by this change - [ ] [cozystack/website](https://github.com/cozystack/website) - follow-up: - [ ] [cozystack/terraform-provider-cozystack](https://github.com/cozystack/terraform-provider-cozystack) - follow-up: - [ ] [cozystack/ansible-cozystack](https://github.com/cozystack/ansible-cozystack) - follow-up: - [ ] [cozystack/ccp](https://github.com/cozystack/ccp) - follow-up: - [ ] [cozystack/talm](https://github.com/cozystack/talm) - follow-up: - [ ] [cozystack/cozyhr](https://github.com/cozystack/cozyhr) - follow-up: - [ ] [cozystack/cozy-proxy](https://github.com/cozystack/cozy-proxy) - follow-up: - [ ] [cozystack/cozystack-telemetry-server](https://github.com/cozystack/cozystack-telemetry-server) - follow-up: - [ ] [cozystack/external-apps-example](https://github.com/cozystack/external-apps-example) - follow-up: - [ ] [cozystack/examples](https://github.com/cozystack/examples) - follow-up: - [ ] [cozystack/community](https://github.com/cozystack/community) - follow-up: ### Release note <!-- Write a release note: - Explain what has changed internally and for users. - Start with the same `type(scope):` prefix as in the PR title - Follow the guidelines at https://github.com/kubernetes/community/blob/master/contributors/guide/release-notes.md. --> ```release-note ci(e2e): nightly and release-tag e2e run on Talos containers instead of QEMU guests. DRBD, the replicated StorageClass and the Cozystack Talos node image are no longer covered by any e2e lane. ``` <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **CI and Testing** * Release-tag and nightly end-to-end tests now run against container-based environments rather than booting disk images. * Release-tag checks still verify that the published release includes its disk image. * CI no longer covers QEMU-based DRBD scenarios or certain storage and Talos extension behaviors; these coverage gaps are documented. * **Documentation** * Updated E2E and release guidance to reflect the container-based test coverage and its limitations. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
2 parents f61e13f + c1fe1e9 commit 4346a30

11 files changed

Lines changed: 178 additions & 92 deletions

File tree

‎.github/workflows/e2e-fork.yaml‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -540,8 +540,9 @@ jobs:
540540
# per-node 8 CPU / 24 GiB in hack/e2e-compose.yaml is why the class is this
541541
# one. See the `e2e` job there for the full sizing note.
542542
runs-on: oracle-vm-32cpu-128gb-x86-64
543-
# Sized above what the tenant-Kubernetes pair can spend on a failing run, and
544-
# held to one figure across every lane that runs the suite.
543+
# Covers a green full suite. It does not cover a tenant-Kubernetes suite
544+
# running into its node-join deadline, so a red there can end as a
545+
# cancelled job. Held to one figure across every lane that runs the suite.
545546
timeout-minutes: 215
546547
permissions:
547548
contents: read

‎.github/workflows/e2e-tag.yaml‎

Lines changed: 64 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,10 @@ name: E2E Release Tag
1111
# This lane validates published tags only; draft and promote-time validation are
1212
# explicitly out of scope because release checks run at RC publication time.
1313
# Prerelease tags use the matching digest-pinned staging branch, while stable
14-
# tags use their pinned merge tree directly. In both cases the nocloud disk
15-
# comes from the published release identified by the same tag.
14+
# tags use their pinned merge tree directly. The nodes run as Talos containers
15+
# booted from the upstream image, so the release's nocloud disk is required to
16+
# exist but is not what the suite runs on. It is still required because users
17+
# install from it, and promote-rc.yaml checks it for an rc only.
1618

1719
on:
1820
workflow_call:
@@ -37,8 +39,8 @@ concurrency:
3739
group: e2e-tag-${{ inputs.tag }}
3840
cancel-in-progress: false
3941

40-
# Listing published releases, reading Git refs, downloading a release asset, and
41-
# checking out the pinned tree require only repository contents read access.
42+
# Listing published releases, reading Git refs and checking out the pinned tree
43+
# require only repository contents read access.
4244
# Draft releases are not part of this lane's contract. The public GHCR images
4345
# referenced by that tree need no package token.
4446
#
@@ -57,7 +59,6 @@ jobs:
5759
runs-on: ubuntu-latest
5860
timeout-minutes: 10
5961
outputs:
60-
disk_id: ${{ steps.resolve.outputs.disk_id }}
6162
tree_ref: ${{ steps.resolve.outputs.tree_ref }}
6263
steps:
6364
- name: Validate tag and resolve release
@@ -123,19 +124,19 @@ jobs:
123124
throw error;
124125
}
125126
126-
core.setOutput('disk_id', String(disk.id));
127127
core.setOutput('tree_ref', treeRef);
128128
core.info(`Resolved ${tag}: tree '${treeRef}', disk asset ${disk.id}`);
129129
130130
e2e:
131131
name: E2E ${{ inputs.tag }} (full suite)
132132
needs: resolve
133-
# The sandbox boots three 8-vCPU / 24-GiB QEMU guests. This runner leaves
134-
# enough host headroom for QEMU, networking, containerd, and the runner
135-
# agent while the full platform installs across all three guests.
133+
# The sandbox runs three 8-vCPU / 24-GiB Talos containers. This runner
134+
# leaves enough host headroom for networking, containerd, and the runner
135+
# agent while the full platform installs across all three nodes.
136136
runs-on: oracle-vm-32cpu-128gb-x86-64
137-
# Sized above what the tenant-Kubernetes pair can spend on a failing run, and
138-
# held to one figure across every lane that runs the suite.
137+
# Covers a green full suite. It does not cover a tenant-Kubernetes suite
138+
# running into its node-join deadline, so a red there can end as a
139+
# cancelled job. Held to one figure across every lane that runs the suite.
139140
timeout-minutes: 215
140141
permissions:
141142
contents: read
@@ -150,45 +151,74 @@ jobs:
150151
fetch-depth: 1
151152
persist-credentials: false
152153

153-
- name: Download disk asset from release
154-
env:
155-
DISK_ID: ${{ needs.resolve.outputs.disk_id }}
156-
GH_TOKEN: ${{ github.token }}
157-
run: |
158-
mkdir -p _out/assets
159-
curl --fail-with-body --silent --show-error --location \
160-
-H "Authorization: Bearer ${GH_TOKEN}" \
161-
-H "Accept: application/octet-stream" \
162-
-o _out/assets/nocloud-amd64.raw.xz \
163-
"https://api.github.com/repos/${GITHUB_REPOSITORY}/releases/assets/${DISK_ID}"
164-
165154
- name: Set sandbox ID
166155
env:
167156
TAG: ${{ inputs.tag }}
168157
run: echo "SANDBOX_NAME=cozy-e2e-sandbox-$(echo "${GITHUB_REPOSITORY}:${GITHUB_WORKFLOW}:${TAG}" | sha256sum | cut -c1-10)" >> "$GITHUB_ENV"
169158

159+
# tags.yaml calls the e2e-tag.yaml from the tag's own commit, so this can
160+
# only fire on a dispatch from a newer ref against an older tag.
161+
- name: Require a container-lane tree
162+
env:
163+
TAG: ${{ inputs.tag }}
164+
run: |
165+
if [ ! -f hack/e2e-compose.yaml ]; then
166+
echo "::error title=e2e-tag::${TAG} predates the container lane; dispatch e2e-tag.yaml with --ref ${TAG} to run it on the lane it shipped with"
167+
exit 1
168+
fi
169+
170170
- name: Prepare workspace
171171
run: |
172172
rm -rf "/tmp/$SANDBOX_NAME"
173173
cp -r "${{ github.workspace }}" "/tmp/$SANDBOX_NAME"
174174
175-
# This is the only retried stage: Talos image unpacking, QEMU startup, and
176-
# sandbox networking are pure runner infrastructure, not product logic.
175+
# Talos cannot load kernel modules in container mode, so the nodes get
176+
# exactly what this host has loaded. Why each module, and why failing
177+
# here is better than an hour later: the same step in pull-requests.yaml.
178+
- name: Prepare container-lane host
179+
run: |
180+
set -eu
181+
for m in openvswitch zfs; do
182+
grep -q "^${m} " /proc/modules && continue
183+
if [ "${m}" = zfs ]; then
184+
sudo apt-get update -qq
185+
sudo DEBIAN_FRONTEND=noninteractive apt-get install -y -qq zfsutils-linux
186+
fi
187+
sudo modprobe "${m}" || echo "${m}: modprobe failed"
188+
done
189+
missing=''
190+
for m in openvswitch zfs; do
191+
grep -q "^${m} " /proc/modules || missing="${missing} ${m}"
192+
done
193+
if [ -n "${missing}" ]; then
194+
echo "::error title=container-lane host::kernel module(s) could not be loaded:${missing}"
195+
exit 1
196+
fi
197+
198+
# This is the only retried stage: Talos container startup and sandbox
199+
# networking are pure runner infrastructure, not product logic.
177200
- name: Prepare environment
178201
run: |
179202
cd "/tmp/$SANDBOX_NAME"
180203
attempt=0
181-
until make SANDBOX_NAME=$SANDBOX_NAME prepare-env; do
204+
until make SANDBOX_NAME="$SANDBOX_NAME" prepare-env-container; do
182205
attempt=$((attempt + 1))
183206
if [ $attempt -ge 3 ]; then
184207
echo "Attempt $attempt failed, exiting..."
185208
exit 1
186209
fi
187210
echo "Attempt $attempt failed, retrying..."
211+
make -C packages/core/testing SANDBOX_NAME="$SANDBOX_NAME" delete-cluster-container || true
188212
done
189213
echo "Prepare environment completed after $((attempt + 1)) attempts"
190214
191215
- name: Install Cozystack into sandbox
216+
env:
217+
# No ARP VIP in container mode: .11 is a plain control-plane node.
218+
COZY_APISERVER_ENDPOINT: https://192.168.123.11:6443
219+
# The nodes share the runner kernel and cannot load DRBD.
220+
COZY_LINSTOR_DRBD_ENABLED: "false"
221+
COZY_E2E_STORAGE_CLASS: local
192222
run: |
193223
cd "/tmp/$SANDBOX_NAME"
194224
if ! make -C packages/core/testing SANDBOX_NAME=$SANDBOX_NAME install-cozystack; then
@@ -218,6 +248,8 @@ jobs:
218248
# CHAINSAW_SUITES is the testing Makefile's full-suite mode.
219249
- name: Run E2E tests (full suite)
220250
id: e2e_tests
251+
env:
252+
COZY_E2E_STORAGE_CLASS: local
221253
run: |
222254
cd "/tmp/$SANDBOX_NAME"
223255
if ! make -C packages/core/testing SANDBOX_NAME=$SANDBOX_NAME test-chainsaw CHAINSAW_SUITES=""; then
@@ -404,13 +436,17 @@ jobs:
404436
Resume from inside: `breakpoint resume`. Otherwise the breakpoint
405437
exits 10 minutes after the last SSH session disconnects.
406438
439+
# The compose project owns the nodes and the zpools outlive it, so both
440+
# halves go, in this order.
407441
- name: Tear down sandbox
408442
if: always()
409-
run: make -C packages/core/testing SANDBOX_NAME=$SANDBOX_NAME delete || true
443+
run: |
444+
make -C packages/core/testing SANDBOX_NAME="$SANDBOX_NAME" delete-cluster-container || true
445+
make -C packages/core/testing SANDBOX_NAME="$SANDBOX_NAME" delete || true
410446
411447
- name: Remove workspace
412448
if: always()
413-
run: rm -rf "/tmp/$SANDBOX_NAME"
449+
run: rm -rf "/tmp/${SANDBOX_NAME:?}"
414450

415451
- name: Summarize outcome
416452
if: always()

‎.github/workflows/nightly.yaml‎

Lines changed: 51 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,8 @@ name: Nightly
1010
# cozy-installer chart are re-published on GHCR so the whole install closure is
1111
# self-contained there. The only thing genuinely built is the Talos nocloud disk
1212
# (assembled from upstream profiles, independent of the registry), published as a
13-
# GHCR OCI artifact so a nightly is installable on real hardware, not just e2e.
13+
# GHCR OCI artifact so a nightly is installable on real hardware. The nightly
14+
# e2e does not boot it.
1415
#
1516
# No GitHub release and no api/apps/v1alpha1 Go-module tag are created — a
1617
# nightly is an installable artifact set on GHCR, nothing more. retention.yaml
@@ -233,18 +234,22 @@ jobs:
233234
oras tag "${DST_REGISTRY}/cozystack-nocloud:${VERSION}" nightly
234235
echo "Published cozystack-nocloud:${VERSION} (+ :nightly) to GHCR."
235236
236-
# ── Full e2e against the published GHCR closure (chart + images + disk).
237+
# ── Full e2e against the published GHCR closure (chart + images), on the
238+
# same Talos-container substrate as the PR lanes. The nodes boot the
239+
# upstream Talos image, so the nocloud disk built above is published but
240+
# not exercised here, and e2e does not wait for it.
237241
e2e:
238242
name: E2E (full suite)
239-
needs: [mirror, build-disk]
240-
# Same sandbox as the other e2e lanes: three QEMU guests at `-smp 8` commit
241-
# 24 vCPU for the whole run, so the runner class has to be strictly larger,
242-
# leaving the host its own cycles for QEMU's emulation and IO threads,
243+
needs: [mirror]
244+
# Same sandbox as the other e2e lanes: three nodes at 8 vCPU / 24 GiB each
245+
# (hack/e2e-compose.yaml) commit 24 vCPU for the whole run, so the runner
246+
# class has to be strictly larger, leaving the host its own cycles for
243247
# containerd and the runner agent. Enforced by
244248
# hack/sandbox-runner-headroom.bats.
245249
runs-on: oracle-vm-32cpu-128gb-x86-64
246-
# Sized above what the tenant-Kubernetes pair can spend on a failing run, and
247-
# held to one figure across every lane that runs the suite.
250+
# Covers a green full suite. It does not cover a tenant-Kubernetes suite
251+
# running into its node-join deadline, so a red there can end as a
252+
# cancelled job. Held to one figure across every lane that runs the suite.
248253
timeout-minutes: 215
249254
permissions:
250255
contents: read
@@ -260,16 +265,12 @@ jobs:
260265
uses: fluxcd/flux2/action@04acaec6161ac4fb1a82ffafa88901c03271d34f # v2.8.6
261266
with:
262267
version: "2.8.6"
263-
- name: Set up toolchain (oras)
264-
run: |
265-
command -v oras >/dev/null || { curl -fsSL https://github.com/oras-project/oras/releases/download/v1.2.0/oras_1.2.0_linux_amd64.tar.gz | sudo tar -xz -C /usr/local/bin oras; }
266268
- name: Login to GHCR
267269
env:
268270
GHCR_USER: ${{ github.actor }}
269271
GHCR_TOKEN: ${{ secrets.GITHUB_TOKEN }}
270272
run: |
271273
echo "$GHCR_TOKEN" | docker login "${DST_REGISTRY%%/*}" -u "$GHCR_USER" --password-stdin
272-
echo "$GHCR_TOKEN" | oras login "${DST_REGISTRY%%/*}" -u "$GHCR_USER" --password-stdin
273274
274275
# Overlay the GHCR-rewritten tree (operator image, .e2e.image and every
275276
# component now point at GHCR), then pin the installer chart to the GHCR
@@ -288,27 +289,49 @@ jobs:
288289
yq -i ".cozystackOperator.platformSourceUrl = \"oci://${DST_REGISTRY}/cozystack-packages\"" packages/core/installer/values.yaml
289290
yq -i ".cozystackOperator.platformSourceRef = \"digest=${PACKAGES_DIGEST}\"" packages/core/installer/values.yaml
290291
291-
- name: Fetch nocloud disk from GHCR
292-
env:
293-
VERSION: ${{ needs.mirror.outputs.version }}
294-
run: |
295-
set -eu
296-
mkdir -p _out/assets
297-
oras pull "${DST_REGISTRY}/cozystack-nocloud:${VERSION}" --output _out/assets
298-
299292
- name: Set sandbox ID
300293
run: echo "SANDBOX_NAME=cozy-e2e-sandbox-$(echo "${GITHUB_REPOSITORY}:${GITHUB_WORKFLOW}:${GITHUB_REF}" | sha256sum | cut -c1-10)" >> "$GITHUB_ENV"
301294

295+
# Talos cannot load kernel modules in container mode, so the nodes get
296+
# exactly what this host has loaded. Why each module, and why failing
297+
# here is better than an hour later: the same step in pull-requests.yaml.
298+
- name: Prepare container-lane host
299+
run: |
300+
set -eu
301+
for m in openvswitch zfs; do
302+
grep -q "^${m} " /proc/modules && continue
303+
if [ "${m}" = zfs ]; then
304+
sudo apt-get update -qq
305+
sudo DEBIAN_FRONTEND=noninteractive apt-get install -y -qq zfsutils-linux
306+
fi
307+
sudo modprobe "${m}" || echo "${m}: modprobe failed"
308+
done
309+
missing=''
310+
for m in openvswitch zfs; do
311+
grep -q "^${m} " /proc/modules || missing="${missing} ${m}"
312+
done
313+
if [ -n "${missing}" ]; then
314+
echo "::error title=container-lane host::kernel module(s) could not be loaded:${missing}"
315+
exit 1
316+
fi
317+
302318
- name: Prepare environment
303319
run: |
304320
attempt=0
305-
until make SANDBOX_NAME=$SANDBOX_NAME prepare-env; do
321+
until make SANDBOX_NAME="$SANDBOX_NAME" prepare-env-container; do
306322
attempt=$((attempt + 1))
307323
if [ $attempt -ge 3 ]; then echo "Attempt $attempt failed, exiting..."; exit 1; fi
308324
echo "Attempt $attempt failed, retrying..."
325+
make -C packages/core/testing SANDBOX_NAME="$SANDBOX_NAME" delete-cluster-container || true
309326
done
310327
311328
- name: Install Cozystack into sandbox
329+
env:
330+
# No ARP VIP in container mode: .11 is a plain control-plane node.
331+
COZY_APISERVER_ENDPOINT: https://192.168.123.11:6443
332+
# The nodes share the runner kernel and cannot load DRBD.
333+
COZY_LINSTOR_DRBD_ENABLED: "false"
334+
COZY_E2E_STORAGE_CLASS: local
312335
run: |
313336
if ! make -C packages/core/testing SANDBOX_NAME=$SANDBOX_NAME install-cozystack; then
314337
echo "❌ Install failed (no retry — diagnostics below)"
@@ -332,6 +355,8 @@ jobs:
332355
# Always the FULL app suite — a nightly has no diff to scope against, so
333356
# Test Impact Analysis does not apply (empty CHAINSAW_SUITES = whole suite).
334357
- name: Run E2E tests (full suite)
358+
env:
359+
COZY_E2E_STORAGE_CLASS: local
335360
run: |
336361
if ! make -C packages/core/testing SANDBOX_NAME=$SANDBOX_NAME test-chainsaw CHAINSAW_SUITES=""; then
337362
echo "❌ Chainsaw E2E failed (see the assertion diffs or LEAKED-PODS lines above and diagnostics below)"
@@ -399,6 +424,10 @@ jobs:
399424
path: _out/cozyreport.tgz
400425
if-no-files-found: warn
401426

427+
# The compose project owns the nodes and the zpools outlive it, so both
428+
# halves go, in this order.
402429
- name: Tear down sandbox
403430
if: always()
404-
run: make -C packages/core/testing SANDBOX_NAME=$SANDBOX_NAME delete || true
431+
run: |
432+
make -C packages/core/testing SANDBOX_NAME="$SANDBOX_NAME" delete-cluster-container || true
433+
make -C packages/core/testing SANDBOX_NAME="$SANDBOX_NAME" delete || true

‎.github/workflows/pull-requests.yaml‎

Lines changed: 9 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -883,7 +883,7 @@ jobs:
883883
# nocloud disk asset and export its id; the container lane boots no disk,
884884
# so nothing in this workflow reads that id any more and resolving it only
885885
# added a way to fail a release PR over an asset it does not use. The
886-
# asset is still resolved where it is still consumed, in e2e-tag.yaml.
886+
# asset's presence is still checked in e2e-tag.yaml and promote-rc.yaml.
887887
- name: Verify draft release exists (release PR)
888888
if: contains(github.event.pull_request.labels.*.name, 'release')
889889
uses: actions/github-script@f28e40c7f34bde8b3046d885e986cb6290c5673b # v7
@@ -903,15 +903,11 @@ jobs:
903903
}
904904
905905
906-
# In-tree e2e for SAME-REPO PRs, on Talos nodes running as CONTAINERS. The
907-
# QEMU substrate this lane used to boot is off the per-PR path only: it is
908-
# still wired into nightly.yaml and e2e-tag.yaml, both of which run `make
909-
# prepare-env` -> `make -C packages/core/testing prepare-cluster`. That target
910-
# and hack/e2e-prepare-cluster.bats are therefore live code, not leftovers,
911-
# and deleting them takes nightly and every release-candidate run with them.
912-
# They carry the coverage containers cannot: DRBD, and with it the
913-
# `replicated` StorageClass, its Immediate binding mode and the tenant
914-
# StorageClass propagation that only applies to remotely-accessible classes.
906+
# In-tree e2e for SAME-REPO PRs, on Talos nodes running as CONTAINERS, like
907+
# every other e2e lane. What containers cannot carry has no lane at all:
908+
# DRBD, and with it the `replicated` StorageClass, its Immediate binding mode
909+
# and the tenant StorageClass propagation that only applies to
910+
# remotely-accessible classes.
915911
#
916912
# Deliberately NOT named "E2E Tests": the
917913
# required "E2E Tests" context is a commit status posted by the `e2e-report`
@@ -943,8 +939,9 @@ jobs:
943939
# scheduler and not what a pod reads from /proc, so a workload that sizes
944940
# itself from /proc/cpuinfo or /proc/meminfo is configured for the whole host.
945941
runs-on: oracle-vm-32cpu-128gb-x86-64
946-
# Sized above what the tenant-Kubernetes pair can spend on a failing run, and
947-
# held to one figure across every lane that runs the suite.
942+
# Covers a green full suite. It does not cover a tenant-Kubernetes suite
943+
# running into its node-join deadline, so a red there can end as a
944+
# cancelled job. Held to one figure across every lane that runs the suite.
948945
timeout-minutes: 215
949946
permissions:
950947
contents: read

0 commit comments

Comments
 (0)