You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 38b13f9
Browse filesBrowse the repository at this point in the historyBrowse files
fix(kubernetes): assemble the node group once in kubernetes-nodes
The TalosConfigTemplate name is a hash of the machine-config spec, and two
templates have to agree on it: talos-reconcile-job.yaml creates the object,
nodegroup.yaml points MachineDeployment.bootstrap.configRef at it. Sharing the
rendering was not enough — each file also assembled its own $group dict, one
with ten keys and one with four, so the two names agreed only by coincidence of
the keys the spec helper happens to read. Dropping "gpus" from the Job's dict
diverged them (ffdbe1 vs 0bbd2a on a GPU pool) with the whole suite still
green, which is the "templates do not exist" deadlock this fix exists to make
impossible.
Move the assembly into a single kubernetes-nodes.group helper, read back with
fromYaml at both call sites the way the parent chart already reads
kubernetes.nodeGroups, so there is one input as well as one rendering.
Cover it too, since the seam can be reintroduced: the only literal pair in this
chart rendered with instanceType "", gpus [] and kubelet {}, all falsy, so a
dict missing those keys was indistinguishable from one carrying them. Add a
GPU-shaped pair across the two suites, and the notMatchRegex guard against the
old fixed name that the parent suite already has.
Also correct a comment in the parent chart's Job that still described the
computed locals as .group, removed when the machine config moved into
_talosconfigtemplate.tpl.
No rendered output changes: 209 + 17 helm unittests pass, render-parity.sh
reports GOLDEN PARITY, and the golden hashes are unchanged.
Assisted-By: Claude <[email protected]>
Signed-off-by: Mattia Eleuteri <[email protected]>
0 commit comments