Skip to content

Commit 3710541

Browse files
committed
fix(kubernetes): validate MachineHealthCheck condition timeouts at render time
The CAPI webhook validates nodeStartupTimeout with a 30s floor but does not validate unhealthyConditions timeouts at all, so a zero or negative readyUnknownTimeout or readyFalseTimeout applied and remediated a Machine the moment its Ready condition flipped. Route both fields through the same render-time duration guard as maxNodeProvisionTime, extracted into a kubernetes.positiveDuration helper in each chart. The guard now also accepts the canonical form a duration serializes back to ("20m0s", "1h0m0s"): metav1.Duration prints that shape, so a value copied from kubectl output previously failed the render. The first segment must still be positive and later segments may be zero, which keeps every accepted string a positive duration. Assisted-By: Claude <[email protected]> Signed-off-by: Aleksei Sviridkin <[email protected]>
1 parent b32ca5c commit 3710541

18 files changed

Lines changed: 197 additions & 84 deletions

File tree

‎api/apps/v1alpha1/kubernetes/types.go‎

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎api/apps/v1alpha1/kubernetesnodes/types.go‎

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)