Repository navigation
Commit 36b07dd
authored
fix(platform): install velero by default (#2833)
## What this PR does
`backupstrategy-controller` has been installed by default since
494144f, and since f17ead3 its PackageSource declares a hard
`dependsOn: cozystack.velero`. But `cozystack.velero` remained an
*optional* package — so on any bundle that doesn't explicitly enable it
(including the e2e sandbox, which enables only
`cozystack.external-dns-application`), the `backupstrategy-controller`
Package stays `DependenciesNotReady` forever and the
`cozystack-platform` HelmRelease never becomes Ready:
```
Helm upgrade failed for release cozy-system/cozystack-platform: timeout waiting for:
[Package/cozystack.backupstrategy-controller status: 'InProgress']
```
Since 67b1a96 made the e2e install test gate on HelmRelease readiness,
this deterministically fails CI on every PR (e.g. runs
[27005526972](https://github.com/cozystack/cozystack/actions/runs/27005526972),
[26974531181](https://github.com/cozystack/cozystack/actions/runs/26974531181)
— the latter failed all 3 retry attempts with the same signature).
This PR promotes `cozystack.velero` from optional to default in the
system bundle, so the dependency is always satisfiable. Velero deploys
standalone (`backupStorageLocation: null`); the cozy-default BSL still
materialises only after the platform Bucket reconciles. The
`bundles.disabledPackages` opt-out keeps working (covered by a new unit
test), and the now-redundant velero entry is dropped from the
isp-full-generic `enabledPackages`.
### Release note
```release-note
fix(platform): Velero is now installed by default as a hard dependency of the backup subsystem. Existing clusters will get Velero deployed in the cozy-velero namespace on upgrade; opt out with bundles.disabledPackages if VM backups are not used.
```
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
* **New Features**
* Velero backup and restore functionality is now installed by default
with every system deployment, providing automatic backup management
capabilities out of the box.
* **Tests**
* Added test coverage for default Velero installation behavior and
package disable scenarios.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->3 files changed
Lines changed: 50 additions & 2 deletions
File tree
- packages/core/platform
- templates/bundles
- tests
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
196 | 196 | | |
197 | 197 | | |
198 | 198 | | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
199 | 204 | | |
200 | 205 | | |
201 | 206 | | |
| |||
214 | 219 | | |
215 | 220 | | |
216 | 221 | | |
217 | | - | |
218 | 222 | | |
219 | 223 | | |
220 | 224 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
14 | | - | |
15 | 14 | | |
0 commit comments