Skip to content

Commit 2f92149

Browse files
myasnikovdaniilmyasnikovdaniil
committed
fix(hack): verify mikefarah yq in promote-retag
Address review feedback from gemini-code-assist on hack/promote-retag.sh:27: command -v yq only confirms some yq is on PATH; the script's queries use mikefarah syntax, so reject python-yq and other variants by checking the version string, mirroring the Makefile build-deps check. Assisted-By: Claude <[email protected]> Signed-off-by: Myasnikov Daniil <[email protected]>
1 parent 76c0369 commit 2f92149

1 file changed

Lines changed: 3 additions & 0 deletions

File tree

‎hack/promote-retag.sh‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,9 @@ DRY_RUN=0
2424
[ "${2:-}" = "--dry-run" ] && DRY_RUN=1
2525

2626
command -v yq >/dev/null || { echo "yq (mikefarah) is required" >&2; exit 1; }
27+
# The queries below use mikefarah syntax; reject python-yq and other variants
28+
# (mirrors the build-deps check in the Makefile).
29+
yq --version 2>&1 | grep -q mikefarah || { echo "yq (mikefarah) is required" >&2; exit 1; }
2730
command -v skopeo >/dev/null || { echo "skopeo is required" >&2; exit 1; }
2831

2932
# Collect "repo@sha256:..." refs from every package values.yaml, across the

0 commit comments

Comments
 (0)