Repository navigation
Commit 28a59da
authored
test(sdn): drop the serviceexposure chainsaw suite left after the feature removal (#3336)
## What this PR does
Removes the dead `serviceexposure` chainsaw suite and its wiring. Commit
3dbc7d3 dropped ExposureClass/ServiceExposure (api/network, the
controller, and the `network.cozystack.io` CRDs shipped in
`cozystack-controller/definitions`) in favor of the native LoadBalancer
path, but the chainsaw port that landed the next day (dd2f89d) brought
the suite along, so it tests an API that no longer exists.
Since then every full-suite E2E run — any PR touching core paths, and
every release cut — fails `serviceexposure-delete` and
`serviceexposure-externalips` with `no matches for
network.cozystack.io/v1alpha1` (see the crust-gather snapshot of e.g.
run 29561399440 on #3333: the network CRDs are absent while sibling CRDs
from the same `definitions/` dir, like
`tenantgateways.gateway.cozystack.io`, are present, confirming the chart
applied and the API is simply gone).
Alongside the suite dir this drops the `suite_to_source` case and its
core-platform bats test in `hack/select-install*`, the now-unreachable
`-` mapping mechanism itself (no suite returns it anymore and its only
executable coverage was the removed bats test; re-adding the three lines
with the next core-platform-owned suite is cheaper than keeping an
untestable dead branch), and the suite list entry in
`hack/e2e-chainsaw/README.md`. The `securitygroup` suite from the same
port is alive and green and is untouched. If the native LoadBalancer
replacement needs E2E coverage, that is a new suite against the new API,
not a revival of this one.
Verified: `hack/select-install.sh --validate` passes (97 sources),
`select-install_test.bats` 17/17, `select-e2e_test.bats` 13/13.
## Release note
```release-note
NONE
```
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
* **Bug Fixes**
* Tightened installation suite-to-PackageSource validation:
`serviceexposure` no longer has special handling, and mappings to `-`
are now treated as invalid unless the referenced PackageSource exists.
* **Tests**
* Removed Chainsaw E2E fixture coverage and manifests for
`serviceexposure`, and updated the listed E2E suites accordingly.
* Updated installation mapping tests to match the stricter validation
and added a negative validation case for a missing mapped PackageSource.
* **Documentation**
* Updated contributing guidance to reference the
`networking.publishing.externalIPs` → `publishing.loadBalancerClass`
migration.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->6 files changed
Lines changed: 31 additions & 178 deletions
File tree
- docs/agents
- hack
- e2e-chainsaw
- serviceexposure
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
195 | 195 | | |
196 | 196 | | |
197 | 197 | | |
198 | | - | |
| 198 | + | |
199 | 199 | | |
200 | 200 | | |
201 | 201 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
21 | | - | |
| 21 | + | |
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
| |||
This file was deleted.
This file was deleted.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
27 | | - | |
| 27 | + | |
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
| |||
59 | 59 | | |
60 | 60 | | |
61 | 61 | | |
62 | | - | |
63 | | - | |
64 | | - | |
65 | | - | |
66 | | - | |
67 | 62 | | |
68 | 63 | | |
69 | 64 | | |
| |||
82 | 77 | | |
83 | 78 | | |
84 | 79 | | |
85 | | - | |
86 | 80 | | |
87 | 81 | | |
88 | 82 | | |
| |||
149 | 143 | | |
150 | 144 | | |
151 | 145 | | |
152 | | - | |
153 | | - | |
| 146 | + | |
| 147 | + | |
154 | 148 | | |
155 | 149 | | |
156 | 150 | | |
| |||
163 | 157 | | |
164 | 158 | | |
165 | 159 | | |
166 | | - | |
| 160 | + | |
167 | 161 | | |
168 | 162 | | |
169 | 163 | | |
| |||
181 | 175 | | |
182 | 176 | | |
183 | 177 | | |
184 | | - | |
185 | 178 | | |
186 | 179 | | |
187 | 180 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
101 | 101 | | |
102 | 102 | | |
103 | 103 | | |
104 | | - | |
105 | | - | |
106 | | - | |
107 | | - | |
108 | | - | |
109 | | - | |
110 | | - | |
111 | | - | |
112 | 104 | | |
113 | 105 | | |
114 | 106 | | |
| |||
180 | 172 | | |
181 | 173 | | |
182 | 174 | | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
183 | 200 | | |
184 | 201 | | |
185 | 202 | | |
| |||
0 commit comments