You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 274ae9f
Browse filesBrowse the repository at this point in the historyBrowse files
Follow-up on review notes for hack/update-versions.sh (all in the
maintainer-run generator; the shipped chart is unchanged and
files/versions.yaml / values.yaml regenerate byte-identically):
- Refuse to change the default silently: if the current default's major
is dropped from CH_SUPPORTED_MAJORS the generator now errors instead
of promoting the newest major to default.
- Freeze follows the default: the default major is pinned to the tag it
already ships (read from the committed versions.yaml) rather than a
hardcoded v24.9, so moving the default cannot leave it unpinned and
patch-bumped on the next regeneration.
- Bound the values.yaml splice: the version section ends at the first
line that is not a recognised member, so a malformed input (enum
header without a version: line) no longer swallows the rest of the
file.
Extends hack/clickhouse-update-versions_test.bats to cover all three.
Signed-off-by: Alexey Artamonov <[email protected]>
*) echo"Error: current default ${CURRENT_DEFAULT} is not in CH_SUPPORTED_MAJORS (${CH_SUPPORTED_MAJORS}); refusing to silently change the default">&2;exit 1 ;;
68
+
esac
69
+
else
70
+
DEFAULT_VERSION="v${CH_SUPPORTED_MAJORS%%*}"
71
+
fi
72
+
73
+
# The default major is frozen to the exact tag it already ships, read from the
74
+
# committed versions.yaml, so a regeneration never changes the default image.
75
+
# The freeze follows whichever major is the default — there is no hardcoded
76
+
# major. An empty result (bootstrap, or the default not yet mapped) means the
77
+
# default takes the latest common patch like any other line.
78
+
FROZEN_DEFAULT_TAG="$(grep -F "\"${DEFAULT_VERSION}\": ""$VERSIONS_FILE"2>/dev/null | sed -E 's/.*: *"([^"]+)".*/\1/'| head -n1 || true)"
79
+
80
+
# Resolve each configured major to one tag: the default freezes to its shipped
81
+
# tag (if still available), every other line takes its latest common patch. A
82
+
# configured major with no common tag is a hard error raised BEFORE any file is
83
+
# written, so a partial Docker Hub result never drops a supported version or
0 commit comments