Repository navigation
Commit 25de4d8
committed
Address review: tracing off by default; defer fail-on-empty guard
@lllamnyp (blocking): tracingStorages had two defaults (extra + system), so
'tracingStorages: null' silently backfilled the inner default and a VTCluster
rendered anyway, while 'tracingStorages: []' aborted the whole monitoring
release — there was no clean 'off', and the default shipped a 6-pod VTCluster
per tenant for a pipeline with no producers yet (the collector is a later PR).
- Default tracingStorages to [] in both packages/system/monitoring/values.yaml
and packages/extra/monitoring/values.yaml, so absence has nothing to fall
through to and the generated schema advertises the shipped (off) state.
- Drop the fail-on-empty guard in templates/vtraces/vtraces.yaml. Nothing
produces spans until the collector, so an absent backend drops no data. The
collector PR re-adds the guard, where it becomes correct (an enabled producer
with no backend really would drop spans — the logsStorages #3181 rationale).
- healthCheckExprs stay unconditional (Flux evaluates them only against CRs
present in the inventory, so they are inert when nothing renders).
- Tests: replace the empty->fail case with off-by-default (renders nothing);
set tracingStorages explicitly where cases relied on the old default.
Signed-off-by: Alexey Artamonov <[email protected]>1 parent b2e233b commit 25de4d8
8 files changed
Lines changed: 69 additions & 59 deletions
File tree
- packages
- extra/monitoring
- system
- monitoring-rd/cozyrds
- monitoring
- templates/vtraces
- tests
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
55 | 55 | | |
56 | 56 | | |
57 | 57 | | |
58 | | - | |
59 | | - | |
60 | | - | |
61 | | - | |
62 | | - | |
63 | | - | |
64 | | - | |
65 | | - | |
66 | | - | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
67 | 67 | | |
68 | 68 | | |
69 | 69 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
324 | 324 | | |
325 | 325 | | |
326 | 326 | | |
327 | | - | |
| 327 | + | |
328 | 328 | | |
329 | | - | |
330 | | - | |
331 | | - | |
332 | | - | |
333 | | - | |
334 | | - | |
335 | | - | |
336 | | - | |
337 | | - | |
| 329 | + | |
338 | 330 | | |
339 | 331 | | |
340 | 332 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
108 | 108 | | |
109 | 109 | | |
110 | 110 | | |
111 | | - | |
112 | | - | |
113 | | - | |
114 | | - | |
115 | | - | |
116 | | - | |
117 | | - | |
| 111 | + | |
| 112 | + | |
118 | 113 | | |
119 | 114 | | |
120 | 115 | | |
| |||
0 commit comments