Skip to content

Commit 198b809

Browse files
myasnikovdaniilmyasnikovdaniil
committed
docs(ci): correct the select-e2e.sh escalation claim in e2e-fork (#3262)
Both comments stated that select-e2e.sh escalates to the full suite on any unrecognised path, so fork TIA "can only narrow". That is not what it does: it escalates for an unrecognised path INSIDE packages/, but a path it does not recognise at all (hack/*.mk, for one) selects nothing, the Chainsaw step is skipped, and the required status still concludes success. Found by coderabbitai in review. The behaviour is pre-existing and identical for same-repo PRs through pull-requests.yaml, so it is tracked separately in #3392 rather than fixed on the fork lane alone — which would leave forks stricter than same-repo for the same diff. Correct the comments here so the guarantee is not overstated in the meantime. Signed-off-by: Myasnikov Daniil <[email protected]>
1 parent 5355d7c commit 198b809

1 file changed

Lines changed: 9 additions & 4 deletions

File tree

‎.github/workflows/e2e-fork.yaml‎

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -175,8 +175,11 @@ jobs:
175175
// base-repo PR labels drive the full-e2e override. Deriving these
176176
// from `git diff` on the fork-controlled merge ref would let a fork
177177
// shape the diff so TIA selects nothing and e2e is skipped — the
178-
// same class of bypass #3257 closes. select-e2e.sh fails safe to the
179-
// full suite on any unrecognised path, so this can only narrow.
178+
// same class of bypass #3257 closes. Note select-e2e.sh escalates
179+
// to the full suite for an unrecognised path INSIDE packages/, but
180+
// silently selects nothing for a path it does not recognise at all
181+
// (e.g. hack/*.mk) — a pre-existing fail-open shared with the
182+
// in-tree lane, tracked in #3392.
180183
// Both sides of a rename go to TIA too: the old path is a removal
181184
// the selector must see (a moved packages/<app>/… still affects
182185
// that app's suite). Extra paths can only widen the selection.
@@ -445,8 +448,10 @@ jobs:
445448
# affects. The changed-file list is resolve's TRUSTED base-repo listFiles
446449
# (base64 through the job output), NOT a git diff on the fork-controlled
447450
# merge ref — so a fork cannot shape the diff to make TIA select nothing.
448-
# select-e2e.sh escalates to the full suite on any unrecognised path, so
449-
# this only narrows. Skipped (→ full suite below) on the full-e2e label.
451+
# select-e2e.sh escalates to the full suite for an unrecognised path
452+
# inside packages/; a path it does not recognise at all selects nothing
453+
# and the run below is skipped (#3392 — same in the in-tree lane).
454+
# Skipped (→ full suite below) on the full-e2e label.
450455
- name: Select E2E tests
451456
id: select
452457
if: ${{ needs.resolve.outputs.full_e2e != 'true' }}

0 commit comments

Comments
 (0)