|
| 1 | +suite: networking variant change guard (lookup of the live cozystack.networking Package) |
| 2 | + |
| 3 | +# A new networking variant is not a migration. The operator reconciles the |
| 4 | +# Package against the new variant and deletes every HelmRelease of the Package |
| 5 | +# that the new variant does not install: isp-full -> isp-hosted (noop) removes |
| 6 | +# cilium and kubeovn, isp-full -> isp-slim (cilium) removes kubeovn. The guard |
| 7 | +# reads the live Package and is inert where lookup returns nothing (helm |
| 8 | +# template, client-side dry-run, fresh install). |
| 9 | +templates: |
| 10 | + - templates/bundles/system.yaml |
| 11 | +release: |
| 12 | + name: cozystack |
| 13 | + namespace: cozy-system |
| 14 | +set: |
| 15 | + bundles: |
| 16 | + system: |
| 17 | + enabled: true |
| 18 | + variant: isp-full |
| 19 | +tests: |
| 20 | + - it: refuses isp-full -> isp-hosted on a live kubeovn-cilium cluster and names the acknowledge value |
| 21 | + set: |
| 22 | + bundles: |
| 23 | + system: |
| 24 | + variant: isp-hosted |
| 25 | + kubernetesProvider: |
| 26 | + scheme: &scheme |
| 27 | + "cozystack.io/v1alpha1/Package": |
| 28 | + gvr: {group: "cozystack.io", version: "v1alpha1", resource: "packages"} |
| 29 | + namespaced: false |
| 30 | + objects: &liveKubeovnCilium |
| 31 | + - kind: Package |
| 32 | + apiVersion: cozystack.io/v1alpha1 |
| 33 | + metadata: {name: cozystack.networking} |
| 34 | + spec: {variant: kubeovn-cilium} |
| 35 | + asserts: |
| 36 | + - failedTemplate: |
| 37 | + errorPattern: 'cozystack.networking Package runs variant "kubeovn-cilium".*render would switch it to "noop".*restore the previous spec.variant of the cozystack.cozystack-platform Package.*networking.acknowledgeVariantChange: "noop" in its spec.components.platform.values' |
| 38 | + |
| 39 | + - it: refuses isp-full -> isp-slim on a live kubeovn-cilium cluster |
| 40 | + set: |
| 41 | + bundles: |
| 42 | + system: |
| 43 | + variant: isp-slim |
| 44 | + kubernetesProvider: |
| 45 | + scheme: *scheme |
| 46 | + objects: *liveKubeovnCilium |
| 47 | + asserts: |
| 48 | + - failedTemplate: |
| 49 | + errorPattern: 'runs variant "kubeovn-cilium".*switch it to "cilium".*networking.acknowledgeVariantChange: "cilium"' |
| 50 | + |
| 51 | + # Nothing is deleted on this switch, so the error must not say otherwise. |
| 52 | + - it: refuses isp-hosted -> isp-full on a live noop cluster |
| 53 | + kubernetesProvider: |
| 54 | + scheme: *scheme |
| 55 | + objects: |
| 56 | + - kind: Package |
| 57 | + apiVersion: cozystack.io/v1alpha1 |
| 58 | + metadata: {name: cozystack.networking} |
| 59 | + spec: {variant: noop} |
| 60 | + asserts: |
| 61 | + - failedTemplate: |
| 62 | + errorPattern: 'runs variant "noop".*switch it to "kubeovn-cilium".*deletes any HelmRelease of that Package the new variant does not install \(none if it installs everything the current one does\)' |
| 63 | + |
| 64 | + - it: treats a live Package without spec.variant as the default variant |
| 65 | + kubernetesProvider: |
| 66 | + scheme: *scheme |
| 67 | + objects: |
| 68 | + - kind: Package |
| 69 | + apiVersion: cozystack.io/v1alpha1 |
| 70 | + metadata: {name: cozystack.networking} |
| 71 | + spec: {} |
| 72 | + asserts: |
| 73 | + - failedTemplate: |
| 74 | + errorPattern: 'runs variant "default".*switch it to "kubeovn-cilium"' |
| 75 | + |
| 76 | + # No bundle renders cilium-kilo, so a live one was set by hand. Acknowledging |
| 77 | + # lets the render write the bundle's variant over it, so the error has to |
| 78 | + # point such a cluster at disabledPackages instead. |
| 79 | + - it: points a hand-set live variant at disabledPackages |
| 80 | + kubernetesProvider: |
| 81 | + scheme: *scheme |
| 82 | + objects: &liveCiliumKilo |
| 83 | + - kind: Package |
| 84 | + apiVersion: cozystack.io/v1alpha1 |
| 85 | + metadata: {name: cozystack.networking} |
| 86 | + spec: {variant: cilium-kilo} |
| 87 | + asserts: |
| 88 | + - failedTemplate: |
| 89 | + errorPattern: 'runs variant "cilium-kilo".*restore the previous spec.variant of the cozystack.cozystack-platform Package.*networking.acknowledgeVariantChange: "kubeovn-cilium".*If the live variant was set by hand and has to stay, add cozystack.networking to bundles.disabledPackages: acknowledging lets this render replace it' |
| 90 | + |
| 91 | + - it: lets an acknowledged switch replace a hand-set live variant |
| 92 | + set: |
| 93 | + networking: |
| 94 | + acknowledgeVariantChange: kubeovn-cilium |
| 95 | + kubernetesProvider: |
| 96 | + scheme: *scheme |
| 97 | + objects: *liveCiliumKilo |
| 98 | + documentSelector: |
| 99 | + path: metadata.name |
| 100 | + value: cozystack.networking |
| 101 | + asserts: |
| 102 | + - equal: |
| 103 | + path: spec.variant |
| 104 | + value: kubeovn-cilium |
| 105 | + |
| 106 | + - it: renders when the live variant matches the rendered one |
| 107 | + kubernetesProvider: |
| 108 | + scheme: *scheme |
| 109 | + objects: *liveKubeovnCilium |
| 110 | + documentSelector: |
| 111 | + path: metadata.name |
| 112 | + value: cozystack.networking |
| 113 | + asserts: |
| 114 | + - equal: |
| 115 | + path: spec.variant |
| 116 | + value: kubeovn-cilium |
| 117 | + |
| 118 | + - it: renders the change when acknowledgeVariantChange names the new variant |
| 119 | + set: |
| 120 | + bundles: |
| 121 | + system: |
| 122 | + variant: isp-hosted |
| 123 | + networking: |
| 124 | + acknowledgeVariantChange: noop |
| 125 | + kubernetesProvider: |
| 126 | + scheme: *scheme |
| 127 | + objects: *liveKubeovnCilium |
| 128 | + documentSelector: |
| 129 | + path: metadata.name |
| 130 | + value: cozystack.networking |
| 131 | + asserts: |
| 132 | + - equal: |
| 133 | + path: spec.variant |
| 134 | + value: noop |
| 135 | + |
| 136 | + # The acknowledgement is bound to one target, so a value left behind after |
| 137 | + # one switch does not wave through the next one. |
| 138 | + - it: still refuses when acknowledgeVariantChange names a different variant |
| 139 | + set: |
| 140 | + bundles: |
| 141 | + system: |
| 142 | + variant: isp-hosted |
| 143 | + networking: |
| 144 | + acknowledgeVariantChange: cilium |
| 145 | + kubernetesProvider: |
| 146 | + scheme: *scheme |
| 147 | + objects: *liveKubeovnCilium |
| 148 | + asserts: |
| 149 | + - failedTemplate: |
| 150 | + errorPattern: 'networking.acknowledgeVariantChange: "noop"' |
| 151 | + |
| 152 | + - it: still refuses when acknowledgeVariantChange is a bare boolean |
| 153 | + set: |
| 154 | + bundles: |
| 155 | + system: |
| 156 | + variant: isp-hosted |
| 157 | + networking: |
| 158 | + acknowledgeVariantChange: true |
| 159 | + kubernetesProvider: |
| 160 | + scheme: *scheme |
| 161 | + objects: *liveKubeovnCilium |
| 162 | + asserts: |
| 163 | + - failedTemplate: |
| 164 | + errorPattern: 'networking.acknowledgeVariantChange: "noop"' |
| 165 | + |
| 166 | + # A Package left out of the render is not re-rendered, so Helm does not |
| 167 | + # touch its variant; helm.sh/resource-policy: keep leaves it as it is. |
| 168 | + - it: renders when cozystack.networking is in bundles.disabledPackages |
| 169 | + set: |
| 170 | + bundles: |
| 171 | + system: |
| 172 | + variant: isp-hosted |
| 173 | + disabledPackages: |
| 174 | + - cozystack.networking |
| 175 | + kubernetesProvider: |
| 176 | + scheme: *scheme |
| 177 | + objects: *liveKubeovnCilium |
| 178 | + asserts: |
| 179 | + - containsDocument: |
| 180 | + apiVersion: cozystack.io/v1alpha1 |
| 181 | + kind: Package |
| 182 | + name: cozystack.networking |
| 183 | + any: true |
| 184 | + not: true |
| 185 | + |
| 186 | + - it: renders offline (no live Package) for isp-hosted |
| 187 | + set: |
| 188 | + bundles: |
| 189 | + system: |
| 190 | + variant: isp-hosted |
| 191 | + documentSelector: |
| 192 | + path: metadata.name |
| 193 | + value: cozystack.networking |
| 194 | + asserts: |
| 195 | + - equal: |
| 196 | + path: spec.variant |
| 197 | + value: noop |
| 198 | + |
| 199 | + - it: renders offline (no live Package) for isp-slim |
| 200 | + set: |
| 201 | + bundles: |
| 202 | + system: |
| 203 | + variant: isp-slim |
| 204 | + documentSelector: |
| 205 | + path: metadata.name |
| 206 | + value: cozystack.networking |
| 207 | + asserts: |
| 208 | + - equal: |
| 209 | + path: spec.variant |
| 210 | + value: cilium |
| 211 | + |
| 212 | + - it: renders on a cluster that has other Packages but no cozystack.networking yet |
| 213 | + set: |
| 214 | + bundles: |
| 215 | + system: |
| 216 | + variant: isp-full-generic |
| 217 | + kubernetesProvider: |
| 218 | + scheme: *scheme |
| 219 | + objects: |
| 220 | + - kind: Package |
| 221 | + apiVersion: cozystack.io/v1alpha1 |
| 222 | + metadata: {name: cozystack.cert-manager} |
| 223 | + spec: {variant: default} |
| 224 | + documentSelector: |
| 225 | + path: metadata.name |
| 226 | + value: cozystack.networking |
| 227 | + asserts: |
| 228 | + - equal: |
| 229 | + path: spec.variant |
| 230 | + value: kubeovn-cilium-generic |
0 commit comments