Skip to content

Commit 10d13ce

Browse files
ci(build): gate finalize on the unit/controller checks job
finalize (and therefore e2e, which needs it) now depends on the checks job succeeding, so a red unit/controller test skips the expensive install+e2e path instead of running it for ~1h. Restores the gating the old in-build-job tests gave, without re-coupling the cheap parallel image builds. Refs #2937 Assisted-By: Claude <[email protected]> Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]> Signed-off-by: Myasnikov Daniil <[email protected]>
1 parent 35d8024 commit 10d13ce

1 file changed

Lines changed: 6 additions & 1 deletion

File tree

‎.github/workflows/pull-requests.yaml‎

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -237,11 +237,16 @@ jobs:
237237
# already be applied here. e2e consumes the resulting pr.patch unchanged.
238238
finalize:
239239
name: Finalize (merge patches + installer)
240-
needs: ["plan", "build", "build-talos"]
240+
# Depends on `checks` too: gating finalize on unit/controller tests cascades
241+
# to e2e (which needs finalize), so a red unit test skips the expensive
242+
# install+e2e path instead of wasting ~1h on it. Restores the gating the old
243+
# in-build-job tests gave, without re-coupling the cheap parallel builds.
244+
needs: ["plan", "checks", "build", "build-talos"]
241245
if: |
242246
always()
243247
&& needs.plan.outputs.code == 'true'
244248
&& !contains(github.event.pull_request.labels.*.name, 'release')
249+
&& needs.checks.result == 'success'
245250
&& (needs.build.result == 'success' || needs.build.result == 'skipped')
246251
&& needs.build-talos.result == 'success'
247252
runs-on: ${{ contains(github.event.pull_request.labels.*.name, 'debug') && 'self-hosted' || 'oracle-vm-4cpu-16gb-x86-64' }}

0 commit comments

Comments
 (0)