Repository navigation
Commit 0dec1bc
committed
fix(lineage): never cache RESTMapping failures
The apps.cozystack.io kinds resolved during the ownership walk are
served by the aggregated cozystack-api, so discovery fails transiently
while it rolls or before a new ApplicationDefinition is discovered.
Caching such a failure marked every object admitted within the TTL
window unmanaged — permanently, since the webhook's objectSelector
never re-admits labeled objects. Return the error uncached, matching
the treatment of transient GET errors; steady-state cost is nil since
the mapper serves mappings from its own discovery cache.
Also document the read-only contract of ObjectCache.Get and stop
over-claiming that sampling eviction bounds the map size.
Signed-off-by: Mattia Eleuteri <[email protected]>1 parent 697d81c commit 0dec1bc
2 files changed
Lines changed: 16 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
55 | 55 | | |
56 | 56 | | |
57 | 57 | | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
58 | 62 | | |
59 | 63 | | |
60 | 64 | | |
| |||
69 | 73 | | |
70 | 74 | | |
71 | 75 | | |
72 | | - | |
73 | | - | |
| 76 | + | |
| 77 | + | |
74 | 78 | | |
75 | 79 | | |
76 | 80 | | |
| |||
117 | 121 | | |
118 | 122 | | |
119 | 123 | | |
120 | | - | |
121 | | - | |
122 | | - | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
123 | 127 | | |
124 | 128 | | |
125 | 129 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
231 | 231 | | |
232 | 232 | | |
233 | 233 | | |
234 | | - | |
235 | | - | |
| 234 | + | |
| 235 | + | |
| 236 | + | |
| 237 | + | |
| 238 | + | |
| 239 | + | |
| 240 | + | |
236 | 241 | | |
237 | 242 | | |
238 | 243 | | |
| |||
0 commit comments