Skip to content

Commit 0cae0e8

Browse files
committed
test(e2e): spell the find negation as -not in the suite-list helper
The negated-assertion audit splits a line on `(` and reads the `!` after `\(` as a shell negation that errexit would exempt, so the helper's find predicate fails the audit and the unit tests on main. `-not` is the same predicate in GNU, BSD and busybox find and does not look like one. Assisted-by: LLM Signed-off-by: Aleksei Sviridkin <[email protected]>
1 parent c854e05 commit 0cae0e8

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

‎hack/select-e2e_test.bats‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
# expanded, but not which side is which, and reading a whole-tree diff off a trace
3232
# line is exactly the moment a test stops being worth having.
3333
full_suite_list() {
34-
find hack/e2e-chainsaw -mindepth 2 \( ! -type d -o -name chainsaw-test.yaml -o -name chainsaw-test.yml \) \
34+
find hack/e2e-chainsaw -mindepth 2 \( -not -type d -o -name chainsaw-test.yaml -o -name chainsaw-test.yml \) \
3535
| sed -nE 's,^hack/e2e-chainsaw/([^/]+)/(.*/)?(chainsaw-test|[0-9]+-[^/]*)\.ya?ml$,\1,p' \
3636
| sort -u | paste -sd ' ' -
3737
}

0 commit comments

Comments
 (0)