Repository navigation
Commit 091b854
authored
build(images): run the tests of the packages the patches touch (#4326)
## What this PR does
Twelve first-party images that are built from an upstream tree with
patches on top now run `go test` on the packages those patches touch.
The step sits in the builder stage, right after the patches are applied.
Before this, ten of them ran `go build` only, and `go build` never
compiles a `_test.go`, so a test carried inside a patch was proven once
by hand and never again. The other two, opensearch-operator and
kube-ovn, ran a `go test` line written by hand, which a patch reaching a
new directory would slip past; the loop replaces both lines.
The package list is read from the patches themselves with `git apply
--numstat`, so a new patch is covered without an edit to the Dockerfile.
Each package is tested from its own directory, which finds nested
modules: in objectstorage, `internal/` is a module of its own and the
root module cannot name `./internal/runtime`. An empty list runs
nothing. The list is read into a variable before the loop, because a
`for` loop drops the exit status of a command substitution, and a patch
that git cannot read would otherwise give an empty list and a green
step.
A few images need more than the plain loop:
- opensearch-operator skips `controllers/`. A patch touches it, but its
suite starts an envtest control plane from etcd and kube-apiserver
binaries the builder does not have. The loop runs with `-race` and
replaces the hand-picked `go test -race` line, which also covered
`pkg/reconcilers/util`, a package no patch touches.
- kube-ovn drops its `go test -run '^TestVMIMigrationSchedulingRetry$'`
line. The test it named is copied into `pkg/controller`, which a patch
touches, so the loop runs it along with the rest of that package.
- redis-operator also runs `go vet -tags integration` in each touched
directory. Two of the files its patches edit are upstream integration
tests behind that tag, and `go test` compiles none of them.
- cluster-autoscaler and kubevirt-cloud-provider export `GOOS` and
`GOARCH` for the target in the whole builder stage, so their tests unset
both. A local `make image` builds amd64 and arm64 by default, and a test
binary for the other architecture runs on the build host only under
binfmt emulation. CI is not affected either way: the jobs that build
package images each pin one `PLATFORM` that matches the runner's
architecture.
The first run of the step on cluster-autoscaler found the carried
`fix-downscale.diff` out of step with the upstream tests it leaves in
place. The patch removes the `maxSize` refusal from `SetSize`, and one
case of `TestNodeGroupIncreaseSizeErrors` still expected that refusal.
The patch now drops that case and carries
`TestNodeGroupDeleteNodesAboveMaxSize` instead. That test covers the
downscale the patch is named for: `DeleteNodes` lowers a group through
`SetSize`, so with the refusal in place a group standing above its max
size could not shed a node. Against the unpatched `SetSize` the new test
fails. The image's behaviour does not change, and scale-up stays bounded
by the core scale-up orchestrator, which skips a node group already at
its max size.
CI builds all twelve images, and the step reports `ok` or `no test
files` for every package it tests. Locally, the redis-operator,
opensearch-operator and kube-ovn builder stages pass. The
cluster-autoscaler package was checked from the
`cluster-autoscaler-1.32.0` tag tarball, because the Dockerfile's full
clone of kubernetes/autoscaler does not survive my network. As negative
controls, an undefined call added to a redis integration test fails `go
vet -tags integration` while `go test` still passes, and the new
autoscaler test fails without the patch.
Left out on purpose, and the Dockerfile says so: `multus`. Its only
touched package, `pkg/multus`, creates network namespaces in its tests,
which a build container cannot do (`mount --make-rshared /var/run/netns:
operation not permitted`). `cilium` (C, no compile step) and
`piraeus-server` (Java) are out of scope.
Closes #4318
### Screenshots
Not a UI change.
### Downstream repositories
Walked the trigger map against the diff: Dockerfiles under
`packages/*/images/` and one patch file. No values key, schema, make
target, `hack/` file or documented workflow changes.
- [x] No downstream repository is affected by this change
- [ ] [cozystack/website](https://github.com/cozystack/website) -
follow-up:
- [ ]
[cozystack/terraform-provider-cozystack](https://github.com/cozystack/terraform-provider-cozystack)
- follow-up:
- [ ]
[cozystack/ansible-cozystack](https://github.com/cozystack/ansible-cozystack)
- follow-up:
- [ ] [cozystack/ccp](https://github.com/cozystack/ccp) - follow-up:
- [ ] [cozystack/talm](https://github.com/cozystack/talm) - follow-up:
- [ ] [cozystack/cozyhr](https://github.com/cozystack/cozyhr) -
follow-up:
- [ ] [cozystack/cozy-proxy](https://github.com/cozystack/cozy-proxy) -
follow-up:
- [ ]
[cozystack/cozystack-telemetry-server](https://github.com/cozystack/cozystack-telemetry-server)
- follow-up:
- [ ]
[cozystack/external-apps-example](https://github.com/cozystack/external-apps-example)
- follow-up:
- [ ] [cozystack/examples](https://github.com/cozystack/examples) -
follow-up:
- [ ] [cozystack/community](https://github.com/cozystack/community) -
follow-up:
### Release note
```release-note
NONE
```14 files changed
Lines changed: 233 additions & 8 deletions
File tree
- packages
- apps/kubernetes/images
- cluster-autoscaler
- kubevirt-cloud-provider
- system
- bucket/images/s3manager
- capi-providers-cpprovider/images/cluster-api-control-plane-provider-kamaji
- kamaji/images/kamaji
- keycloak-operator/images/keycloak-operator
- kilo/images/kilo
- kubeovn/images/kubeovn
- linstor/images/linstor-csi
- multus/images/multus-cni
- objectstorage-controller/images/objectstorage
- opensearch-operator/images/opensearch-operator
- redis-operator/images/redis-operator
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
19 | 35 | | |
20 | 36 | | |
21 | 37 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
22 | 36 | | |
23 | 37 | | |
24 | 38 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
13 | 25 | | |
14 | 26 | | |
15 | 27 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
25 | 25 | | |
26 | 26 | | |
27 | 27 | | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
28 | 39 | | |
29 | 40 | | |
30 | 41 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
15 | 26 | | |
16 | 27 | | |
17 | 28 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
24 | 38 | | |
25 | 39 | | |
26 | 40 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
15 | 26 | | |
16 | 27 | | |
17 | 28 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
| 15 | + | |
15 | 16 | | |
16 | | - | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
17 | 29 | | |
18 | 30 | | |
19 | 31 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
24 | 35 | | |
25 | 36 | | |
26 | 37 | | |
| |||
0 commit comments