Skip to content

Commit 00d8fd8

Browse files
committed
test(monitoring): pin verified VictoriaTraces query URLs; jaeger stable default
Datasource service/port/path verified against upstream docs (https://docs.victoriametrics.com/victoriatraces/querying/grafana/): cluster vtselect:10471/select/jaeger, single vtsingle:10428/select/jaeger. Jaeger is the stable, built-in Grafana core datasource; the Tempo API (/select/tempo, type: tempo, VictoriaTraces v0.9.4+) is upstream-experimental, kept as a documented alternative. Add helm-unittest assertions pinning both the cluster and single-mode query URLs. Signed-off-by: Alexey Artamonov <[email protected]>
1 parent cd68f06 commit 00d8fd8

2 files changed

Lines changed: 29 additions & 8 deletions

File tree

‎packages/system/monitoring/templates/vtraces/grafana-datasource.yaml‎

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -7,13 +7,17 @@ metadata:
77
spec:
88
datasource:
99
access: proxy
10-
# VictoriaTraces exposes a Jaeger-compatible query API, and `jaeger` is a
11-
# built-in Grafana datasource (no plugin install needed, unlike the logs
12-
# datasource). The exact select service name, port and query path below are
13-
# confirm-before-implementation against the pinned VictoriaTraces version
14-
# (see design-proposals/distributed-tracing in cozystack/community#38); the
15-
# upstream query API is also converging on a Tempo-compatible surface, so
16-
# `type` may switch to `tempo` once confirmed on a live cluster.
10+
# VictoriaTraces serves a Jaeger Query Service API on its select component;
11+
# `jaeger` is a built-in Grafana datasource (no plugin install needed,
12+
# unlike the logs datasource). Ports/paths are per upstream docs
13+
# (https://docs.victoriametrics.com/victoriatraces/querying/grafana/):
14+
# cluster -> vtselect :10471/select/jaeger
15+
# single -> vtsingle :10428/select/jaeger
16+
# Service names follow the operator's vt-prefix convention (as vlselect-*
17+
# for VLCluster). VictoriaTraces also serves a Tempo Query API
18+
# (/select/tempo, Grafana `tempo` datasource, v0.9.4+) with richer TraceQL
19+
# UX, but that surface is upstream-experimental, so the stable Jaeger API is
20+
# the default here.
1721
type: jaeger
1822
name: vtraces-{{ .name }}
1923
{{- if eq (.mode | default "cluster") "single" }}

‎packages/system/monitoring/tests/vtraces_tracingstorages_required_test.yaml‎

Lines changed: 18 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ tests:
8383
path: spec.storage.retentionMaxDiskSpaceUsageBytes
8484
value: "8GB"
8585

86-
- it: renders a Jaeger-typed Grafana datasource per tracingStorages entry
86+
- it: renders a Jaeger-typed Grafana datasource at vtselect:10471 for cluster mode
8787
templates:
8888
- templates/vtraces/grafana-datasource.yaml
8989
asserts:
@@ -94,6 +94,23 @@ tests:
9494
- equal:
9595
path: spec.datasource.type
9696
value: jaeger
97+
- equal:
98+
path: spec.datasource.url
99+
value: http://vtselect-generic.tenant-root.svc:10471/select/jaeger
100+
101+
- it: points the datasource at vtsingle:10428 for single mode
102+
templates:
103+
- templates/vtraces/grafana-datasource.yaml
104+
set:
105+
tracingStorages:
106+
- name: generic
107+
mode: single
108+
retentionPeriod: "14d"
109+
storage: 10Gi
110+
asserts:
111+
- equal:
112+
path: spec.datasource.url
113+
value: http://vtsingle-generic.tenant-root.svc:10428/select/jaeger
97114

98115
- it: fails the render when tracingStorages is empty
99116
templates:

0 commit comments

Comments
 (0)