Repository navigation
docs(gpudevice): propose class-attributed GPU usage - #130
Open
Aleksei Sviridkin (lexfrei) wants to merge 1 commit into
Open
Aleksei Sviridkin (lexfrei) wants to merge 1 commit into
Aleksei Sviridkin (lexfrei) wants to merge 1 commit into
Conversation
The implementation of step 1 added recorded resource-name ownership to keep the unique name a usage record is mapped through. Carrying the admitted class into the usage record removes the need for uniqueness, and the record answers the review questions about the recorded owner. A second record proposes dropping tolerationSeconds from class tolerations before the kind is released, since a finite toleration evicts the VM after it is placed. Assisted-by: LLM Signed-off-by: Aleksei Sviridkin <[email protected]>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
1 of 12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This proposes two changes of course in the GPU proposal, both raised in the review of the step 1 API in cozystack/cozystack#4998. Both records are
Proposedand becomeAcceptedwhen this merges.0019 makes the usage record carry the class a VM was admitted with. Today a class must own its resource name, because billing maps a
Workloadrecord back to a class through that name. The implementation had to record the owner instatus.ownedResourceNameto keep that working whenresourceNamechanges. With the class in the record, two classes can share a resource name, the recorded owner andResourceNameConflictgo away, and a licensed class can sit next to a bring-your-own-license class on one vGPU profile. The record also answers the three questions from the review: why the owner was recorded state, what happens when status is lost, and why duplicates fail closed. It lists who can and cannot set the class on a usage record.0020 drops
tolerationSecondsfrom class tolerations before the kind is released. A finite toleration reaches the launcher pod and evicts the VM after it was placed, and the design does not need it.Before review
decisions/directory, or says below why none is needed.Both are decision records under
gpudevice, linked from itsDecisionssection.DCO
git commit --signoff).